[GitHub] [geode-native] gaussianrecurrence opened a new pull request #653: GEODE-8512: Add expectDomainClass for PdxInstance

2020-09-18 Thread GitBox
gaussianrecurrence opened a new pull request #653: URL: https://github.com/apache/geode-native/pull/653 Add Cache::createPdxInstanceFactory overload with expectDomainClass parameter This is an automated message from the

[GitHub] [geode-native] moleske merged pull request #652: GEODE-8508: Update LGTM to use Geode 1.13

2020-09-18 Thread GitBox
moleske merged pull request #652: URL: https://github.com/apache/geode-native/pull/652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] demery-pivotal closed pull request #5515: Give each gradle worker a unique subdir name

2020-09-18 Thread GitBox
demery-pivotal closed pull request #5515: URL: https://github.com/apache/geode/pull/5515 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt merged pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
bschuchardt merged pull request #5525: URL: https://github.com/apache/geode/pull/5525 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jhutchison opened a new pull request #5526: Geode 8504 info command

2020-09-18 Thread GitBox
jhutchison opened a new pull request #5526: URL: https://github.com/apache/geode/pull/5526 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491066133 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer acquireDirectBuffer(int size,

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491065723 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java ## @@ -133,27 +135,42 @@ public void

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491065581 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java ## @@ -133,27 +135,42 @@ public void

[GitHub] [geode] echobravopapa closed pull request #5520: Wip/remove shared sender conns

2020-09-18 Thread GitBox
echobravopapa closed pull request #5520: URL: https://github.com/apache/geode/pull/5520 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] echobravopapa commented on pull request #5520: Wip/remove shared sender conns

2020-09-18 Thread GitBox
echobravopapa commented on pull request #5520: URL: https://github.com/apache/geode/pull/5520#issuecomment-694954494 experiment no longer needed This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] bschuchardt commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
bschuchardt commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491045634 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -295,19 +302,48 @@ void releaseBuffer(BufferPool.BufferType

[GitHub] [geode] bschuchardt commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
bschuchardt commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491044218 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r490654223 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer acquireDirectBuffer(int size,

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491018765 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -295,19 +302,48 @@ void releaseBuffer(BufferPool.BufferType type,

[GitHub] [geode] bschuchardt commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
bschuchardt commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491016215 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer

[GitHub] [geode] bschuchardt commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-18 Thread GitBox
bschuchardt commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r491013014 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -295,19 +302,48 @@ void releaseBuffer(BufferPool.BufferType

[GitHub] [geode-native] alb3rtobr opened a new pull request #652: GEODE-8508: Update LGTM to use Geode 1.13

2020-09-18 Thread GitBox
alb3rtobr opened a new pull request #652: URL: https://github.com/apache/geode-native/pull/652 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] Bill commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
Bill commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r490648118 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/BufferPoolTest.java ## @@ -133,27 +135,42 @@ public void

[GitHub] [geode] echobravopapa commented on a change in pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
echobravopapa commented on a change in pull request #5525: URL: https://github.com/apache/geode/pull/5525#discussion_r490616848 ## File path: geode-core/src/main/java/org/apache/geode/internal/net/BufferPool.java ## @@ -98,14 +101,18 @@ private ByteBuffer

[GitHub] [geode] bschuchardt opened a new pull request #5525: GEODE-8506: BufferPool returns byte buffers that may be much larger t…

2020-09-17 Thread GitBox
bschuchardt opened a new pull request #5525: URL: https://github.com/apache/geode/pull/5525 …han requested Create a "slice" of the acquired buffer to return to the caller instead of returning a buffer larger than what was requested. On return we fish out the parent buffer and

[GitHub] [geode] jhuynh1 opened a new pull request #5524: WIP: Changes for usability

2020-09-17 Thread GitBox
jhuynh1 opened a new pull request #5524: URL: https://github.com/apache/geode/pull/5524 Create DiskStore REST API This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [geode] jdeppe-pivotal merged pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5523: URL: https://github.com/apache/geode/pull/5523 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] onichols-pivotal commented on pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
onichols-pivotal commented on pull request #5523: URL: https://github.com/apache/geode/pull/5523#issuecomment-694437262 as a general rule for bumping dependencies, `git grep 4\\.1\\.48` for everywhere the version appears so you don't miss any files

[GitHub] [geode] jdeppe-pivotal merged pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5522: URL: https://github.com/apache/geode/pull/5522 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5523: GEODE-8505: Upgrade netty from 4.1.48 to 4.1.52

2020-09-17 Thread GitBox
jdeppe-pivotal opened a new pull request #5523: URL: https://github.com/apache/geode/pull/5523 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] dschneider-pivotal closed pull request #5513: changed PubSubDUnitTest

2020-09-17 Thread GitBox
dschneider-pivotal closed pull request #5513: URL: https://github.com/apache/geode/pull/5513 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5521: GEODE-8500: Tests for Redis QUIT command

2020-09-17 Thread GitBox
dschneider-pivotal merged pull request #5521: URL: https://github.com/apache/geode/pull/5521 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal merged pull request #5511: GEODE-8493: Redis idle clients can cause server stuck thread warning

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5511: URL: https://github.com/apache/geode/pull/5511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] mreddington closed pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-17 Thread GitBox
mreddington closed pull request #650: URL: https://github.com/apache/geode-native/pull/650 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal commented on pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal commented on pull request #5522: URL: https://github.com/apache/geode/pull/5522#issuecomment-694319828 @sabbey @ringles @jhutchison for your review... This is an automated message from the Apache Git Service.

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5522: GEODE-8503: Limit netty threads used in PubSubDUnitTest

2020-09-17 Thread GitBox
jdeppe-pivotal opened a new pull request #5522: URL: https://github.com/apache/geode/pull/5522 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode-native] alb3rtobr opened a new pull request #651: Remove bucketServerLocation if timeout error

2020-09-17 Thread GitBox
alb3rtobr opened a new pull request #651: URL: https://github.com/apache/geode-native/pull/651 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-17 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r490270113 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jdeppe-pivotal merged pull request #5518: GEODE-8499: Redis subscriptions leak if they are not explicitly unsubscribed

2020-09-17 Thread GitBox
jdeppe-pivotal merged pull request #5518: URL: https://github.com/apache/geode/pull/5518 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] sabbeyPivotal commented on pull request #5518: GEODE-8499: Redis subscriptions leak if they are not explicitly unsubscribed

2020-09-17 Thread GitBox
sabbeyPivotal commented on pull request #5518: URL: https://github.com/apache/geode/pull/5518#issuecomment-694225105 Distributed test failure is unrelated to this PR This is an automated message from the Apache Git Service.

[GitHub] [geode-native] alb3rtobr commented on pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-17 Thread GitBox
alb3rtobr commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-694081548 Dont worry, I think its not needed to split this in two different tickets, I will try to write a test when I find time. Im moving this PR to draft in the meanwhile.

[GitHub] [geode] ringles opened a new pull request #5521: GEODE-8500: Tests for Redis QUIT command

2020-09-16 Thread GitBox
ringles opened a new pull request #5521: URL: https://github.com/apache/geode/pull/5521 Added tests, and now clear command queue when channelInactive() is called. This is an automated message from the Apache Git Service. To

[GitHub] [geode] echobravopapa opened a new pull request #5520: Wip/remove shared sender conns

2020-09-16 Thread GitBox
echobravopapa opened a new pull request #5520: URL: https://github.com/apache/geode/pull/5520 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] echobravopapa closed pull request #5519: Revert "GEODE-7727: modify sender thread to detect relese of connecti…

2020-09-16 Thread GitBox
echobravopapa closed pull request #5519: URL: https://github.com/apache/geode/pull/5519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] echobravopapa opened a new pull request #5519: Revert "GEODE-7727: modify sender thread to detect relese of connecti…

2020-09-16 Thread GitBox
echobravopapa opened a new pull request #5519: URL: https://github.com/apache/geode/pull/5519 …on (#4751)" This reverts commit c8413592e5573f675c538c63ef9ee9f97a349e73. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode] dschneider-pivotal merged pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

2020-09-16 Thread GitBox
dschneider-pivotal merged pull request #5510: URL: https://github.com/apache/geode/pull/5510 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] boglesby commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-16 Thread GitBox
boglesby commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r489565588 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] bschuchardt merged pull request #5491: GEODE-8473: Hang in ReplyProcessor21 when forced-disconnect does not establish a cancellation cause

2020-09-16 Thread GitBox
bschuchardt merged pull request #5491: URL: https://github.com/apache/geode/pull/5491 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal opened a new pull request #5518: GEODE-8499: Redis subscriptions leak if they are not explicitly unsubscribed

2020-09-16 Thread GitBox
sabbeyPivotal opened a new pull request #5518: URL: https://github.com/apache/geode/pull/5518 Subscription structures leak if clients disconnect without unsubscribing. Normally subscriptions should be cleaned up when a PUBLISH is attempted but fails. We should try and detect clients

[GitHub] [geode] albertogpz opened a new pull request #5517: Draft geode 8491 with serial gateway sender changes

2020-09-16 Thread GitBox
albertogpz opened a new pull request #5517: URL: https://github.com/apache/geode/pull/5517 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-16 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r489395559 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jchen21 closed pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-15 Thread GitBox
jchen21 closed pull request #5516: URL: https://github.com/apache/geode/pull/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jchen21 opened a new pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-15 Thread GitBox
jchen21 opened a new pull request #5516: URL: https://github.com/apache/geode/pull/5516 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] boglesby commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
boglesby commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r489081453 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] demery-pivotal opened a new pull request #5515: Give each gradle worker a unique subdir name

2020-09-15 Thread GitBox
demery-pivotal opened a new pull request #5515: URL: https://github.com/apache/geode/pull/5515 Give each gradle worker a unique subdir name. Then run each test type in the worker's unique subdir under the test type dir. Authored-by: Dale Emery Thank you for submitting a

[GitHub] [geode] rhoughton-pivot merged pull request #5291: [DRAFT] GEODE-8066: Pull up transitive dependency to clean up javax.activation and mail licenses.

2020-09-15 Thread GitBox
rhoughton-pivot merged pull request #5291: URL: https://github.com/apache/geode/pull/5291 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
jinmeiliao commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488855631 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] mivanac opened a new pull request #5514: GEODE-8497: added getTotalQueueSizeBytesInUse

2020-09-15 Thread GitBox
mivanac opened a new pull request #5514: URL: https://github.com/apache/geode/pull/5514 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] dschneider-pivotal opened a new pull request #5513: changed PubSubDUnitTest

2020-09-15 Thread GitBox
dschneider-pivotal opened a new pull request #5513: URL: https://github.com/apache/geode/pull/5513 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] BenjaminPerryRoss opened a new pull request #5512: Feature/geode 7671

2020-09-15 Thread GitBox
BenjaminPerryRoss opened a new pull request #5512: URL: https://github.com/apache/geode/pull/5512 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jinmeiliao commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
jinmeiliao commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488773618 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] agingade commented on a change in pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-15 Thread GitBox
agingade commented on a change in pull request #5507: URL: https://github.com/apache/geode/pull/5507#discussion_r488723747 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -30,14

[GitHub] [geode] albertogpz edited a comment on pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
albertogpz edited a comment on pull request #5509: URL: https://github.com/apache/geode/pull/5509#issuecomment-692514634 > A few code cleanup requests, but otherwise looks good. An elegant solution. @DonalEvans, thanks for the comments.

[GitHub] [geode] albertogpz commented on pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-15 Thread GitBox
albertogpz commented on pull request #5509: URL: https://github.com/apache/geode/pull/5509#issuecomment-692514634 > A few code cleanup requests, but otherwise looks good. An elegant solution. @Donal, thanks for the comments.

[GitHub] [geode] onichols-pivotal merged pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

2020-09-14 Thread GitBox
onichols-pivotal merged pull request #5502: URL: https://github.com/apache/geode/pull/5502 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] Bill commented on pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

2020-09-14 Thread GitBox
Bill commented on pull request #5502: URL: https://github.com/apache/geode/pull/5502#issuecomment-692404304 @jinmeiliao told me that management rest service is started by default in version 1.13.0, in earlier versions no rest service is started by default. So with her approval, and

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-14 Thread GitBox
echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r488291301 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

[GitHub] [geode] Bill edited a comment on pull request #5502: add 1.13.0 to old versions and set as Benchmarks baseline on develop

2020-09-14 Thread GitBox
Bill edited a comment on pull request #5502: URL: https://github.com/apache/geode/pull/5502#issuecomment-690783716 I've added @bschuchardt and @jinmeiliao as a reviewers since I want to be sure I'm not masking an actual problem by turning off the HTTP service in the WAN and Lucene rolling

[GitHub] [geode] sabbeyPivotal opened a new pull request #5511: GEODE-8493: Redis idle clients can cause server stuck thread warning

2020-09-14 Thread GitBox
sabbeyPivotal opened a new pull request #5511: URL: https://github.com/apache/geode/pull/5511 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

2020-09-14 Thread GitBox
sabbeyPivotal commented on a change in pull request #5510: URL: https://github.com/apache/geode/pull/5510#discussion_r488191271 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java ## @@ -177,6 +177,10 @@ public void removeClient() {

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

2020-09-14 Thread GitBox
dschneider-pivotal commented on a change in pull request #5510: URL: https://github.com/apache/geode/pull/5510#discussion_r488188475 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/RedisStats.java ## @@ -177,6 +177,10 @@ public void removeClient() {

[GitHub] [geode] sabbeyPivotal opened a new pull request #5510: GEODE-8492: Redis 'clients' statistic goes negative

2020-09-14 Thread GitBox
sabbeyPivotal opened a new pull request #5510: URL: https://github.com/apache/geode/pull/5510 When running a long running app, we noticed that our "clients" statistic was negative. It should always be greater than or equal to 0. It seems like the call to decrement the number of

[GitHub] [geode-native] mreddington commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-14 Thread GitBox
mreddington commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r488181280 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); } +#if

[GitHub] [geode-native] dgkimura commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-14 Thread GitBox
dgkimura commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r488167540 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash; const int

[GitHub] [geode] DonalEvans commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-14 Thread GitBox
DonalEvans commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488130840 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -1646,6 +1646,20 @@ public static void

[GitHub] [geode] dschneider-pivotal merged pull request #5505: GEODE-8487: Document Redis_API HA model, requirements, guarantees

2020-09-14 Thread GitBox
dschneider-pivotal merged pull request #5505: URL: https://github.com/apache/geode/pull/5505 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal merged pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

2020-09-14 Thread GitBox
jdeppe-pivotal merged pull request #5508: URL: https://github.com/apache/geode/pull/5508 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] moleske commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test

2020-09-14 Thread GitBox
moleske commented on a change in pull request #649: URL: https://github.com/apache/geode-native/pull/649#discussion_r488065099 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -52,6 +52,8 @@ class SNITest : public ::testing::Test { ~SNITest() override = default;

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-14 Thread GitBox
moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r488063324 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -35,9 +35,9 @@ using apache::geode::client::internal::geode_hash; const int

[GitHub] [geode-native] moleske commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-14 Thread GitBox
moleske commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-692164352 @echobravopapa as mentioned in the initial blurb up top, I do not have easy access to a useful windows machine to debug, but the PR was generally working. In that blurb, I

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-14 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488052139 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-14 Thread GitBox
gesterzhou commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r488039326 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] sabbeyPivotal commented on pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

2020-09-14 Thread GitBox
sabbeyPivotal commented on pull request #5508: URL: https://github.com/apache/geode/pull/5508#issuecomment-692050033 Distributed test failure is unrelated to this PR. This is an automated message from the Apache Git Service.

[GitHub] [geode] albertogpz commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-13 Thread GitBox
albertogpz commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r487645771 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] albertogpz opened a new pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-13 Thread GitBox
albertogpz opened a new pull request #5509: URL: https://github.com/apache/geode/pull/5509 …nder when possible Instead of storing dropped events in tmpDroppedEvents to later send batch removal messages when the primary gateway sender is not started, try to send the batch

[GitHub] [geode] gesterzhou commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-13 Thread GitBox
gesterzhou commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r487486048 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode] agingade commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
agingade commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487130937 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode] agingade commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-09-12 Thread GitBox
agingade commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r487137679 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean

[GitHub] [geode-native] alb3rtobr commented on pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-12 Thread GitBox
alb3rtobr commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-690971310 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [geode] albertogpz commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-12 Thread GitBox
albertogpz commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r486970379 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-12 Thread GitBox
echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r487163729 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

[GitHub] [geode] jchen21 merged pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
jchen21 merged pull request #5503: URL: https://github.com/apache/geode/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] jchen21 commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
jchen21 commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487218213 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode] agingade commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
agingade commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487130937 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode] albertogpz commented on a change in pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-09-12 Thread GitBox
albertogpz commented on a change in pull request #5486: URL: https://github.com/apache/geode/pull/5486#discussion_r486970379 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,24 @@ public void

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-12 Thread GitBox
echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r487163729 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

[GitHub] [geode] jchen21 merged pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
jchen21 merged pull request #5503: URL: https://github.com/apache/geode/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jchen21 commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
jchen21 commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487218213 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode-native] alb3rtobr commented on pull request #648: GEODE-8480: Add txmanager check in tx example

2020-09-12 Thread GitBox
alb3rtobr commented on pull request #648: URL: https://github.com/apache/geode-native/pull/648#issuecomment-690971310 I was running a test consisting on killing a Geode server while a C++ client with several threads was executing transactions. I observed that most of the times, the client

[GitHub] [geode] agingade commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-12 Thread GitBox
agingade commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487130937 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode] agingade commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-09-12 Thread GitBox
agingade commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r487137679 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean

[GitHub] [geode] jchen21 merged pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-11 Thread GitBox
jchen21 merged pull request #5503: URL: https://github.com/apache/geode/pull/5503 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] sabbeyPivotal opened a new pull request #5508: GEODE-8490: Docker containers are not properly cleaned up after native Redis acceptance tests

2020-09-11 Thread GitBox
sabbeyPivotal opened a new pull request #5508: URL: https://github.com/apache/geode/pull/5508 - Created a test rule (NativeRedisTestRule) to properly close and clean up all Docker containers created by the native Redis acceptance tests

[GitHub] [geode] jchen21 commented on a change in pull request #5503: GEODE-8482: Concurrent access to ArrayList should be synchronized

2020-09-11 Thread GitBox
jchen21 commented on a change in pull request #5503: URL: https://github.com/apache/geode/pull/5503#discussion_r487218213 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/control/InternalResourceManager.java ## @@ -637,7 +638,9 @@ private

[GitHub] [geode-native] echobravopapa commented on a change in pull request #650: GEODE-8129: Added a drop proxy test.

2020-09-11 Thread GitBox
echobravopapa commented on a change in pull request #650: URL: https://github.com/apache/geode-native/pull/650#discussion_r487163729 ## File path: cppcache/acceptance-test/SNITest.cpp ## @@ -174,4 +174,51 @@ TEST_F(SNITest, connectWithoutProxyFails) { cache.close(); }

  1   2   3   4   5   6   7   8   9   10   >