[GitHub] [geode] demery-pivotal opened a new pull request, #7807: spike/traverser

2022-06-16 Thread GitBox
demery-pivotal opened a new pull request, #7807: URL: https://github.com/apache/geode/pull/7807 - More ObjectTraverser tests - ObjectTraverser caches FieldExtractors - Create field extractors lazily -- This is an automated message from the Apache Git Service. To respond to the me

[GitHub] [geode] rhoughton-pivot merged pull request #7797: GEODE-10378: Change PRs to default to JDK11 only

2022-06-16 Thread GitBox
rhoughton-pivot merged PR #7797: URL: https://github.com/apache/geode/pull/7797 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr..

[GitHub] [geode-native] pdxcodemonkey merged pull request #975: GEODE-10382: Fix Windows build in CI pipeline

2022-06-16 Thread GitBox
pdxcodemonkey merged PR #975: URL: https://github.com/apache/geode-native/pull/975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubsc

[GitHub] [geode] upthewaterspout commented on pull request #7806: GEODE-10388: create better output filter for srcDist task

2022-06-16 Thread GitBox
upthewaterspout commented on PR #7806: URL: https://github.com/apache/geode/pull/7806#issuecomment-1157945426 Oh, wait, I see. You are trying to exclude the whole directory, but only if it is a directory and not a file. Ok. -- This is an automated message from the Apache Git Service. To r

[GitHub] [geode] rhoughton-pivot opened a new pull request, #7806: GEODE-10388: create better output filter for srcDist task

2022-06-16 Thread GitBox
rhoughton-pivot opened a new pull request, #7806: URL: https://github.com/apache/geode/pull/7806 Replace the brittle exclude list for `build` and `out` directories with a closure containing comparison logic for file-type and name. Makes sure that regular files named `out` are still arch

[GitHub] [geode] albertogpz closed pull request #7784: [DRAFT DO NOT REVIEW] Wip/handshake locks

2022-06-16 Thread GitBox
albertogpz closed pull request #7784: [DRAFT DO NOT REVIEW] Wip/handshake locks URL: https://github.com/apache/geode/pull/7784 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [geode] jchen21 merged pull request #7804: GEODE-10384: Add stack trace to logging

2022-06-15 Thread GitBox
jchen21 merged PR #7804: URL: https://github.com/apache/geode/pull/7804 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.

[GitHub] [geode] jchen21 opened a new pull request, #7804: Add stack trace to logging

2022-06-15 Thread GitBox
jchen21 opened a new pull request, #7804: URL: https://github.com/apache/geode/pull/7804 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit withi

[GitHub] [geode] davebarnes97 merged pull request #7802: (no JIRA ticket) user guide Security section: Typo & format fixes

2022-06-15 Thread GitBox
davebarnes97 merged PR #7802: URL: https://github.com/apache/geode/pull/7802 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] pivotal-jbarrett opened a new pull request, #7803: GEODE-10354: Convert enum like classes to enum.

2022-06-15 Thread GitBox
pivotal-jbarrett opened a new pull request, #7803: URL: https://github.com/apache/geode/pull/7803 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest com

[GitHub] [geode-native] pdxcodemonkey opened a new pull request, #975: GEODE-10382: Fix Windows build in CI pipeline

2022-06-15 Thread GitBox
pdxcodemonkey opened a new pull request, #975: URL: https://github.com/apache/geode-native/pull/975 Add echo command to cmake configuration step, for debugging -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [geode] jinmeiliao merged pull request #7801: GEODE-10380: use waitingThreadPool to notify dispatcher at re_auth

2022-06-15 Thread GitBox
jinmeiliao merged PR #7801: URL: https://github.com/apache/geode/pull/7801 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] jinmeiliao commented on pull request #7801: GEODE-10380: use waitingThreadPool to notify dispatcher at re_auth

2022-06-15 Thread GitBox
jinmeiliao commented on PR #7801: URL: https://github.com/apache/geode/pull/7801#issuecomment-1156700605 Thanks! I will merge this after more thorough tests are done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] mivanac commented on pull request #7749: GEODE-10020: For Ping task avoid registering new destination endpoint

2022-06-15 Thread GitBox
mivanac commented on PR #7749: URL: https://github.com/apache/geode/pull/7749#issuecomment-1156604322 Hi just a reminder, could you review this PR. This was reverted PR with modifications for failing internal test. Thanks -- This is an automated message from the Apache Git Serv

[GitHub] [geode] mivanac commented on pull request #7664: Newfeature2/geode 9484

2022-06-15 Thread GitBox
mivanac commented on PR #7664: URL: https://github.com/apache/geode/pull/7664#issuecomment-1156600848 Hi @Bill, @echobravopapa, @agingade, @kamilla1201 and @pivotal-jbarrett just a reminder, could you review this PR. This was reverted PR with modifications for failing internal test.

[GitHub] [geode] mivanac commented on a diff in pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage

2022-06-15 Thread GitBox
mivanac commented on code in PR #7323: URL: https://github.com/apache/geode/pull/7323#discussion_r898081743 ## geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java: ## @@ -215,6 +216,34 @@ enum OrderPolicy { */ void startWithCleanQueue(); + + /** +

[GitHub] [geode] jvarenina commented on pull request #7725: GEODE-10338: Fix LogWriterAppender shutdown

2022-06-15 Thread GitBox
jvarenina commented on PR #7725: URL: https://github.com/apache/geode/pull/7725#issuecomment-1156398017 When created in the same VM, all cache instances use the same LogWriterAppender service. Therefore all tests that create multiple caches and try to close them will fail with `NullpointerE

[GitHub] [geode] pivotal-jbarrett merged pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-14 Thread GitBox
pivotal-jbarrett merged PR #7688: URL: https://github.com/apache/geode/pull/7688 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] DonalEvans merged pull request #7631: GEODE-10261: VMProvider.invokeAsync uses appropriate parameterization.

2022-06-14 Thread GitBox
DonalEvans merged PR #7631: URL: https://github.com/apache/geode/pull/7631 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] davebarnes97 opened a new pull request, #7802: (no JIRA ticket) user guide Security section: Typo & format fixes

2022-06-14 Thread GitBox
davebarnes97 opened a new pull request, #7802: URL: https://github.com/apache/geode/pull/7802 Doc format fixes. Back port to 1.15 ASAP. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [geode] pivotal-jbarrett commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout

2022-06-14 Thread GitBox
pivotal-jbarrett commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1155476232 It is common in console programming to output "verbose" output to stderr and "normal" output to stdout. Verbose output being log like stuff and normal output being results of the e

[GitHub] [geode] albertogpz commented on a diff in pull request #7747: GEODE-10334: Send alert when thread stuck for long

2022-06-14 Thread GitBox
albertogpz commented on code in PR #7747: URL: https://github.com/apache/geode/pull/7747#discussion_r896655954 ## geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/AbstractExecutor.java: ## @@ -51,9 +56,25 @@ protected AbstractExecutor(String groupName, long

[GitHub] [geode] mkevo commented on pull request #7368: GEODE-10055: fix AbstractLauncher to print info and debug with stdout

2022-06-14 Thread GitBox
mkevo commented on PR #7368: URL: https://github.com/apache/geode/pull/7368#issuecomment-1154808661 > I am quite certain this is intentional. Perhaps it is worth a conversation on dev@geode to see if we want to change this. Hi @pivotal-jbarrett, why do you think that this is intention

[GitHub] [geode] onichols-pivotal merged pull request #7770: GEODE-10355: Bump spring-security from 5.2.12 to 5.5.8

2022-06-13 Thread GitBox
onichols-pivotal merged PR #7770: URL: https://github.com/apache/geode/pull/7770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] onichols-pivotal merged pull request #7769: GEODE-10355: Bump spring-security from 5.4.8 to 5.6.5

2022-06-13 Thread GitBox
onichols-pivotal merged PR #7769: URL: https://github.com/apache/geode/pull/7769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] smgoller opened a new pull request, #7800: [GEODE-10369] if scratch ssd is used, fall back to n1 machine type.

2022-06-13 Thread GitBox
smgoller opened a new pull request, #7800: URL: https://github.com/apache/geode/pull/7800 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit with

[GitHub] [geode] pivotal-jbarrett commented on pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-13 Thread GitBox
pivotal-jbarrett commented on PR #7211: URL: https://github.com/apache/geode/pull/7211#issuecomment-1154370976 @upthewaterspout, this brings up an excellent question. Does the use of the `Serializable` interface outside of the direct API, which does not utilize it, constitute part of the bi

[GitHub] [geode] smgoller merged pull request #7798: GEODE-10369 part 2 Fix hardcoded gcp project reference and adjust windows unit test cpu/ram usage.

2022-06-13 Thread GitBox
smgoller merged PR #7798: URL: https://github.com/apache/geode/pull/7798 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode

[GitHub] [geode] smgoller opened a new pull request, #7798: GEODE-10369 part 2 Fix hardcoded gcp project reference and adjust windows unit test cpu/ram usage.

2022-06-13 Thread GitBox
smgoller opened a new pull request, #7798: URL: https://github.com/apache/geode/pull/7798 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit with

[GitHub] [geode] onichols-pivotal commented on a diff in pull request #7759: Fixes for cleaning GCP resources from pipelines

2022-06-13 Thread GitBox
onichols-pivotal commented on code in PR #7759: URL: https://github.com/apache/geode/pull/7759#discussion_r895956599 ## ci/pipelines/clean_fork_pipelines.sh: ## @@ -22,10 +25,11 @@ while [ -h "$SOURCE" ]; do # resolve $SOURCE until the file is no longer a symli done SCRIPTDIR

[GitHub] [geode] albertogpz commented on a diff in pull request #7747: GEODE-10334: Send alert when thread stuck for long

2022-06-13 Thread GitBox
albertogpz commented on code in PR #7747: URL: https://github.com/apache/geode/pull/7747#discussion_r89587 ## geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/AbstractExecutor.java: ## @@ -51,9 +56,25 @@ protected AbstractExecutor(String groupName, long

[GitHub] [geode] mkevo merged pull request #7643: GEODE-10267: fix creating gw sender with non-existent disk store

2022-06-13 Thread GitBox
mkevo merged PR #7643: URL: https://github.com/apache/geode/pull/7643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.ap

[GitHub] [geode] smgoller merged pull request #7796: GEODE-10369: Calculate heavy lifter costs.

2022-06-10 Thread GitBox
smgoller merged PR #7796: URL: https://github.com/apache/geode/pull/7796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode

[GitHub] [geode] rhoughton-pivot opened a new pull request, #7797: GEODE-10378: Change PRs to default to JDK11 only

2022-06-10 Thread GitBox
rhoughton-pivot opened a new pull request, #7797: URL: https://github.com/apache/geode/pull/7797 Other JDK will be by request (label) only. Authored-by: Robert Houghton -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[GitHub] [geode] smgoller commented on pull request #7796: Geode 10369 - Calculate heavy lifter costs.

2022-06-10 Thread GitBox
smgoller commented on PR #7796: URL: https://github.com/apache/geode/pull/7796#issuecomment-1152775565 > YOU FORGOT TO SQUASH NOM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[GitHub] [geode] rhoughton-pivot commented on pull request #7796: Geode 10369 - Calculate heavy lifter costs.

2022-06-10 Thread GitBox
rhoughton-pivot commented on PR #7796: URL: https://github.com/apache/geode/pull/7796#issuecomment-1152774931 YOU FORGOT TO SQUASH -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific com

[GitHub] [geode] smgoller closed pull request #7796: Geode 10369 - Calculate heavy lifter costs.

2022-06-10 Thread GitBox
smgoller closed pull request #7796: Geode 10369 - Calculate heavy lifter costs. URL: https://github.com/apache/geode/pull/7796 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [geode] smgoller opened a new pull request, #7796: Geode 10369 - Calculate heavy lifter costs.

2022-06-10 Thread GitBox
smgoller opened a new pull request, #7796: URL: https://github.com/apache/geode/pull/7796 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit with

[GitHub] [geode] agingade commented on a diff in pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-10 Thread GitBox
agingade commented on code in PR #7211: URL: https://github.com/apache/geode/pull/7211#discussion_r894884242 ## geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java: ## @@ -328,14 +325,14 @@ void shouldSetPossibleDuplicateReturnsTrueIfNot

[GitHub] [geode] kirklund commented on a diff in pull request #7747: GEODE-10334: Send alert when thread stuck for long

2022-06-10 Thread GitBox
kirklund commented on code in PR #7747: URL: https://github.com/apache/geode/pull/7747#discussion_r894864266 ## geode-core/src/main/java/org/apache/geode/internal/monitoring/executor/AbstractExecutor.java: ## @@ -51,9 +56,25 @@ protected AbstractExecutor(String groupName, long t

[GitHub] [geode] jinmeiliao opened a new pull request, #7795: GEODE-10375: improve test to catch doc link update

2022-06-10 Thread GitBox
jinmeiliao opened a new pull request, #7795: URL: https://github.com/apache/geode/pull/7795 improve test in case the doc link gets updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [geode] onichols-pivotal merged pull request #7794: GEODE-10375: update supported api docs link

2022-06-10 Thread GitBox
onichols-pivotal merged PR #7794: URL: https://github.com/apache/geode/pull/7794 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] nabarunnag merged pull request #7779: GEODE-6504: Instant class used.

2022-06-10 Thread GitBox
nabarunnag merged PR #7779: URL: https://github.com/apache/geode/pull/7779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-10 Thread GitBox
pivotal-jbarrett commented on code in PR #7211: URL: https://github.com/apache/geode/pull/7211#discussion_r894777348 ## geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java: ## @@ -328,14 +325,14 @@ void shouldSetPossibleDuplicateReturnsT

[GitHub] [geode] upthewaterspout commented on pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-10 Thread GitBox
upthewaterspout commented on PR #7211: URL: https://github.com/apache/geode/pull/7211#issuecomment-1152604125 @pivotal-jbarrett - Here's a test you can play with, based on this PR - https://github.com/upthewaterspout/geode/pull/new/feature/test-compatibility-of-enum-DataPolicy -- This is

[GitHub] [geode] pivotal-jbarrett commented on pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-10 Thread GitBox
pivotal-jbarrett commented on PR #7211: URL: https://github.com/apache/geode/pull/7211#issuecomment-1152603251 > I did a quick test, and it looks like this is a breaking change to the serialization format of this class. I think that's why we haven't made this conversion up to this point:

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-10 Thread GitBox
pivotal-jbarrett commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r894771540 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java: ## @@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out)

[GitHub] [geode] jinmeiliao opened a new pull request, #7794: GEODE-10375: update supported api docs link

2022-06-10 Thread GitBox
jinmeiliao opened a new pull request, #7794: URL: https://github.com/apache/geode/pull/7794 update to springdoc link after [GEODE-10312](https://issues.apache.org/jira/browse/GEODE-10312) -- This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geode] dschneider-pivotal opened a new pull request, #7793: removed add-opens for jdk.internal.ref to see what breaks

2022-06-10 Thread GitBox
dschneider-pivotal opened a new pull request, #7793: URL: https://github.com/apache/geode/pull/7793 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest c

[GitHub] [geode] gesterzhou commented on a diff in pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-10 Thread GitBox
gesterzhou commented on code in PR #7211: URL: https://github.com/apache/geode/pull/7211#discussion_r894707167 ## geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java: ## @@ -328,14 +325,14 @@ void shouldSetPossibleDuplicateReturnsTrueIfN

[GitHub] [geode] DonalEvans merged pull request #7721: GEODE-10329: Handle RejectedExecutionException

2022-06-10 Thread GitBox
DonalEvans merged PR #7721: URL: https://github.com/apache/geode/pull/7721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7721: GEODE-10329: Handle RejectedExecutionException

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7721: URL: https://github.com/apache/geode/pull/7721#discussion_r894035661 ## geode-membership/src/test/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitorTest.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the A

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7721: GEODE-10329: Handle RejectedExecutionException

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7721: URL: https://github.com/apache/geode/pull/7721#discussion_r894035523 ## geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java: ## @@ -1425,6 +1425,16 @@ private void sendSuspec

[GitHub] [geode] DonalEvans commented on pull request #7721: GEODE-10329: Handle RejectedExecutionException

2022-06-09 Thread GitBox
DonalEvans commented on PR #7721: URL: https://github.com/apache/geode/pull/7721#issuecomment-1151676410 @pivotal-jbarrett Thanks for the advice! I think I managed to implement what you suggested; please let me know if it needs further tweaks. -- This is an automated message from the Apac

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r893938054 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java: ## @@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out)

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r893928279 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java: ## @@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out)

[GitHub] [geode] kirklund opened a new pull request, #7791: GEODE-10366: Cleanup GfshRule created Folder

2022-06-09 Thread GitBox
kirklund opened a new pull request, #7791: URL: https://github.com/apache/geode/pull/7791 PROBLEM Tests using GfshRule default constructor do not delete the contents of the internal Folder created by GfshRule when all tests passed. This results in unnecessary size bloating of th

[GitHub] [geode] agingade commented on a diff in pull request #7211: GEODE-10354: Convert enum like classes to enum.

2022-06-09 Thread GitBox
agingade commented on code in PR #7211: URL: https://github.com/apache/geode/pull/7211#discussion_r893861404 ## geode-core/src/test/java/org/apache/geode/internal/cache/tier/sockets/command/Put70Test.java: ## @@ -328,14 +325,14 @@ void shouldSetPossibleDuplicateReturnsTrueIfNot

[GitHub] [geode] mivanac commented on a diff in pull request #7323: GEODE-9997: added ParallelQueueSetPossibleDuplicateMessage

2022-06-09 Thread GitBox
mivanac commented on code in PR #7323: URL: https://github.com/apache/geode/pull/7323#discussion_r893840797 ## geode-core/src/main/java/org/apache/geode/cache/wan/GatewaySender.java: ## @@ -215,6 +216,34 @@ enum OrderPolicy { */ void startWithCleanQueue(); + + /** +

[GitHub] [geode] pivotal-jbarrett commented on pull request #7721: GEODE-10329: Handle RejectedExecutionException

2022-06-09 Thread GitBox
pivotal-jbarrett commented on PR #7721: URL: https://github.com/apache/geode/pull/7721#issuecomment-1151458738 @DonalEvans what if we refactored a little to a method that takes function to execute and optionally ignores this specific exception, then we could at least deterministically test

[GitHub] [geode] jinmeiliao merged pull request #7777: GEODE-6489: fix a flaky test

2022-06-09 Thread GitBox
jinmeiliao merged PR #: URL: https://github.com/apache/geode/pull/ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] nabarunnag commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-09 Thread GitBox
nabarunnag commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r893815867 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java: ## @@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out) throw

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893817487 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -84,15 +85,16 @@ public void increaseRegionTtl() throws

[GitHub] [geode] nabarunnag commented on a diff in pull request #7688: GEODE-10326: Convert MessageType to enum.

2022-06-09 Thread GitBox
nabarunnag commented on code in PR #7688: URL: https://github.com/apache/geode/pull/7688#discussion_r893815867 ## geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/ClientUpdateMessageImpl.java: ## @@ -1011,7 +1015,7 @@ public void sendTo(DataOutput out) throw

[GitHub] [geode] jinmeiliao merged pull request #7760: GEODE-10351: Wait till the cache is completely closed before re-creating

2022-06-09 Thread GitBox
jinmeiliao merged PR #7760: URL: https://github.com/apache/geode/pull/7760 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] nabarunnag commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-09 Thread GitBox
nabarunnag commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893746594 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test - publ

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-09 Thread GitBox
pivotal-jbarrett commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893607561 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test -

[GitHub] [geode] mkevo merged pull request #7629: GEODE-7875: fix create index gfsh command on partitioned region

2022-06-09 Thread GitBox
mkevo merged PR #7629: URL: https://github.com/apache/geode/pull/7629 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.ap

[GitHub] [geode] nabarunnag merged pull request #7787: Revert "GEODE-9632: Allow INDEX_THRESHOLD_SIZE System property to ove…

2022-06-08 Thread GitBox
nabarunnag merged PR #7787: URL: https://github.com/apache/geode/pull/7787 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] nabarunnag commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-08 Thread GitBox
nabarunnag commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893014322 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test - publ

[GitHub] [geode] nabarunnag commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-08 Thread GitBox
nabarunnag commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893017368 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test - publ

[GitHub] [geode] nabarunnag commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-08 Thread GitBox
nabarunnag commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893014322 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test - publ

[GitHub] [geode] nabarunnag commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-08 Thread GitBox
nabarunnag commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r893011483 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test - publ

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7779: GEODE-6504: Instant class used.

2022-06-08 Thread GitBox
pivotal-jbarrett commented on code in PR #7779: URL: https://github.com/apache/geode/pull/7779#discussion_r892974555 ## geode-core/src/integrationTest/java/org/apache/geode/cache/RegionExpirationIntegrationTest.java: ## @@ -70,10 +71,10 @@ public void setUp() { } @Test -

[GitHub] [geode] nabarunnag commented on pull request #7787: Revert "GEODE-9632: Allow INDEX_THRESHOLD_SIZE System property to ove…

2022-06-08 Thread GitBox
nabarunnag commented on PR #7787: URL: https://github.com/apache/geode/pull/7787#issuecomment-1150466453 @mkevo as mentioned in the dev mail, we are planning to put the commit in develop again after fixing the problem that was brought up by you in dev list. We are planning to release 1.1

[GitHub] [geode] demery-pivotal merged pull request #7772: GEODE-10321: Acceptance test for Geode access to JDK internals

2022-06-08 Thread GitBox
demery-pivotal merged PR #7772: URL: https://github.com/apache/geode/pull/7772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...

[GitHub] [geode] davebarnes97 merged pull request #7789: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
davebarnes97 merged PR #7789: URL: https://github.com/apache/geode/pull/7789 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] davebarnes97 merged pull request #7790: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
davebarnes97 merged PR #7790: URL: https://github.com/apache/geode/pull/7790 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] davebarnes97 merged pull request #7788: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
davebarnes97 merged PR #7788: URL: https://github.com/apache/geode/pull/7788 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] animatedmax opened a new pull request, #7790: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
animatedmax opened a new pull request, #7790: URL: https://github.com/apache/geode/pull/7790 Port of PR #7778 to support/1.12 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [geode] animatedmax opened a new pull request, #7789: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
animatedmax opened a new pull request, #7789: URL: https://github.com/apache/geode/pull/7789 Port of PR #7778 to support/1.14 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [geode] animatedmax opened a new pull request, #7788: GEODE-10342: Simplify copying jars

2022-06-08 Thread GitBox
animatedmax opened a new pull request, #7788: URL: https://github.com/apache/geode/pull/7788 Port of PR #7778 to support/1.15 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [geode] nabarunnag opened a new pull request, #7787: Revert "GEODE-9632: Allow INDEX_THRESHOLD_SIZE System property to ove…

2022-06-08 Thread GitBox
nabarunnag opened a new pull request, #7787: URL: https://github.com/apache/geode/pull/7787 …rride CompiledValue.RESULT_LIMIT (#7010)" This reverts commit 67359dcd ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in

[GitHub] [geode] nabarunnag opened a new pull request, #7786: GEODE-10370: More info added to javadocs

2022-06-08 Thread GitBox
nabarunnag opened a new pull request, #7786: URL: https://github.com/apache/geode/pull/7786 * Added what is returned by methods showJVMMetrics and showOSMetrics * Informtation include individual beans and what data type it is. ### For all changes: - [ ] Is there a

[GitHub] [geode] demery-pivotal commented on a diff in pull request #7772: GEODE-10321: Acceptance test for Geode access to JDK internals

2022-06-08 Thread GitBox
demery-pivotal commented on code in PR #7772: URL: https://github.com/apache/geode/pull/7772#discussion_r892721359 ## geode-assembly/src/acceptanceTest/java/org/apache/geode/jdk/JdkEncapsulationTest.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apache Software Foundation (A

[GitHub] [geode] Bill opened a new pull request, #7785: [DRAFT] delay sync after member departure by 60s in P2P-only config

2022-06-08 Thread GitBox
Bill opened a new pull request, #7785: URL: https://github.com/apache/geode/pull/7785 In a cluster configured for P2P-only (no clients possible—no CacheServer instance present), if a primary bucket holder crashes while servicing a partitioned.PutMessage (in this instance, the result of a Re

[GitHub] [geode] albertogpz merged pull request #7424: GEODE-10068: Make WanCopyRegionFunctionService thread pool configurab…

2022-06-08 Thread GitBox
albertogpz merged PR #7424: URL: https://github.com/apache/geode/pull/7424 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geo

[GitHub] [geode] albertogpz opened a new pull request, #7784: [DRAFT DO NOT REVIEW] Wip/handshake locks

2022-06-08 Thread GitBox
albertogpz opened a new pull request, #7784: URL: https://github.com/apache/geode/pull/7784 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit wi

[GitHub] [geode] mkevo commented on pull request #7643: GEODE-10267: fix creating gw sender with non-existent disk store

2022-06-08 Thread GitBox
mkevo commented on PR #7643: URL: https://github.com/apache/geode/pull/7643#issuecomment-1149637793 Hi @gesterzhou, @boglesby, @nabarunnag, @pivotal-jbarrett, can you please add your review on this? -- This is an automated message from the Apache Git Service. To respond to the message, pl

[GitHub] [geode] onichols-pivotal merged pull request #7783: GEODE-10089: update LICENSE

2022-06-07 Thread GitBox
onichols-pivotal merged PR #7783: URL: https://github.com/apache/geode/pull/7783 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr.

[GitHub] [geode] onichols-pivotal opened a new pull request, #7783: GEODE-10089: update LICENSE

2022-06-07 Thread GitBox
onichols-pivotal opened a new pull request, #7783: URL: https://github.com/apache/geode/pull/7783 we have some dependency changes due to recent redis removal, change to springdoc and inclusion of joda-time -- This is an automated message from the Apache Git Service. To respond to the mess

[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7665: GEODE-10281: Fix WAN data inconsistency

2022-06-07 Thread GitBox
pivotal-jbarrett commented on code in PR #7665: URL: https://github.com/apache/geode/pull/7665#discussion_r891801945 ## geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/serial/TestCacheWriterDelayWritingOfEntry.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to

[GitHub] [geode] davebarnes97 merged pull request #7782: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
davebarnes97 merged PR #7782: URL: https://github.com/apache/geode/pull/7782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] davebarnes97 merged pull request #7781: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
davebarnes97 merged PR #7781: URL: https://github.com/apache/geode/pull/7781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] davebarnes97 merged pull request #7780: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
davebarnes97 merged PR #7780: URL: https://github.com/apache/geode/pull/7780 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] davebarnes97 merged pull request #7778: GEODE-10342: Simplify copying jars

2022-06-07 Thread GitBox
davebarnes97 merged PR #7778: URL: https://github.com/apache/geode/pull/7778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [geode] animatedmax opened a new pull request, #7782: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
animatedmax opened a new pull request, #7782: URL: https://github.com/apache/geode/pull/7782 Port of PR #7775 to support/1.12 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [geode] animatedmax opened a new pull request, #7781: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
animatedmax opened a new pull request, #7781: URL: https://github.com/apache/geode/pull/7781 Port of PR #7775 to support/1.14 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [geode] animatedmax opened a new pull request, #7780: GEODE-10365: add missing components to table

2022-06-07 Thread GitBox
animatedmax opened a new pull request, #7780: URL: https://github.com/apache/geode/pull/7780 Port of PR #7775 to support/1.15 branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specif

[GitHub] [geode] nabarunnag opened a new pull request, #7779: GEODE-6504: Instant class used.

2022-06-07 Thread GitBox
nabarunnag opened a new pull request, #7779: URL: https://github.com/apache/geode/pull/7779 * Using instant class instead of nanos. * Nanos is not updated that often hence not proper resolution. * Using millis instead of seconds to avoid ceiling issues. ### For al

<    1   2   3   4   5   6   7   8   9   10   >