[GitHub] [geode] mhansonp commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-24 Thread GitBox
mhansonp commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r494472324 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-24 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r494449040 ## File path: geode-core/src/test/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitorTest.java ## @@ -33,16 +45,94 @@ @Before

[GitHub] [geode-native] pdxcodemonkey merged pull request #655: GEODE-8524: Add support for KEY_SET and GET_ALL_70 messages

2020-09-24 Thread GitBox
pdxcodemonkey merged pull request #655: URL: https://github.com/apache/geode-native/pull/655 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] kohlmu-pivotal opened a new pull request #5548: GEODE-8466: Introduction of ClassLoaderService as replacement

2020-09-23 Thread GitBox
kohlmu-pivotal opened a new pull request #5548: URL: https://github.com/apache/geode/pull/5548 for the direct feature usage of ClassLoader and ClassLoaderPath Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask

[GitHub] [geode] sabbeyPivotal commented on pull request #5544: GEODE-8515: Redis PING should respond appropriately when called from within a SUBSCRIBE/PSUBSCRIBE

2020-09-23 Thread GitBox
sabbeyPivotal commented on pull request #5544: URL: https://github.com/apache/geode/pull/5544#issuecomment-698047025 Distributed test failure is unrelated to this PR. This is an automated message from the Apache Git Service.

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493961781 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
pivotal-jbarrett commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697999232 > I think we can diagnose the test problem with a couple of (very tedious) hours of debugging, which is a lot better than rewriting the test. I think we're much

[GitHub] [geode] onichols-pivotal commented on pull request #5543: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal commented on pull request #5543: URL: https://github.com/apache/geode/pull/5543#issuecomment-697997186 Fixed by #5547 thanks! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] onichols-pivotal closed pull request #5543: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal closed pull request #5543: URL: https://github.com/apache/geode/pull/5543 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal merged pull request #5547: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
onichols-pivotal merged pull request #5547: URL: https://github.com/apache/geode/pull/5547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal merged pull request #5540: Bump mockito from 3.3.3 to 3.5.11

2020-09-23 Thread GitBox
onichols-pivotal merged pull request #5540: URL: https://github.com/apache/geode/pull/5540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493896136 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493896436 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493890530 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #655: GEODE-8524: Add support for KEY_SET and GET_ALL_70 messages

2020-09-23 Thread GitBox
pdxcodemonkey opened a new pull request #655: URL: https://github.com/apache/geode-native/pull/655 Found a log file this morning from an app that was calling `getKeys()` and `getAll()`, and discovered these message that hadn't yet been added to the parser. @alb3rtobr @mreddington

[GitHub] [geode] jchen21 commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493858900 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424 @@

[GitHub] [geode] jchen21 commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493858361 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424 @@

[GitHub] [geode] jchen21 commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jchen21 commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493856692 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493853151 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493844666 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493822296 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493821071 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] jinmeiliao opened a new pull request #5547: GEODE-8496: fix rest management test after dependency bump

2020-09-23 Thread GitBox
jinmeiliao opened a new pull request #5547: URL: https://github.com/apache/geode/pull/5547 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode-native] pdxcodemonkey commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
pdxcodemonkey commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697875154 I think we can diagnose the test problem with a couple of (very tedious) hours of debugging, which is a lot better than rewriting the test. I think we're much closer

[GitHub] [geode] nabarunnag merged pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
nabarunnag merged pull request #5546: URL: https://github.com/apache/geode/pull/5546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jhuynh1 commented on pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
jhuynh1 commented on pull request #5546: URL: https://github.com/apache/geode/pull/5546#issuecomment-697809643 This might have to be backported to previous releases based on when these jars were introduced... This is an

[GitHub] [geode] nabarunnag opened a new pull request #5546: GEODE-8523: Session state document update

2020-09-23 Thread GitBox
nabarunnag opened a new pull request #5546: URL: https://github.com/apache/geode/pull/5546 * geode-tcp and geode-membership added to the list * removed geode-json as it does not exist anymore. This is an

[GitHub] [geode] demery-pivotal commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
demery-pivotal commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493761722 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode-native] moleske commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-23 Thread GitBox
moleske commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697695288 @pdxcodemonkey do you think it will be easier to rewrite those tests in the new framework rather than find and fix the problem? It may take more time but long term be more

[GitHub] [geode] upthewaterspout opened a new pull request #5545: GEODE-8522: Switching a exception log back to debug

2020-09-23 Thread GitBox
upthewaterspout opened a new pull request #5545: URL: https://github.com/apache/geode/pull/5545 This log message happens during the course of normal startup of multiple locators. We should not be logging a full stack trace during normal startup. Thank you for submitting a

[GitHub] [geode] sabbeyPivotal opened a new pull request #5544: GEODE-8515: Redis PING should respond appropriately when called from within a SUBSCRIBE/PSUBSCRIBE

2020-09-23 Thread GitBox
sabbeyPivotal opened a new pull request #5544: URL: https://github.com/apache/geode/pull/5544 From PING documentation (https://redis.io/commands/ping): If the client is subscribed to a channel or a pattern, it will instead return a multi-bulk with a "pong" in the first position and

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493738369 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493739655 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/stats/GCStatsMonitor.java ## @@ -39,69 +39,71 @@ * @see

[GitHub] [geode] sabbeyPivotal commented on pull request #5538: Bump junit from 4.12 to 4.13

2020-09-23 Thread GitBox
sabbeyPivotal commented on pull request #5538: URL: https://github.com/apache/geode/pull/5538#issuecomment-697674111 I'll take a look at this one! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] kirklund commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-23 Thread GitBox
kirklund commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493738369 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] dschneider-pivotal merged pull request #5535: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-23 Thread GitBox
dschneider-pivotal merged pull request #5535: URL: https://github.com/apache/geode/pull/5535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey commented on pull request #654: GEODE-8514: python protocol tool

2020-09-23 Thread GitBox
pdxcodemonkey commented on pull request #654: URL: https://github.com/apache/geode-native/pull/654#issuecomment-697629814 > @pdxcodemonkey thanks for contributing this! It's also a good excuse to refresh my Python knowledge thanks, @alb3rtobr, hope you find it helpful. Just FYI, I

[GitHub] [geode-native] alb3rtobr commented on pull request #654: GEODE-8514: python protocol tool

2020-09-23 Thread GitBox
alb3rtobr commented on pull request #654: URL: https://github.com/apache/geode-native/pull/654#issuecomment-697558085 @pdxcodemonkey thanks for contributing this! It's also a good excuse to refresh my Python knowledge This

[GitHub] [geode] jinmeiliao commented on a change in pull request #5516: GEODE-7679 Partitioned Region clear is successful while region is being altered

2020-09-23 Thread GitBox
jinmeiliao commented on a change in pull request #5516: URL: https://github.com/apache/geode/pull/5516#discussion_r493631271 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java ## @@ -0,0 +1,424

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-22 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493153715 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] onichols-pivotal merged pull request #5542: GEODE-8469: fix windows test failure

2020-09-22 Thread GitBox
onichols-pivotal merged pull request #5542: URL: https://github.com/apache/geode/pull/5542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey merged pull request #654: GEODE-8514: python protocol tool

2020-09-22 Thread GitBox
pdxcodemonkey merged pull request #654: URL: https://github.com/apache/geode-native/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jhutchison commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-22 Thread GitBox
jhutchison commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492821512 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java ## @@ -183,8 +184,16 @@ public boolean

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-22 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492343203 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java ## @@ -183,8 +184,16 @@ public boolean

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5530: GEODE-8517: GatewaySenderEventImpl's 2 new attributes were introduced…

2020-09-22 Thread GitBox
pivotal-eshu commented on a change in pull request #5530: URL: https://github.com/apache/geode/pull/5530#discussion_r492888962 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java ## @@ -710,7 +710,7 @@ public int getDSFID() {

[GitHub] [geode] dschneider-pivotal merged pull request #5526: GEODE-8504: add info command

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5526: URL: https://github.com/apache/geode/pull/5526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] bschuchardt merged pull request #5531: Revert "GEODE-8463: server's log filled with SSLException: Tag mismatch! (#5482)"

2020-09-22 Thread GitBox
bschuchardt merged pull request #5531: URL: https://github.com/apache/geode/pull/5531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] pdxcodemonkey closed pull request #582: GEODE-7584: refactor pdx handling

2020-09-22 Thread GitBox
pdxcodemonkey closed pull request #582: URL: https://github.com/apache/geode-native/pull/582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5529: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5529: URL: https://github.com/apache/geode/pull/5529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] mhansonp commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-22 Thread GitBox
mhansonp commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493093231 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] onichols-pivotal merged pull request #5527: GEODE-8496: bump dependency versions

2020-09-22 Thread GitBox
onichols-pivotal merged pull request #5527: URL: https://github.com/apache/geode/pull/5527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5534: Revert "GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5534: URL: https://github.com/apache/geode/pull/5534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal merged pull request #5528: Redis StartUp tests use ephemeral port for Geode server

2020-09-22 Thread GitBox
jdeppe-pivotal merged pull request #5528: URL: https://github.com/apache/geode/pull/5528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] pdxcodemonkey commented on pull request #582: GEODE-7584: refactor pdx handling

2020-09-22 Thread GitBox
pdxcodemonkey commented on pull request #582: URL: https://github.com/apache/geode-native/pull/582#issuecomment-696896376 Closing this PR, since it's clear I'm not going to get around to addressing the changes requested any time soon, if at all. GEODE-7584 in Jira can remain active as a

[GitHub] [geode-native] pdxcodemonkey commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-22 Thread GitBox
pdxcodemonkey commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697028109 So the following 3 tests are now consistently failing on Windows: ``` The following tests FAILED: 14 - testRegionAccessThreadSafe (Timeout) 24 -

[GitHub] [geode] jinmeiliao commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-22 Thread GitBox
jinmeiliao commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493153715 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] onichols-pivotal opened a new pull request #5543: GEODE-8496: fix rest management test after dependency bump

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5543: URL: https://github.com/apache/geode/pull/5543 I've uncommented the test that started failing after 37 dependencies were bumped for GEODE-8496. It appears as if the test was relying on a quirk of an underlying library to generate the

[GitHub] [geode] onichols-pivotal merged pull request #5542: GEODE-8469: fix windows test failure

2020-09-22 Thread GitBox
onichols-pivotal merged pull request #5542: URL: https://github.com/apache/geode/pull/5542 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal opened a new pull request #5542: GEODE-8469: fix windows test failure

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5542: URL: https://github.com/apache/geode/pull/5542 newer dependency version uses platform-specific line separators, test did not This is an automated message from the Apache Git

[GitHub] [geode] onichols-pivotal opened a new pull request #5541: Bump tomcat6 from 6.0.37 to 6.0.53

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5541: URL: https://github.com/apache/geode/pull/5541 Adopt me! (otherwise I will be abandoned if no progress by Oct 16) This is an automated message from the Apache Git Service. To

[GitHub] [geode] onichols-pivotal opened a new pull request #5540: Bump mockito from 3.3.3 to 3.5.11

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5540: URL: https://github.com/apache/geode/pull/5540 Adopt me! (otherwise I will be abandoned if no progress by Oct 16) This is an automated message from the Apache Git Service. To

[GitHub] [geode] onichols-pivotal opened a new pull request #5539: Bump assertj from 3.15.0 to 3.17.2

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5539: URL: https://github.com/apache/geode/pull/5539 Adopt me! (otherwise I will be abandoned if no progress by Oct 16) This is an automated message from the Apache Git Service. To

[GitHub] [geode] mhansonp commented on a change in pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-22 Thread GitBox
mhansonp commented on a change in pull request #5536: URL: https://github.com/apache/geode/pull/5536#discussion_r493093231 ## File path: geode-core/src/test/java/org/apache/geode/management/bean/stats/MemberLevelStatsTest.java ## @@ -339,6 +342,41 @@ public void

[GitHub] [geode] onichols-pivotal opened a new pull request #5538: Bump junit from 4.12 to 4.13

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5538: URL: https://github.com/apache/geode/pull/5538 Adopt me! (otherwise I will be abandoned if no progress by Oct 16) This is an automated message from the Apache Git Service. To

[GitHub] [geode] onichols-pivotal opened a new pull request #5537: Bump archunit from 0.12.0 to 0.14.1

2020-09-22 Thread GitBox
onichols-pivotal opened a new pull request #5537: URL: https://github.com/apache/geode/pull/5537 Adopt me! (otherwise I will be abandoned if no progress by Oct 16) This is an automated message from the Apache Git Service. To

[GitHub] [geode] onichols-pivotal merged pull request #5527: GEODE-8496: bump dependency versions

2020-09-22 Thread GitBox
onichols-pivotal merged pull request #5527: URL: https://github.com/apache/geode/pull/5527 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey commented on pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-22 Thread GitBox
pdxcodemonkey commented on pull request #645: URL: https://github.com/apache/geode-native/pull/645#issuecomment-697028109 So the following 3 tests are now consistently failing on Windows: ``` The following tests FAILED: 14 - testRegionAccessThreadSafe (Timeout) 24 -

[GitHub] [geode] jinmeiliao opened a new pull request #5536: GEODE-8520: GCStatsMonitor should sum up all the GC stats to get the …

2020-09-22 Thread GitBox
jinmeiliao opened a new pull request #5536: URL: https://github.com/apache/geode/pull/5536 …total GC count and GC time. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geode] sabbeyPivotal opened a new pull request #5535: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
sabbeyPivotal opened a new pull request #5535: URL: https://github.com/apache/geode/pull/5535 Fixed test flakiness by awaiting for successful subscribe and psubscribe from Lettuce client. This is an automated message from

[GitHub] [geode] dschneider-pivotal merged pull request #5526: GEODE-8504: add info command

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5526: URL: https://github.com/apache/geode/pull/5526 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5534: Revert "GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5534: URL: https://github.com/apache/geode/pull/5534 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbeyPivotal opened a new pull request #5534: Revert "GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
sabbeyPivotal opened a new pull request #5534: URL: https://github.com/apache/geode/pull/5534 Reverts GEODE-8516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [geode] sabbeyPivotal opened a new pull request #5533: GEODE-8498: Messages written to Netty channel sometimes delivered out of order

2020-09-22 Thread GitBox
sabbeyPivotal opened a new pull request #5533: URL: https://github.com/apache/geode/pull/5533 Error from .tcl tests: ``` [err]: Mix SUBSCRIBE and PSUBSCRIBE in tests/unit/pubsub.tcl Expected 'pmessage foo.* foo.bar hello' to be equal to 'message foo.bar hello' *** [err]:

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5530: GEODE-8517: GatewaySenderEventImpl's 2 new attributes were introduced…

2020-09-22 Thread GitBox
pivotal-eshu commented on a change in pull request #5530: URL: https://github.com/apache/geode/pull/5530#discussion_r492888962 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java ## @@ -710,7 +710,7 @@ public int getDSFID() {

[GitHub] [geode] pivotal-jbarrett opened a new pull request #5532: GEODE-8513: Remove (de)serialization of local sessions.

2020-09-22 Thread GitBox
pivotal-jbarrett opened a new pull request #5532: URL: https://github.com/apache/geode/pull/5532 Removes query that resulted in casting issue in antlr. Clears all locally cached entries. Thank you for submitting a contribution to Apache Geode. In order to streamline the

[GitHub] [geode] bschuchardt merged pull request #5531: Revert "GEODE-8463: server's log filled with SSLException: Tag mismatch! (#5482)"

2020-09-22 Thread GitBox
bschuchardt merged pull request #5531: URL: https://github.com/apache/geode/pull/5531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] pdxcodemonkey commented on pull request #582: GEODE-7584: refactor pdx handling

2020-09-22 Thread GitBox
pdxcodemonkey commented on pull request #582: URL: https://github.com/apache/geode-native/pull/582#issuecomment-696896376 Closing this PR, since it's clear I'm not going to get around to addressing the changes requested any time soon, if at all. GEODE-7584 in Jira can remain active as a

[GitHub] [geode-native] pdxcodemonkey closed pull request #582: GEODE-7584: refactor pdx handling

2020-09-22 Thread GitBox
pdxcodemonkey closed pull request #582: URL: https://github.com/apache/geode-native/pull/582 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey merged pull request #654: GEODE-8514: python protocol tool

2020-09-22 Thread GitBox
pdxcodemonkey merged pull request #654: URL: https://github.com/apache/geode-native/pull/654 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5529: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-22 Thread GitBox
dschneider-pivotal merged pull request #5529: URL: https://github.com/apache/geode/pull/5529 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] bschuchardt opened a new pull request #5531: Revert "GEODE-8463: server's log filled with SSLException: Tag mismatch! (#5482)"

2020-09-22 Thread GitBox
bschuchardt opened a new pull request #5531: URL: https://github.com/apache/geode/pull/5531 This reverts commit 20a35ece18054e96eccda70c65a015f4af26b4c7. Changes for GEODE-8506 have fixed the problems with using TLSv1.3 in Java 8 so this commit needs to be reverted. Thank

[GitHub] [geode] jhutchison commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-22 Thread GitBox
jhutchison commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492821512 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java ## @@ -183,8 +184,16 @@ public boolean

[GitHub] [geode] jdeppe-pivotal merged pull request #5528: Redis StartUp tests use ephemeral port for Geode server

2020-09-22 Thread GitBox
jdeppe-pivotal merged pull request #5528: URL: https://github.com/apache/geode/pull/5528 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] gaussianrecurrence closed pull request #653: GEODE-8512: Add expectDomainClass for PdxInstance

2020-09-21 Thread GitBox
gaussianrecurrence closed pull request #653: URL: https://github.com/apache/geode-native/pull/653 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] gesterzhou opened a new pull request #5530: GEODE-8517: GatewaySenderEventImpl's 2 new attributes were introduced…

2020-09-21 Thread GitBox
gesterzhou opened a new pull request #5530: URL: https://github.com/apache/geode/pull/5530 … in 1.14 not 1.13 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [geode-native] alb3rtobr commented on pull request #651: Remove bucketServerLocation if timeout error

2020-09-21 Thread GitBox
alb3rtobr commented on pull request #651: URL: https://github.com/apache/geode-native/pull/651#issuecomment-696025816 @echobravopapa @pdxcodemonkey This is the PR with the change regarding the client metadata update when there is a timeout error that I mentioned in the dev list

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492072735 ## File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/server/InfoRedisAcceptanceTest.java ## @@ -0,0 +1,38 @@

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-21 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r492080459 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jhutchison commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jhutchison commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492157494 ## File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/server/InfoRedisAcceptanceTest.java ## @@ -0,0 +1,38 @@ +/*

[GitHub] [geode] jinmeiliao merged pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-21 Thread GitBox
jinmeiliao merged pull request #5507: URL: https://github.com/apache/geode/pull/5507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] sabbeyPivotal opened a new pull request #5529: GEODE-8516: Add Redis tests for multiple subscriptions for the same client

2020-09-21 Thread GitBox
sabbeyPivotal opened a new pull request #5529: URL: https://github.com/apache/geode/pull/5529 The commands that are allowed in the context of a subscribed client are SUBSCRIBE, PSUBSCRIBE, UNSUBSCRIBE, PUNSUBSCRIBE, PING and QUIT. Tests were added for these commands. We also

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #654: GEODE-8514: python protocol tool

2020-09-21 Thread GitBox
pdxcodemonkey opened a new pull request #654: URL: https://github.com/apache/geode-native/pull/654 See README for details/usage This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492343203 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/Command.java ## @@ -183,8 +184,16 @@ public boolean

[GitHub] [geode] ringles opened a new pull request #5528: Redis StartUp tests use ephemeral port for Geode server

2020-09-21 Thread GitBox
ringles opened a new pull request #5528: URL: https://github.com/apache/geode/pull/5528 GeodeRedisServerStartUpAcceptanceTest tests were using GFSH to start up servers. This meant the Geode server would listen on the default port (40404), and if any other process had that port bound,

[GitHub] [geode] jhutchison commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jhutchison commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492162274 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/server/InfoExecutor.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to the

[GitHub] [geode] jhutchison commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jhutchison commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492157494 ## File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/server/InfoRedisAcceptanceTest.java ## @@ -0,0 +1,38 @@ +/*

[GitHub] [geode] jinmeiliao merged pull request #5507: GEODE-8489: "Select *" query by DistributedSystemMBean should not hon…

2020-09-21 Thread GitBox
jinmeiliao merged pull request #5507: URL: https://github.com/apache/geode/pull/5507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492088829 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/server/InfoExecutor.java ## @@ -0,0 +1,107 @@ +/* + * Licensed to

[GitHub] [geode] albertogpz commented on a change in pull request #5509: GEODE-8491: Do not store dropped events in stopped primary gateway se…

2020-09-21 Thread GitBox
albertogpz commented on a change in pull request #5509: URL: https://github.com/apache/geode/pull/5509#discussion_r492080459 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/AbstractGatewaySender.java ## @@ -1118,6 +1115,17 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5526: GEODE-8504: add info command

2020-09-21 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5526: URL: https://github.com/apache/geode/pull/5526#discussion_r492072735 ## File path: geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/server/InfoRedisAcceptanceTest.java ## @@ -0,0 +1,38 @@

<    1   2   3   4   5   6   7   8   9   10   >