[GitHub] [geode] mhansonp commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-09-01 Thread GitBox
mhansonp commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r481498183 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,374 @@ +/* + *

[GitHub] [geode] mhansonp commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-09-01 Thread GitBox
mhansonp commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r481498183 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,374 @@ +/* + *

[GitHub] [geode] mhansonp commented on pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-09-01 Thread GitBox
mhansonp commented on pull request #5436: URL: https://github.com/apache/geode/pull/5436#issuecomment-685193313 I made some updates on mhansonp minorcleanup to resolve warnings. This is an automated message from the Apache

[GitHub] [geode-native] mmartell opened a new pull request #647: GEODE-8460: Run SNITests Based on Docker Availability

2020-09-01 Thread GitBox
mmartell opened a new pull request #647: URL: https://github.com/apache/geode-native/pull/647 This PR cleans up our docker based SNITests. In particular: - SNITests are now enabled during cmake configuration based on whether docker and docker-compose are installed. - SNITests

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-01 Thread GitBox
moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359 ## File path: cppcache/integration-test/fw_dunit.cpp ## @@ -71,10 +71,10 @@ using apache::geode::client::testframework::BBNamingContextServer;

[GitHub] [geode-native] moleske commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-01 Thread GitBox
moleske commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481420359 ## File path: cppcache/integration-test/fw_dunit.cpp ## @@ -71,10 +71,10 @@ using apache::geode::client::testframework::BBNamingContextServer;

[GitHub] [geode] boglesby opened a new pull request #5494: GEODE-8478: Refactored logThresholdExceededAlerts and modified it to …

2020-09-01 Thread GitBox
boglesby opened a new pull request #5494: URL: https://github.com/apache/geode/pull/5494 …handle exceptions Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #645: GEODE-8469: Enable no-missing-variable-declarations

2020-09-01 Thread GitBox
pivotal-jbarrett commented on a change in pull request #645: URL: https://github.com/apache/geode-native/pull/645#discussion_r481354457 ## File path: cppcache/benchmark/GeodeLoggingBM.cpp ## @@ -106,13 +106,13 @@ void GeodeLogToFile(benchmark::State& state) { } } -auto

[GitHub] [geode] demery-pivotal opened a new pull request #5493: GEODE-8404: Simplify AvailablePortHelper

2020-09-01 Thread GitBox
demery-pivotal opened a new pull request #5493: URL: https://github.com/apache/geode/pull/5493 Removed the following unused methods: - getRandomAvailableTCPPortRange(int) - getRandomAvailableTCPPorts(int,bool) - getRandomAvailableTCPPortRangeKeepers(int) -

[GitHub] [geode] demery-pivotal closed pull request #5471: GEODE-8404: Simplify AvailablePortHelper

2020-09-01 Thread GitBox
demery-pivotal closed pull request #5471: URL: https://github.com/apache/geode/pull/5471 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] agingade commented on a change in pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue

2020-09-01 Thread GitBox
agingade commented on a change in pull request #5492: URL: https://github.com/apache/geode/pull/5492#discussion_r481287853 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -755,12 +755,16 @@ public

[GitHub] [geode] bschuchardt closed pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

2020-09-01 Thread GitBox
bschuchardt closed pull request #5363: URL: https://github.com/apache/geode/pull/5363 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt merged pull request #5490: GEODE-8467: server fails to notify of a ForcedDisconnect and fails to tear down the cache

2020-09-01 Thread GitBox
bschuchardt merged pull request #5490: URL: https://github.com/apache/geode/pull/5490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] mkevo merged pull request #5476: GEODE-8455: Fix difference between create region with gw sender and a…

2020-09-01 Thread GitBox
mkevo merged pull request #5476: URL: https://github.com/apache/geode/pull/5476 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] gesterzhou opened a new pull request #5492: GEODE-8475: Resolve a potential dead lock in ParallelGatewaySenderQueue

2020-09-01 Thread GitBox
gesterzhou opened a new pull request #5492: URL: https://github.com/apache/geode/pull/5492 Co-authored-by: Darrel Schneider Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [geode] Bill commented on a change in pull request #5490: GEODE-8467: server fails to notify of a ForcedDisconnect and fails to tear down the cache

2020-08-31 Thread GitBox
Bill commented on a change in pull request #5490: URL: https://github.com/apache/geode/pull/5490#discussion_r480467213 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/GemFireCacheImpl.java ## @@ -1177,34 +1178,53 @@ public MeterRegistry

[GitHub] [geode] jdeppe-pivotal merged pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-31 Thread GitBox
jdeppe-pivotal merged pull request #5488: URL: https://github.com/apache/geode/pull/5488 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] bschuchardt opened a new pull request #5491: GEODE-8473: Hang in ReplyProcessor21 when forced-disconnect does not establish a cancellation cause

2020-08-31 Thread GitBox
bschuchardt opened a new pull request #5491: URL: https://github.com/apache/geode/pull/5491 ReplyProcessor21 will not stop waiting for responses to a message during a Forced Disconnect unless ClusterDistributionManager is informed of the disconnect. It sets a rootCause in its

[GitHub] [geode] bschuchardt opened a new pull request #5490: GEODE-8467: server fails to notify of a ForcedDisconnect and fails to tear down the cache

2020-08-31 Thread GitBox
bschuchardt opened a new pull request #5490: URL: https://github.com/apache/geode/pull/5490 Catch exceptions that occur during XML generation and disable auto reconnect. Ensure that the DisconnectThread is launched by placing it in a "finally" block. @kamilla1201 @Bill

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5483: GEODE-8462: Make geode server startup fail if geode redis server has a port conflict

2020-08-31 Thread GitBox
sabbeyPivotal commented on a change in pull request #5483: URL: https://github.com/apache/geode/pull/5483#discussion_r480347641 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java ## @@ -99,7 +99,7 @@ public

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-31 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5488: URL: https://github.com/apache/geode/pull/5488#discussion_r480285217 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -192,43 +244,50 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-31 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5488: URL: https://github.com/apache/geode/pull/5488#discussion_r480284887 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -247,25 +306,16 @@ private

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-31 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5488: URL: https://github.com/apache/geode/pull/5488#discussion_r480284675 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -139,6 +164,33 @@ public void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5483: GEODE-8462: Make geode server startup fail if geode redis server has a port conflict

2020-08-31 Thread GitBox
dschneider-pivotal commented on a change in pull request #5483: URL: https://github.com/apache/geode/pull/5483#discussion_r480247313 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/NettyRedisServer.java ## @@ -99,7 +99,7 @@ public

[GitHub] [geode-native] rhoughton-pivot commented on a change in pull request #644: Remove GemFireVersion.getBuildDate()

2020-08-31 Thread GitBox
rhoughton-pivot commented on a change in pull request #644: URL: https://github.com/apache/geode-native/pull/644#discussion_r480243826 ## File path: tests/javaobject/LatestProp.java ## @@ -24,7 +24,6 @@ public class LatestProp { public static void main(String[] args){ -

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-31 Thread GitBox
dschneider-pivotal commented on a change in pull request #5488: URL: https://github.com/apache/geode/pull/5488#discussion_r480229528 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -61,17 +64,22 @@ public class

[GitHub] [geode-native] mmartell merged pull request #646: GEODE-8470: Properly stop running containers in SNI

2020-08-31 Thread GitBox
mmartell merged pull request #646: URL: https://github.com/apache/geode-native/pull/646 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] mmartell commented on a change in pull request #646: GEODE-8470: Properly stop running containers in SNI

2020-08-31 Thread GitBox
mmartell commented on a change in pull request #646: URL: https://github.com/apache/geode-native/pull/646#discussion_r480215816 ## File path: clicache/integration-test2/SNITests.cs ## @@ -58,10 +58,10 @@ public SNITests(ITestOutputHelper testOutputHelper) :

[GitHub] [geode-native] mmartell commented on a change in pull request #646: GEODE-8470: Properly stop running containers in SNI

2020-08-31 Thread GitBox
mmartell commented on a change in pull request #646: URL: https://github.com/apache/geode-native/pull/646#discussion_r480215816 ## File path: clicache/integration-test2/SNITests.cs ## @@ -58,10 +58,10 @@ public SNITests(ITestOutputHelper testOutputHelper) :

[GitHub] [geode] gesterzhou opened a new pull request #5489: GEODE-8432-2: use getRegionPath instead of getRegion to avoid waitOnI…

2020-08-30 Thread GitBox
gesterzhou opened a new pull request #5489: URL: https://github.com/apache/geode/pull/5489 …nitiailize Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [geode-native] moleske opened a new pull request #646: GEODE-8470: Properly stop running containers in SNI

2020-08-30 Thread GitBox
moleske opened a new pull request #646: URL: https://github.com/apache/geode-native/pull/646 -use docker system prune -f to clean up networks and stopped containers Noticed when trying to `docker rmi` the downloaded images and it said there were still containers with them.

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5488: GEODE-8333: Change Redis adapter threading model - fixes pubsub issues

2020-08-30 Thread GitBox
jdeppe-pivotal opened a new pull request #5488: URL: https://github.com/apache/geode/pull/5488 - Do not use Netty threads for the entire request lifecycle. Each instance of ExecutionHandlerContext (essentially each client connection) uses a command queue which is actioned by a

[GitHub] [geode] jdeppe-pivotal closed pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-30 Thread GitBox
jdeppe-pivotal closed pull request #5420: URL: https://github.com/apache/geode/pull/5420 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal closed pull request #5487: [DO NOT REVIEW] Geode 8333 fix pubsub hang another approach

2020-08-30 Thread GitBox
jdeppe-pivotal closed pull request #5487: URL: https://github.com/apache/geode/pull/5487 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jdeppe-pivotal commented on pull request #5487: [DO NOT REVIEW] Geode 8333 fix pubsub hang another approach

2020-08-30 Thread GitBox
jdeppe-pivotal commented on pull request #5487: URL: https://github.com/apache/geode/pull/5487#issuecomment-683496947 Closing in favor of a cleaned up PR... This is an automated message from the Apache Git Service. To

[GitHub] [geode-native] moleske opened a new pull request #645: Enable no-missing-variable-declarations

2020-08-29 Thread GitBox
moleske opened a new pull request #645: URL: https://github.com/apache/geode-native/pull/645 Authored-by: M. Oleske This is in draft because it is working for everything but the following three tests on Windows ```console 14 - testRegionAccessThreadSafe (Timeout) 24 -

[GitHub] [geode-native] moleske opened a new pull request #644: Remove GemFireVersion.getBuildDate()

2020-08-29 Thread GitBox
moleske opened a new pull request #644: URL: https://github.com/apache/geode-native/pull/644 This [commit](https://github.com/apache/geode/commit/d9d13100ae11e2eba8a6428fad29007388680b43#diff-a377b15d2036a2fc9072c1915c7f0ed4L83) removed getBuildDate() in the java code, causing geode

[GitHub] [geode-native] moleske opened a new pull request #643: Add note that docker compose is needed

2020-08-29 Thread GitBox
moleske opened a new pull request #643: URL: https://github.com/apache/geode-native/pull/643 Docker Compose is installed on Mac and Windows when using Docker Desktop. On Linux you install Docker and Docker Compose separately, so it should be called out in our docs

[GitHub] [geode-native] moleske merged pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

2020-08-29 Thread GitBox
moleske merged pull request #625: URL: https://github.com/apache/geode-native/pull/625 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] moleske commented on pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

2020-08-28 Thread GitBox
moleske commented on pull request #625: URL: https://github.com/apache/geode-native/pull/625#issuecomment-683194871 Per conversation with @pdxcodemonkey on the [asf slack](https://the-asf.slack.com/archives/C4RJQAQJF/p1598649633002500?thread_ts=1598634493.001700=C4RJQAQJF), went ahead and

[GitHub] [geode] bschuchardt merged pull request #5482: GEODE-8463: server's log filled with SSLException: Tag mismatch!

2020-08-28 Thread GitBox
bschuchardt merged pull request #5482: URL: https://github.com/apache/geode/pull/5482 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] rhoughton-pivot merged pull request #5480: GEODE-8458: Use build metadata properties as task inputs

2020-08-28 Thread GitBox
rhoughton-pivot merged pull request #5480: URL: https://github.com/apache/geode/pull/5480 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-28 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r479359658 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,369 @@ +/* + *

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-28 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r479357437 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,369 @@ +/* + *

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5487: [DO NOT REVIEW] Geode 8333 fix pubsub hang another approach

2020-08-28 Thread GitBox
jdeppe-pivotal opened a new pull request #5487: URL: https://github.com/apache/geode/pull/5487 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] albertogpz opened a new pull request #5486: DRAFT: Do not store dropped events in stopped primary gateway sender when po…

2020-08-28 Thread GitBox
albertogpz opened a new pull request #5486: URL: https://github.com/apache/geode/pull/5486 …ssible Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [geode] nabarunnag closed pull request #5484: GEODE-7864: Printing array contents

2020-08-27 Thread GitBox
nabarunnag closed pull request #5484: URL: https://github.com/apache/geode/pull/5484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] nabarunnag closed pull request #5485: GEODE-7864: Always true check removed.

2020-08-27 Thread GitBox
nabarunnag closed pull request #5485: URL: https://github.com/apache/geode/pull/5485 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] Bill commented on pull request #5480: GEODE-8458: Use build metadata properties as task inputs

2020-08-27 Thread GitBox
Bill commented on pull request #5480: URL: https://github.com/apache/geode/pull/5480#issuecomment-682255954 Testing… 1. `./gradlew build -PproductName="GemFire" -PgeodeVersion=1.14.0-build.0 -Pversion=1.14.0-build.0 -PbuildId=0 -x test` generates `GemFireVersion.properties` with

[GitHub] [geode] DonalEvans commented on a change in pull request #5485: GEODE-7864: Always true check removed.

2020-08-27 Thread GitBox
DonalEvans commented on a change in pull request #5485: URL: https://github.com/apache/geode/pull/5485#discussion_r478744835 ## File path: geode-core/src/main/java/org/apache/geode/distributed/internal/ClusterDistributionManager.java ## @@ -1387,7 +1387,7 @@ void

[GitHub] [geode] lgtm-com[bot] commented on pull request #5484: GEODE-7864: Printing array contents

2020-08-27 Thread GitBox
lgtm-com[bot] commented on pull request #5484: URL: https://github.com/apache/geode/pull/5484#issuecomment-682198563 This pull request **fixes 1 alert** when merging cb5386cd80221e2f3be30c2317381e047dcc5dc6 into 0c2a8a3f2cc7d57cc7ddfd47944aa0fecb4f6655 - [view on

[GitHub] [geode] nabarunnag opened a new pull request #5485: GEODE-7864: Always true check removed.

2020-08-27 Thread GitBox
nabarunnag opened a new pull request #5485: URL: https://github.com/apache/geode/pull/5485 * removed the check for id less than membershipViewIdAcknowledged * check is already done the beginning of method Thank you for submitting a contribution to Apache Geode. In

[GitHub] [geode] DonalEvans merged pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-27 Thread GitBox
DonalEvans merged pull request #5473: URL: https://github.com/apache/geode/pull/5473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] nabarunnag opened a new pull request #5484: GEODE-7864: Printing array contents

2020-08-27 Thread GitBox
nabarunnag opened a new pull request #5484: URL: https://github.com/apache/geode/pull/5484 * Array contents are now printed in the exception message Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you

[GitHub] [geode] jhutchison opened a new pull request #5483: GEODE-8462: Make geode server startup fail if geode redis server has …

2020-08-27 Thread GitBox
jhutchison opened a new pull request #5483: URL: https://github.com/apache/geode/pull/5483 …port conflict Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [geode] agingade commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-27 Thread GitBox
agingade commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r478637836 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,369 @@ +/* + *

[GitHub] [geode-native] pdxcodemonkey merged pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

2020-08-27 Thread GitBox
pdxcodemonkey merged pull request #642: URL: https://github.com/apache/geode-native/pull/642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jdeppe-pivotal merged pull request #5470: GEODE-8448: Update README based on user feedback

2020-08-27 Thread GitBox
jdeppe-pivotal merged pull request #5470: URL: https://github.com/apache/geode/pull/5470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] albertogpz commented on pull request #5476: GEODE-8455: Fix difference between create region with gw sender and a…

2020-08-27 Thread GitBox
albertogpz commented on pull request #5476: URL: https://github.com/apache/geode/pull/5476#issuecomment-681917316 > A few small changes to clean up the code a bit. I also notice that there are several DUnit test failures associated with this change (more than we would expect just due to

[GitHub] [geode-native] albertogpz commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

2020-08-27 Thread GitBox
albertogpz commented on a change in pull request #642: URL: https://github.com/apache/geode-native/pull/642#discussion_r478300118 ## File path: cppcache/src/ThinClientPoolDM.cpp ## @@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest( }

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

2020-08-26 Thread GitBox
pivotal-jbarrett commented on a change in pull request #642: URL: https://github.com/apache/geode-native/pull/642#discussion_r477658402 ## File path: cppcache/src/ThinClientPoolDM.cpp ## @@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest( }

[GitHub] [geode] bschuchardt opened a new pull request #5482: GEODE-8463: server's log filled with SSLException: Tag mismatch!

2020-08-26 Thread GitBox
bschuchardt opened a new pull request #5482: URL: https://github.com/apache/geode/pull/5482 This disables the use of TLSv1.3 selection if "any" is specified as the protocol and throws an exception if TLSv1.3 is requested in a JVM older than Java 11. Most Java 8 implementations do not

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-26 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-681131715 This pull request **introduces 2 alerts** and **fixes 2** when merging 52589379decb06a1f58a5d4e67d645bf0a93c288 into cecf0035be9ea02b8ff66749f61ce93c026646ca - [view on

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-26 Thread GitBox
DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r477596231 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken

[GitHub] [geode-native] moleske commented on a change in pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

2020-08-26 Thread GitBox
moleske commented on a change in pull request #642: URL: https://github.com/apache/geode-native/pull/642#discussion_r477581852 ## File path: cppcache/src/ThinClientPoolDM.cpp ## @@ -1428,10 +1428,12 @@ GfErrType ThinClientPoolDM::sendSyncRequest( }

[GitHub] [geode] moleske commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-26 Thread GitBox
moleske commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r477579763 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken implements

[GitHub] [geode] jdeppe-pivotal merged pull request #5481: GEODE-8459: Redis API for Geode handles errors when member disconnects

2020-08-26 Thread GitBox
jdeppe-pivotal merged pull request #5481: URL: https://github.com/apache/geode/pull/5481 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] smgoller merged pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

2020-08-26 Thread GitBox
smgoller merged pull request #5479: URL: https://github.com/apache/geode/pull/5479 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] DonalEvans commented on a change in pull request #5476: GEODE-8455: Fix difference between create region with gw sender and a…

2020-08-26 Thread GitBox
DonalEvans commented on a change in pull request #5476: URL: https://github.com/apache/geode/pull/5476#discussion_r477509049 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/WANTestBase.java ## @@ -3197,6 +3114,18 @@ public static Boolean

[GitHub] [geode] sabbeyPivotal opened a new pull request #5481: GEODE-8459: Redis API for Geode handles errors when member disconnects

2020-08-26 Thread GitBox
sabbeyPivotal opened a new pull request #5481: URL: https://github.com/apache/geode/pull/5481 Redis API for Geode should properly handle DistributedSystemDisconnectedException and ForcedDisconnectException when member disconnects. Client should be closed and a null response should be

[GitHub] [geode] jinmeiliao merged pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-26 Thread GitBox
jinmeiliao merged pull request #5469: URL: https://github.com/apache/geode/pull/5469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] rhoughton-pivot commented on a change in pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

2020-08-26 Thread GitBox
rhoughton-pivot commented on a change in pull request #5479: URL: https://github.com/apache/geode/pull/5479#discussion_r477467740 ## File path: ci/scripts/execute_build_examples.sh ## @@ -46,7 +46,8 @@ INSTANCE_IP_ADDRESS="$(cat instance-data/instance-ip-address)"

[GitHub] [geode] rhoughton-pivot opened a new pull request #5480: GEODE-8458: Use build metadata properties as task inputs

2020-08-26 Thread GitBox
rhoughton-pivot opened a new pull request #5480: URL: https://github.com/apache/geode/pull/5480 * Rebuilds GemFireVersion.properties on Git repo or property changes * version * build user * java version * productName * etc Thank you for submitting a

[GitHub] [geode] smgoller opened a new pull request #5479: [GEODE-8321] backport liberica changes to 1.12.

2020-08-26 Thread GitBox
smgoller opened a new pull request #5479: URL: https://github.com/apache/geode/pull/5479 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] smgoller merged pull request #5474: Part 2 - Change all tests to use liberica instead of openjdk. Part 3 will remove openjdk.

2020-08-26 Thread GitBox
smgoller merged pull request #5474: URL: https://github.com/apache/geode/pull/5474 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] albertogpz opened a new pull request #642: GEODE-8457: Fix crash when IO_error and single-hop=false

2020-08-26 Thread GitBox
albertogpz opened a new pull request #642: URL: https://github.com/apache/geode-native/pull/642 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-native] mmartell merged pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
mmartell merged pull request #641: URL: https://github.com/apache/geode-native/pull/641 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] echobravopapa commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
echobravopapa commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477413163 ## File path: cppcache/src/Pool.cpp ## @@ -45,6 +45,9 @@ std::chrono::milliseconds Pool::getReadTimeout() const { return

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-26 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r477410555 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode-native] mmartell commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
mmartell commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477357183 ## File path: cppcache/src/Pool.cpp ## @@ -45,6 +45,9 @@ std::chrono::milliseconds Pool::getReadTimeout() const { return

[GitHub] [geode-native] mmartell commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
mmartell commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477356345 ## File path: clicache/test2/Tests2.cs ## @@ -123,7 +123,24 @@ public void RegisterPdxType() Assert.False(_pdxDelegate2Called); } -

[GitHub] [geode-native] echobravopapa commented on a change in pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
echobravopapa commented on a change in pull request #641: URL: https://github.com/apache/geode-native/pull/641#discussion_r477343512 ## File path: clicache/test2/Tests2.cs ## @@ -123,7 +123,24 @@ public void RegisterPdxType() Assert.False(_pdxDelegate2Called); }

[GitHub] [geode-native] mmartell opened a new pull request #641: GEODE-8398: Add sni unittest for dotnet

2020-08-26 Thread GitBox
mmartell opened a new pull request #641: URL: https://github.com/apache/geode-native/pull/641 Since the .NET API is a thin wrapper around the C++ API, all we really need to test in this layer is that the sni parameters are passed properly to the C++ layer. This PR adds a new unit

[GitHub] [geode] lgtm-com[bot] commented on pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
lgtm-com[bot] commented on pull request #5473: URL: https://github.com/apache/geode/pull/5473#issuecomment-680511762 This pull request **fixes 34 alerts** when merging 954dcda6e369d003e8f8c7e2e5798cb2fda47989 into 06174302b2c255fa6da8572fe7444df5dd1b2767 - [view on

[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r47779 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java ## @@ -94,6 +94,8 @@ public

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476998382 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken

[GitHub] [geode] lgtm-com[bot] commented on pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
lgtm-com[bot] commented on pull request #5473: URL: https://github.com/apache/geode/pull/5473#issuecomment-680372961 This pull request **fixes 34 alerts** when merging 5d7674902f9f77dc66d18a6c3d5c711e7ab30b33 into 06174302b2c255fa6da8572fe7444df5dd1b2767 - [view on

[GitHub] [geode] moleske commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
moleske commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476902292 ## File path: geode-core/src/main/java/org/apache/geode/cache/query/internal/NullToken.java ## @@ -33,6 +33,7 @@ */ public class NullToken implements

[GitHub] [geode] jchen21 commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-25 Thread GitBox
jchen21 commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r476893010 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476889738 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegion.java ## @@ -2641,9 +2640,7 @@ private VersionedObjectList

[GitHub] [geode] jchen21 commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jchen21 commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r476884043 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java ## @@ -94,6 +94,8 @@ public

[GitHub] [geode] mhansonp commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
mhansonp commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476878803 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -5653,7 +5667,7 @@ private void deleteFile(final OplogFile olf) {

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476878064 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -5653,7 +5667,7 @@ private void deleteFile(final OplogFile olf)

[GitHub] [geode] DonalEvans commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
DonalEvans commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476877485 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -3583,7 +3597,7 @@ private void basicCreate(DiskRegion dr,

[GitHub] [geode] onichols-pivotal merged pull request #5477: GEODE-8456: bump Shiro to 1.6.0

2020-08-25 Thread GitBox
onichols-pivotal merged pull request #5477: URL: https://github.com/apache/geode/pull/5477 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] demery-pivotal closed pull request #5478: DO NOT REVIEW Innocuous change to provoke StressNewTest

2020-08-25 Thread GitBox
demery-pivotal closed pull request #5478: URL: https://github.com/apache/geode/pull/5478 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mhansonp commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
mhansonp commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476756464 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -5653,7 +5667,7 @@ private void deleteFile(final OplogFile olf) {

[GitHub] [geode] mhansonp commented on a change in pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-25 Thread GitBox
mhansonp commented on a change in pull request #5473: URL: https://github.com/apache/geode/pull/5473#discussion_r476743929 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/Oplog.java ## @@ -3583,7 +3597,7 @@ private void basicCreate(DiskRegion dr,

[GitHub] [geode] demery-pivotal opened a new pull request #5478: DO NOT REVIEW Innocuous change to provoke StressNewTest

2020-08-25 Thread GitBox
demery-pivotal opened a new pull request #5478: URL: https://github.com/apache/geode/pull/5478 This test is failing in another PR. I'm making an innocuous change in the test in order to provoke the stress test. This is an

[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r476711410 ## File path: boms/geode-all-bom/src/test/resources/expected-pom.xml ## @@ -67,6 +67,12 @@ 2.9.8 compile + +

<    1   2   3   4   5   6   7   8   9   10   >