[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r476680524 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/json/AbstractJSONFormatter.java ## @@ -94,6 +94,8 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r476679877 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/json/QueryResultFormatterTest.java ## @@ -117,15 +119,19 @@ public void

[GitHub] [geode] jchen21 commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-25 Thread GitBox
jchen21 commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r476648457 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/json/QueryResultFormatterTest.java ## @@ -117,15 +119,19 @@ public void

[GitHub] [geode] sabbeyPivotal commented on pull request #5470: GEODE-8448: Update README based on user feedback

2020-08-25 Thread GitBox
sabbeyPivotal commented on pull request #5470: URL: https://github.com/apache/geode/pull/5470#issuecomment-680024833 Acceptance Test failure is unrelated to this PR This is an automated message from the Apache Git Service.

[GitHub] [geode] albertogpz opened a new pull request #5476: GEODE-8455: Fix difference between create region with gw sender and a…

2020-08-25 Thread GitBox
albertogpz opened a new pull request #5476: URL: https://github.com/apache/geode/pull/5476 …lter region with gw sender Geode behaves differently with respect to transactions when creating a partitioned region with a parallel gateway sender to when first the partitioned region

[GitHub] [geode] pivotal-jbarrett opened a new pull request #5475: Wip/ephemeral member ports and non dockerization

2020-08-24 Thread GitBox
pivotal-jbarrett opened a new pull request #5475: URL: https://github.com/apache/geode/pull/5475 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] jdeppe-pivotal merged pull request #5472: GEODE-8451 Redis ping response contains unneeded quotes

2020-08-24 Thread GitBox
jdeppe-pivotal merged pull request #5472: URL: https://github.com/apache/geode/pull/5472 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] pdxcodemonkey merged pull request #640: GEODE-8445: Remove copy step for cryptoimpl library

2020-08-24 Thread GitBox
pdxcodemonkey merged pull request #640: URL: https://github.com/apache/geode-native/pull/640 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] smgoller opened a new pull request #5474: Part 2 - Change all tests to use liberica instead of openjdk. Part 3 will remove openjdk.

2020-08-24 Thread GitBox
smgoller opened a new pull request #5474: URL: https://github.com/apache/geode/pull/5474 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] sabbeyPivotal commented on pull request #5472: GEODE-8451 Redis ping response contains unneeded quotes

2020-08-24 Thread GitBox
sabbeyPivotal commented on pull request #5472: URL: https://github.com/apache/geode/pull/5472#issuecomment-679355527 AcceptanceTest failure is unrelated to this PR This is an automated message from the Apache Git Service. To

[GitHub] [geode] lgtm-com[bot] commented on pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-24 Thread GitBox
lgtm-com[bot] commented on pull request #5473: URL: https://github.com/apache/geode/pull/5473#issuecomment-679329116 This pull request **fixes 34 alerts** when merging 45f04b8da7c3071352c3805af465896cf13406f3 into afb161fe793ebaede473c996e88cc161b9c5b6f5 - [view on

[GitHub] [geode] DonalEvans opened a new pull request #5473: GEODE-7864: Fix some LGTM alerts and suppress some false positives

2020-08-24 Thread GitBox
DonalEvans opened a new pull request #5473: URL: https://github.com/apache/geode/pull/5473 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #640: GEODE-8445: Remove copy step for cryptoimpl library

2020-08-24 Thread GitBox
pdxcodemonkey opened a new pull request #640: URL: https://github.com/apache/geode-native/pull/640 - dotnet SSL example build was broken, because we no longer use cryptoimpl to access SSL @mreddington @dihardman @karensmolermiller @davebarnes97

[GitHub] [geode] gesterzhou commented on a change in pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-24 Thread GitBox
gesterzhou commented on a change in pull request #5467: URL: https://github.com/apache/geode/pull/5467#discussion_r475777699 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java ## @@ -994,13 +994,18 @@ public boolean

[GitHub] [geode] mhansonp commented on a change in pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-24 Thread GitBox
mhansonp commented on a change in pull request #5467: URL: https://github.com/apache/geode/pull/5467#discussion_r475768556 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/versions/RegionVersionVector.java ## @@ -994,13 +994,18 @@ public boolean

[GitHub] [geode] jhutchison opened a new pull request #5472: GEODE-8451 Redis ping response contains uneeded quotes

2020-08-24 Thread GitBox
jhutchison opened a new pull request #5472: URL: https://github.com/apache/geode/pull/5472 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jinmeiliao commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-24 Thread GitBox
jinmeiliao commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r475689526 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -0,0

[GitHub] [geode] agingade commented on a change in pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-24 Thread GitBox
agingade commented on a change in pull request #5469: URL: https://github.com/apache/geode/pull/5469#discussion_r475670905 ## File path: geode-core/src/integrationTest/java/org/apache/geode/management/internal/beans/DistributedSystemMBeanIntegrationTest.java ## @@ -0,0 +1,149

[GitHub] [geode-native] mmartell merged pull request #639: GEODE-8441: AppDomainContext was initialized too late

2020-08-24 Thread GitBox
mmartell merged pull request #639: URL: https://github.com/apache/geode-native/pull/639 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jujoramos commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
jujoramos commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678986015 Thanks you @mkevo ! This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [geode] mkevo merged pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
mkevo merged pull request #5466: URL: https://github.com/apache/geode/pull/5466 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mkevo commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-24 Thread GitBox
mkevo commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678983408 @jujoramos , thanks a lot! :) This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [geode-native] mmartell commented on a change in pull request #639: GEODE-8441: AppDomainContext was initialized too late

2020-08-23 Thread GitBox
mmartell commented on a change in pull request #639: URL: https://github.com/apache/geode-native/pull/639#discussion_r475340679 ## File path: clicache/src/CacheFactory.cpp ## @@ -70,14 +71,12 @@ namespace Apache pdxReadSerialized =

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #639: GEODE-8441: AppDomainContext was initialized too late

2020-08-23 Thread GitBox
pivotal-jbarrett commented on a change in pull request #639: URL: https://github.com/apache/geode-native/pull/639#discussion_r475313465 ## File path: clicache/src/CacheFactory.cpp ## @@ -70,14 +71,12 @@ namespace Apache pdxReadSerialized =

[GitHub] [geode-native] mmartell opened a new pull request #639: GEODE-8441: AppDomainContext was initialized too late

2020-08-23 Thread GitBox
mmartell opened a new pull request #639: URL: https://github.com/apache/geode-native/pull/639 This fixes a longstanding AppDomain bug that was introduced back in March 2017, wherein the AppDomainContext was being initialized after the cache was created.

[GitHub] [geode] DonalEvans merged pull request #5442: GEODE-8420: Throws SQLException when SQLException occurs in JdbcWriter

2020-08-22 Thread GitBox
DonalEvans merged pull request #5442: URL: https://github.com/apache/geode/pull/5442 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] masaki-yamakawa commented on pull request #5442: GEODE-8420: Throws SQLException when SQLException occurs in JdbcWriter

2020-08-22 Thread GitBox
masaki-yamakawa commented on pull request #5442: URL: https://github.com/apache/geode/pull/5442#issuecomment-678632732 @DonalEvans Thank you for your suggestions. I have fixed it that I follow your suggestions. This

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-21 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r475020784 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java ## @@ -362,28 +362,40 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-21 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r475019758 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,9 +198,56 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-21 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r475017603 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,9 +198,56 @@ public

[GitHub] [geode] demery-pivotal opened a new pull request #5471: DO NOT REVIEW Simplify AvailablePortHelper

2020-08-21 Thread GitBox
demery-pivotal opened a new pull request #5471: URL: https://github.com/apache/geode/pull/5471 Removed two methods that used an incorrect calculation to try to distribute ports evenly across VMs: - getRandomAvailablePortForDUnitSite() - getRandomAvailableTCPPortsForDUnitSite()

[GitHub] [geode] lgtm-com[bot] commented on pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-21 Thread GitBox
lgtm-com[bot] commented on pull request #5467: URL: https://github.com/apache/geode/pull/5467#issuecomment-678498383 This pull request **introduces 1 alert** when merging 84a205b2ea34c92b630843f70f74d3000d3bc85d into 9c31b21d1c23c52f1c047eed696d1db84390aa28 - [view on

[GitHub] [geode] DonalEvans commented on a change in pull request #5442: GEODE-8420: Throws SQLException when SQLException occurs in JdbcWriter

2020-08-21 Thread GitBox
DonalEvans commented on a change in pull request #5442: URL: https://github.com/apache/geode/pull/5442#discussion_r474948338 ## File path: geode-connectors/src/main/java/org/apache/geode/connectors/jdbc/internal/SqlHandler.java ## @@ -255,6 +265,10 @@ private

[GitHub] [geode] ringles opened a new pull request #5470: GEODE-8448: Update README based on user feedback

2020-08-21 Thread GitBox
ringles opened a new pull request #5470: URL: https://github.com/apache/geode/pull/5470 Update Redis API readme based on user testing feedback. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode-native] pdxcodemonkey merged pull request #636: Add notes about docker requirement

2020-08-21 Thread GitBox
pdxcodemonkey merged pull request #636: URL: https://github.com/apache/geode-native/pull/636 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey commented on pull request #636: Add notes about docker requirement

2020-08-21 Thread GitBox
pdxcodemonkey commented on pull request #636: URL: https://github.com/apache/geode-native/pull/636#issuecomment-678426099 https://issues.apache.org/jira/browse/GEODE-8446 filed to track CMake work This is an automated

[GitHub] [geode] jinmeiliao opened a new pull request #5469: GEODE-8447: QueryResultFormatter should show dates in localized strings

2020-08-21 Thread GitBox
jinmeiliao opened a new pull request #5469: URL: https://github.com/apache/geode/pull/5469 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] onichols-pivotal merged pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-21 Thread GitBox
onichols-pivotal merged pull request #5462: URL: https://github.com/apache/geode/pull/5462 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] Bill commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-21 Thread GitBox
Bill commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r474792807 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,9 +198,56 @@ public ResultModel

[GitHub] [geode] jujoramos commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-21 Thread GitBox
jujoramos commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678155967 Thanks!!. Will run the internal battery test and let you know how it goes!. This is an automated message from

[GitHub] [geode] mkevo commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-21 Thread GitBox
mkevo commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678148772 > Hey @mkevo , I'm really sorry to bother you with this... but would it be possible to rebase this `PR` against the latest `develop` branch and force push the changes here again so

[GitHub] [geode] mkevo closed pull request #5468: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-21 Thread GitBox
mkevo closed pull request #5468: URL: https://github.com/apache/geode/pull/5468 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mkevo opened a new pull request #5468: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-21 Thread GitBox
mkevo opened a new pull request #5468: URL: https://github.com/apache/geode/pull/5468 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jujoramos commented on pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-21 Thread GitBox
jujoramos commented on pull request #5466: URL: https://github.com/apache/geode/pull/5466#issuecomment-678142446 Hey @mkevo , I'm really sorry to bother you with this... but would it be possible to rebase this `PR` against the latest `develop` branch and force push the changes here again

[GitHub] [geode-native] alb3rtobr commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-21 Thread GitBox
alb3rtobr commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-678108637 Just to confirm: the problem for the revert is that the new test case of this PR fails on RHEL platform, or it is that the code changed is making other tests to fail?

[GitHub] [geode] mkevo commented on a change in pull request #5397: GEODE-8293: fix decrementing activeCQCount

2020-08-21 Thread GitBox
mkevo commented on a change in pull request #5397: URL: https://github.com/apache/geode/pull/5397#discussion_r474481140 ## File path: geode-cq/src/main/java/org/apache/geode/cache/query/cq/internal/ServerCQImpl.java ## @@ -367,10 +367,12 @@ public void close(boolean

[GitHub] [geode] gesterzhou opened a new pull request #5467: GEODE-8444: When requester's RVV equals provider's rvvGC, should do f…

2020-08-21 Thread GitBox
gesterzhou opened a new pull request #5467: URL: https://github.com/apache/geode/pull/5467 …ullGII Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:

[GitHub] [geode-native] pdxcodemonkey merged pull request #638: GEODE-8443: Disable Windows SNI test as intended

2020-08-20 Thread GitBox
pdxcodemonkey merged pull request #638: URL: https://github.com/apache/geode-native/pull/638 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey opened a new pull request #638: GEODE-8443: Disable Windows SNI test as intended

2020-08-20 Thread GitBox
pdxcodemonkey opened a new pull request #638: URL: https://github.com/apache/geode-native/pull/638 - It's being run in the test suite due to a typo This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode-native] pdxcodemonkey merged pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
pdxcodemonkey merged pull request #635: URL: https://github.com/apache/geode-native/pull/635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey merged pull request #637: GEODE-8344: Fix Windows build

2020-08-20 Thread GitBox
pdxcodemonkey merged pull request #637: URL: https://github.com/apache/geode-native/pull/637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jujoramos closed pull request #5463: [WIP]: GEM-2931

2020-08-20 Thread GitBox
jujoramos closed pull request #5463: URL: https://github.com/apache/geode/pull/5463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jujoramos commented on a change in pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
jujoramos commented on a change in pull request #5466: URL: https://github.com/apache/geode/pull/5466#discussion_r474010363 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java ## @@ -519,6 +520,25

[GitHub] [geode] jujoramos commented on a change in pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
jujoramos commented on a change in pull request #5466: URL: https://github.com/apache/geode/pull/5466#discussion_r474009698 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/DiskStoreCommandsDUnitTest.java ## @@ -519,6 +520,25

[GitHub] [geode] mkevo closed pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
mkevo closed pull request #5175: URL: https://github.com/apache/geode/pull/5175 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677581744 Hi @jujoramos , I wish that I spotted it earlier so you don't waste your time on this. Thanks again for a help! New [PR](https://github.com/apache/geode/pull/5466) is

[GitHub] [geode] mkevo opened a new pull request #5466: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
mkevo opened a new pull request #5466: URL: https://github.com/apache/geode/pull/5466 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677529060 Sounds good @mkevo, thanks for the update and sorry for all the back and forth, I wish I have had spotted the single line fix before to spare you some time :-/. Once the `PR`

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677527803 > I'm still not sure that the changes within the `DiskStoreCommandUtils` class are needed to address the problem. I've opened a draft

[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-20 Thread GitBox
jujoramos commented on a change in pull request #5175: URL: https://github.com/apache/geode/pull/5175#discussion_r472878920 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/DiskStoreImpl.java ## @@ -2318,7 +2318,7 @@ void close(boolean destroy) {

[GitHub] [geode-native] alb3rtobr edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
alb3rtobr edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-677451250 > > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: > >

[GitHub] [geode-native] alb3rtobr opened a new pull request #637: GEODE-8344: Fix Windows build

2020-08-20 Thread GitBox
alb3rtobr opened a new pull request #637: URL: https://github.com/apache/geode-native/pull/637 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode] mivanac merged pull request #5460: GEODE-8433: added inheritance of off-heap attribute

2020-08-20 Thread GitBox
mivanac merged pull request #5460: URL: https://github.com/apache/geode/pull/5460 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode-native] alb3rtobr commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
alb3rtobr commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-677451250 > > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: > >

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473746105 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473716608 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] alb3rtobr commented on a change in pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-20 Thread GitBox
alb3rtobr commented on a change in pull request #635: URL: https://github.com/apache/geode-native/pull/635#discussion_r473716608 ## File path: cppcache/src/PdxTypeRegistry.cpp ## @@ -89,8 +89,8 @@ int32_t PdxTypeRegistry::getPDXIdForType(std::shared_ptr nType, typeId =

[GitHub] [geode-native] moleske commented on pull request #636: Add notes about docker requirement

2020-08-19 Thread GitBox
moleske commented on pull request #636: URL: https://github.com/apache/geode-native/pull/636#issuecomment-676882065 I think we need both, we should call out that if you really want to run all the tests, you will need docker and we should do some cmake logic to help out

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #636: Add notes about docker requirement

2020-08-19 Thread GitBox
pivotal-jbarrett commented on pull request #636: URL: https://github.com/apache/geode-native/pull/636#issuecomment-676879501 How about making CMake detect Docker and enable/disable Docker based tests depending on its existence?

[GitHub] [geode-native] moleske opened a new pull request #636: Add notes about docker requirement

2020-08-19 Thread GitBox
moleske opened a new pull request #636: URL: https://github.com/apache/geode-native/pull/636 Authored-by: M. Oleske Test `42: SNITest.connectViaProxyTest` requires docker running on your machine, otherwise it fails. This means docker should be mentioned as a required install now

[GitHub] [geode-native] moleske commented on pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

2020-08-19 Thread GitBox
moleske commented on pull request #625: URL: https://github.com/apache/geode-native/pull/625#issuecomment-676864451 @pdxcodemonkey still no rush, but I had to resolve a conflict `cppcache/integration/framework/TestConfig.cpp.in`. I'd like to merge this is in sooner rather than later.

[GitHub] [geode-native] pdxcodemonkey commented on pull request #573: GEODE-7697: OpenSSL 1.1.0 minimum required, removed openssl-compat

2020-08-19 Thread GitBox
pdxcodemonkey commented on pull request #573: URL: https://github.com/apache/geode-native/pull/573#issuecomment-676854328 We've merged the SSL code into the client proper, so this is no longer relevant. This is an automated

[GitHub] [geode-native] pdxcodemonkey closed pull request #573: GEODE-7697: OpenSSL 1.1.0 minimum required, removed openssl-compat

2020-08-19 Thread GitBox
pdxcodemonkey closed pull request #573: URL: https://github.com/apache/geode-native/pull/573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473447837 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,27 @@ public

[GitHub] [geode-native] pdxcodemonkey merged pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pdxcodemonkey merged pull request #634: URL: https://github.com/apache/geode-native/pull/634 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473389534 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473389112 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public

[GitHub] [geode] bschuchardt merged pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-19 Thread GitBox
bschuchardt merged pull request #5465: URL: https://github.com/apache/geode/pull/5465 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] lgtm-com[bot] commented on pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

2020-08-19 Thread GitBox
lgtm-com[bot] commented on pull request #5363: URL: https://github.com/apache/geode/pull/5363#issuecomment-676750568 This pull request **introduces 1 alert** and **fixes 1** when merging 51c68d95ffdb37432b184926b97bf666be9638b0 into 6f12a360d82f0de9259557af2bca34cd84e4b5f4 - [view on

[GitHub] [geode-native] echobravopapa commented on pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
echobravopapa commented on pull request #634: URL: https://github.com/apache/geode-native/pull/634#issuecomment-676737699 @pivotal-jbarrett latest mergable is up... This is an automated message from the Apache Git Service.

[GitHub] [geode] BenjaminPerryRoss merged pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-19 Thread GitBox
BenjaminPerryRoss merged pull request #5391: URL: https://github.com/apache/geode/pull/5391 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473346910 ## File path: cppcache/src/TcpSslConn.hpp ## @@ -67,14 +81,18 @@ class TcpSslConn : public TcpConn { const char* privkeyfile,

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473293806 ## File path: cppcache/src/TcpSslConn.cpp ## @@ -87,15 +97,13 @@ void TcpSslConn::connect() { ACE_OS::signal(SIGPIPE, SIG_IGN); // Ignore

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473251486 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode-native] moleske commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
moleske commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473247270 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473244538 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
pivotal-jbarrett edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode-native] pivotal-jbarrett edited a comment on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
pivotal-jbarrett edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
pivotal-jbarrett commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676592891 > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: >

[GitHub] [geode-native] pdxcodemonkey commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
pdxcodemonkey commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676558659 I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument:

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473195346 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public ResultModel

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473194273 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-19 Thread GitBox
bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473192044 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -120,28 +117,14 @@ public void

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-19 Thread GitBox
bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r473192044 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -120,28 +117,14 @@ public void

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473191623 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -197,6 +201,32 @@ public

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473190161 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode] gesterzhou merged pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-19 Thread GitBox
gesterzhou merged pull request #5464: URL: https://github.com/apache/geode/pull/5464 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473186241 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

<    1   2   3   4   5   6   7   8   9   10   >