[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] alb3rtobr commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
alb3rtobr commented on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-676479642 Hi @pdxcodemonkey , @pivotal-jbarrett , @moleske . I have not been able to create a test case that fails every time it is executed. Without the fix, the test case I have

[GitHub] [geode] jinmeiliao commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-19 Thread GitBox
jinmeiliao commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r473085253 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -168,26 +168,30 @@ public

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473081067 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^ host,

[GitHub] [geode-native] alb3rtobr opened a new pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

2020-08-19 Thread GitBox
alb3rtobr opened a new pull request #635: URL: https://github.com/apache/geode-native/pull/635 A segmentation fault is produced when `PdxInstanceFactory::create()` is called by several threads that are registering the same new pdx type. The core is produced here: ``` void

[GitHub] [geode] jujoramos commented on a change in pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-19 Thread GitBox
jujoramos commented on a change in pull request #5175: URL: https://github.com/apache/geode/pull/5175#discussion_r472873883 ## File path: geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/OfflineDiskStoreCommandsDUnitTest.java ## @@ -0,0

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-18 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675809133 This pull request **introduces 2 alerts** and **fixes 2** when merging a0fc2c1fbd591e060860cd2f0dbb442e53856cc0 into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-18 Thread GitBox
onichols-pivotal commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r472588532 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ConnectCommand.java ## @@ -186,6 +186,16 @@ public

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-18 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675785863 This pull request **introduces 2 alerts** and **fixes 2** when merging e553fab12c998b87ddd863a361ac9e9ca689e2ba into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472543514 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +106,65 @@ private void

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-18 Thread GitBox
bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472539017 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void

[GitHub] [geode] bschuchardt commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-18 Thread GitBox
bschuchardt commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472538826 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-18 Thread GitBox
gesterzhou commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472530187 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public

[GitHub] [geode] gesterzhou commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-18 Thread GitBox
gesterzhou commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472529105 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472527125 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472525063 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472524195 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-18 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-675747104 This pull request **introduces 2 alerts** and **fixes 2** when merging ea366f928d469226b75789a0da8427d02a2a0fbd into be9a2329d1e06f1ae67baaaf875b6ff20b2922cf - [view on

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5465: URL: https://github.com/apache/geode/pull/5465#discussion_r472521802 ## File path: geode-core/src/test/java/org/apache/geode/internal/net/SocketCreatorJUnitTest.java ## @@ -98,6 +102,30 @@ private void

[GitHub] [geode] pivotal-eshu commented on a change in pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-18 Thread GitBox
pivotal-eshu commented on a change in pull request #5464: URL: https://github.com/apache/geode/pull/5464#discussion_r472499344 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,19 @@ public

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472483145 ## File path: cppcache/include/geode/PoolFactory.hpp ## @@ -426,6 +426,11 @@ class APACHE_GEODE_EXPORT PoolFactory { */ PoolFactory&

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472483043 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^ host,

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472481911 ## File path: cppcache/src/ThinClientLocatorHelper.hpp ## @@ -71,6 +74,8 @@ class ThinClientLocatorHelper { const ThinClientPoolDM* m_poolDM;

[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pdxcodemonkey commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472481270 ## File path: cppcache/src/PoolAttributes.cpp ## @@ -44,46 +44,13 @@ PoolAttributes::PoolAttributes()

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472480996 ## File path: cppcache/integration/test/sni-test-config/geode-config/truststore_sni.pem ## @@ -0,0 +1,68 @@ +-BEGIN CERTIFICATE-

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472480140 ## File path: sni-test-config/docker-compose.yml ## @@ -0,0 +1,43 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one or more +#

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472479203 ## File path: cppcache/integration/test/SNITest.cpp ## @@ -108,41 +112,51 @@ class SNITest : public ::testing::Test { } std::string

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472473631 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [geode-native] echobravopapa commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
echobravopapa commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472472720 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [geode] smgoller merged pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-18 Thread GitBox
smgoller merged pull request #5458: URL: https://github.com/apache/geode/pull/5458 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] bschuchardt opened a new pull request #5465: GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

2020-08-18 Thread GitBox
bschuchardt opened a new pull request #5465: URL: https://github.com/apache/geode/pull/5465 Configure cipher suites when creating an SSLEngine Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure

[GitHub] [geode] gesterzhou opened a new pull request #5464: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-18 Thread GitBox
gesterzhou opened a new pull request #5464: URL: https://github.com/apache/geode/pull/5464 …nt into parallelGatewaySenderQueue Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [geode] Bill commented on a change in pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-18 Thread GitBox
Bill commented on a change in pull request #5462: URL: https://github.com/apache/geode/pull/5462#discussion_r472360083 ## File path: geode-gfsh/src/test/java/org/apache/geode/management/internal/cli/commands/ConnectCommandTest.java ## @@ -417,4 +417,21 @@ public void

[GitHub] [geode] kirklund merged pull request #5451: GEODE-8425: Add new handling netsearch statistics

2020-08-18 Thread GitBox
kirklund merged pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jujoramos opened a new pull request #5463: [WIP]: GEM-2931

2020-08-18 Thread GitBox
jujoramos opened a new pull request #5463: URL: https://github.com/apache/geode/pull/5463 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode-native] mkevo merged pull request #629: GEODE-8364: Change log level at runtime

2020-08-18 Thread GitBox
mkevo merged pull request #629: URL: https://github.com/apache/geode-native/pull/629 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] mkevo merged pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-18 Thread GitBox
mkevo merged pull request #628: URL: https://github.com/apache/geode-native/pull/628 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-18 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-675311553 thanks for the reviews! Sorry but I need someone to merge the PR because Im not a committer This is an

[GitHub] [geode] onichols-pivotal opened a new pull request #5462: GEODE-8435: restore ability to connect gfsh by serialization version

2020-08-17 Thread GitBox
onichols-pivotal opened a new pull request #5462: URL: https://github.com/apache/geode/pull/5462 This used to work but was broken recently by changes to rely exclusively on product version. Although Geode releases were never impacted, loss of this feature causes quite a headache

[GitHub] [geode] onichols-pivotal merged pull request #5461: Revert "GEODE-8432: use regionPath directly instead of getRegion when…

2020-08-17 Thread GitBox
onichols-pivotal merged pull request #5461: URL: https://github.com/apache/geode/pull/5461 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] gesterzhou opened a new pull request #5461: Revert "GEODE-8432: use regionPath directly instead of getRegion when…

2020-08-17 Thread GitBox
gesterzhou opened a new pull request #5461: URL: https://github.com/apache/geode/pull/5461 … put eve… (#5459)" This reverts commit 8021084e4fdb4e03ef8495a190cc1618a6db67ba. Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-17 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r471800583 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-17 Thread GitBox
onichols-pivotal commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471786376 ## File path: ci/images/google-geode-builder/scripts/setup.sh ## @@ -57,7 +59,9 @@ DEBIAN_FRONTEND=noninteractive apt-get install -y

[GitHub] [geode] pivotal-jbarrett commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-17 Thread GitBox
pivotal-jbarrett commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471726677 ## File path: ci/images/test-container/Dockerfile ## @@ -48,6 +50,10 @@ RUN apt-get update \ && apt-get install -y --no-install-recommends \

[GitHub] [geode-native] mmartell opened a new pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-17 Thread GitBox
mmartell opened a new pull request #634: URL: https://github.com/apache/geode-native/pull/634 This adds a new .NET API to the nativeclient to support SNI. Notes: - This ticket usurps GEODE-8156. Since we need the new SetSniProxy API to run the test, we'll use this GEODE-8398

[GitHub] [geode-native] pdxcodemonkey merged pull request #632: GEODE-8426: Enforce warning no-shorten-64-to-32

2020-08-17 Thread GitBox
pdxcodemonkey merged pull request #632: URL: https://github.com/apache/geode-native/pull/632 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] mivanac opened a new pull request #5460: GEODE-8433: added inheritance of off-heap attribute

2020-08-17 Thread GitBox
mivanac opened a new pull request #5460: URL: https://github.com/apache/geode/pull/5460 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode-native] alb3rtobr commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-17 Thread GitBox
alb3rtobr commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-674947497 Hi @moleske @echobravopapa @pivotal-jbarrett , is there anything else missing to approve this PR? This

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-17 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-674786552 > Hello @mkevo , > > I've manually copied and executed the test `OfflineDiskStoreCommandsDUnitTest.testThreadHangWithOfflineDiskStoreCommands()` locally on the current

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-15 Thread GitBox
onichols-pivotal commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471061022 ## File path: ci/scripts/execute_tests.sh ## @@ -69,13 +69,17 @@ fi case $ARTIFACT_SLUG in windows*) +echo "Making environment

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-15 Thread GitBox
onichols-pivotal commented on a change in pull request #5458: URL: https://github.com/apache/geode/pull/5458#discussion_r471060893 ## File path: ci/images/test-container/Dockerfile ## @@ -48,6 +50,10 @@ RUN apt-get update \ && apt-get install -y --no-install-recommends \

[GitHub] [geode] agingade commented on a change in pull request #5459: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-15 Thread GitBox
agingade commented on a change in pull request #5459: URL: https://github.com/apache/geode/pull/5459#discussion_r470953492 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderQueue.java ## @@ -693,15 +693,14 @@ public

[GitHub] [geode] gesterzhou merged pull request #5459: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-14 Thread GitBox
gesterzhou merged pull request #5459: URL: https://github.com/apache/geode/pull/5459 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] gesterzhou opened a new pull request #5459: GEODE-8432: use regionPath directly instead of getRegion when put eve…

2020-08-14 Thread GitBox
gesterzhou opened a new pull request #5459: URL: https://github.com/apache/geode/pull/5459 …nt into parallelGatewaySenderQueue Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following

[GitHub] [geode-native] pdxcodemonkey merged pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-14 Thread GitBox
pdxcodemonkey merged pull request #630: URL: https://github.com/apache/geode-native/pull/630 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] smgoller opened a new pull request #5458: GEODE-8321 - Use Liberica JDK for testing - Part 1.

2020-08-14 Thread GitBox
smgoller opened a new pull request #5458: URL: https://github.com/apache/geode/pull/5458 This commit adds the Liberica JDK to all testing images. It does not change any tests to use it yet. Authored-by: Sean Goller Thank you for submitting a contribution to Apache Geode.

[GitHub] [geode] gesterzhou merged pull request #5457: GEODE-8430: add dunit test to verify tombstoneGC will not happen in u…

2020-08-13 Thread GitBox
gesterzhou merged pull request #5457: URL: https://github.com/apache/geode/pull/5457 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] mhansonp commented on a change in pull request #5457: GEODE-8430: add dunit test to verify tombstoneGC will not happen in u…

2020-08-13 Thread GitBox
mhansonp commented on a change in pull request #5457: URL: https://github.com/apache/geode/pull/5457#discussion_r470329301 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java ## @@ -1552,6 +1552,95 @@ public String

[GitHub] [geode-native] davebarnes97 merged pull request #633: GEODE-8390: Geode Native Client guide - expose "Connection Pools" in nav

2020-08-13 Thread GitBox
davebarnes97 merged pull request #633: URL: https://github.com/apache/geode-native/pull/633 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] davebarnes97 commented on pull request #633: GEODE-8390: Geode Native Client guide - expose "Connection Pools" in nav

2020-08-13 Thread GitBox
davebarnes97 commented on pull request #633: URL: https://github.com/apache/geode-native/pull/633#issuecomment-673753257 > Can you please update the file connection-pools/running-connection-pool-code.html in the .NET version only to remove the C++ example? I see 2 examples. One is C++ and

[GitHub] [geode] dschneider-pivotal merged pull request #5446: GEODE-8427: fix flaky test and do not throw memberDeparted

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5446: URL: https://github.com/apache/geode/pull/5446 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode-native] davebarnes97 opened a new pull request #633: GEODE-8390: Geode Native Client guide - expose "Connection Pools" in nav

2020-08-13 Thread GitBox
davebarnes97 opened a new pull request #633: URL: https://github.com/apache/geode-native/pull/633 Updated left-hand nav in both .NET and C++ guides to include "Using Connection Pools" and its subtopics Made basic changes to text for language-specific books. Thorough update is the

[GitHub] [geode] dschneider-pivotal merged pull request #5455: GEODE-8428: Update geode-redis README

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5455: URL: https://github.com/apache/geode/pull/5455 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5456: GEODE-8379: Allow microseconds value to be zero

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5456: URL: https://github.com/apache/geode/pull/5456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] gesterzhou opened a new pull request #5457: GEODE-8430: add dunit test to verify tombstoneGC will not happen in u…

2020-08-13 Thread GitBox
gesterzhou opened a new pull request #5457: URL: https://github.com/apache/geode/pull/5457 …ninitialized region Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been

[GitHub] [geode] dschneider-pivotal merged pull request #5453: GEODE-8409: S*STORE need to handle target that is not a redis set

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5453: URL: https://github.com/apache/geode/pull/5453 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] ringles opened a new pull request #5456: GEODE-8379: Allow microseconds value to be zero

2020-08-13 Thread GitBox
ringles opened a new pull request #5456: URL: https://github.com/apache/geode/pull/5456 Fix flaky test, Redis "TIME" command microseconds value can be zero. This is an automated message from the Apache Git Service. To

[GitHub] [geode] sabbeyPivotal opened a new pull request #5455: GEODE-8424: Updates Redis API for Geode docs 1.14

2020-08-13 Thread GitBox
sabbeyPivotal opened a new pull request #5455: URL: https://github.com/apache/geode/pull/5455 The docs should be updated to describe the Redis API for the upcoming 1.14 release. This is an automated message from the Apache

[GitHub] [geode] demery-pivotal closed pull request #5439: DO NOT REVIEW Do not enable SO_REUSEADDR to bind an ephemeral port

2020-08-13 Thread GitBox
demery-pivotal closed pull request #5439: URL: https://github.com/apache/geode/pull/5439 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] demery-pivotal closed pull request #5425: DO NOT REVIEW: Use ephemeral port knocking to find and "reserve" free ports.

2020-08-13 Thread GitBox
demery-pivotal closed pull request #5425: URL: https://github.com/apache/geode/pull/5425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal merged pull request #5454: GEODE-8424: Updates Redis API for Geode docs 1.14

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5454: URL: https://github.com/apache/geode/pull/5454 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] dschneider-pivotal merged pull request #5450: GEODE-8428: Update geode-redis README

2020-08-13 Thread GitBox
dschneider-pivotal merged pull request #5450: URL: https://github.com/apache/geode/pull/5450 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] sabbeyPivotal opened a new pull request #5454: GEODE-8424: Updates Redis API for Geode docs 1.14

2020-08-13 Thread GitBox
sabbeyPivotal opened a new pull request #5454: URL: https://github.com/apache/geode/pull/5454 The docs should be updated to describe the Redis API for the upcoming 1.14 release. This is an automated message from the Apache

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5450: GEODE-8428: Update geode-redis README

2020-08-13 Thread GitBox
sabbeyPivotal commented on a change in pull request #5450: URL: https://github.com/apache/geode/pull/5450#discussion_r470075449 ## File path: geode-redis/README.md ## @@ -1,78 +1,302 @@ -# Geode Redis Module - -## Contents -1. [Overview](#overview) -2. [Performance Test

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5450: GEODE-8428: Update geode-redis README

2020-08-13 Thread GitBox
sabbeyPivotal commented on a change in pull request #5450: URL: https://github.com/apache/geode/pull/5450#discussion_r470075247 ## File path: geode-redis/README.md ## @@ -1,78 +1,302 @@ -# Geode Redis Module - -## Contents -1. [Overview](#overview) -2. [Performance Test

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5450: GEODE-8428: Update geode-redis README

2020-08-13 Thread GitBox
dschneider-pivotal commented on a change in pull request #5450: URL: https://github.com/apache/geode/pull/5450#discussion_r470051786 ## File path: geode-redis/README.md ## @@ -1,78 +1,302 @@ -# Geode Redis Module - -## Contents -1. [Overview](#overview) -2. [Performance Test

[GitHub] [geode] ringles opened a new pull request #5453: GEODE-8409: S*STORE need to handle target that is not a redis set

2020-08-13 Thread GitBox
ringles opened a new pull request #5453: URL: https://github.com/apache/geode/pull/5453 Restore tests for nonexistent keys against a Set data type. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] albertogpz opened a new pull request #5452: DRAFT: fix create region with gw-sender vs alter region --gw-sender d…

2020-08-13 Thread GitBox
albertogpz opened a new pull request #5452: URL: https://github.com/apache/geode/pull/5452 …ifference This is a draft PR to see if it fixes, without any undesired effect, the difference in behavior in Geode between creating a region with a gateway sender or creating a region

[GitHub] [geode] DonalEvans commented on a change in pull request #5391: GEODE-7846: Adding Stats for Partitioned Region Clear

2020-08-12 Thread GitBox
DonalEvans commented on a change in pull request #5391: URL: https://github.com/apache/geode/pull/5391#discussion_r469611803 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/PartitionedRegionClear.java ## @@ -378,8 +378,11 @@ void doClear(RegionEventImpl

[GitHub] [geode] Bill merged pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

2020-08-12 Thread GitBox
Bill merged pull request #5409: URL: https://github.com/apache/geode/pull/5409 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [geode] mhansonp merged pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp merged pull request #5447: URL: https://github.com/apache/geode/pull/5447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] jchen21 commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
jchen21 commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469584716 ## File path: geode-core/src/distributedTest/java/org/apache/geode/internal/cache/GIIDeltaDUnitTest.java ## @@ -497,7 +497,7 @@ public void run() {

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #134: Re-submit: allow other AMI purposes to be launched by benchmarks launch_cluster

2020-08-12 Thread GitBox
rhoughton-pivot opened a new pull request #134: URL: https://github.com/apache/geode-benchmarks/pull/134 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576684 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576129 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] kirklund commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-673128651 I don't have time for this PR. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] kirklund closed pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund closed pull request #5382: URL: https://github.com/apache/geode/pull/5382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] mhansonp closed pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp closed pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] kirklund opened a new pull request #5451: DRAFT: GEODE-8425: Add new handling netsearch statistics

2020-08-12 Thread GitBox
kirklund opened a new pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mhansonp commented on pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp commented on pull request #5448: URL: https://github.com/apache/geode/pull/5448#issuecomment-673128283 Unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554888 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554313 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] sabbeyPivotal opened a new pull request #5450: GEODE-8428: Update geode-redis README

2020-08-12 Thread GitBox
sabbeyPivotal opened a new pull request #5450: URL: https://github.com/apache/geode/pull/5450 Update geode-redis README with a short explanation of how to run a Geode server that accepts Redis commands. This is an automated

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469538956 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
onichols-pivotal commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469534578 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] DonalEvans commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
DonalEvans commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469471781 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode-native] moleske edited a comment on pull request #632: Enforce warning no-shorten-64-to-32

2020-08-12 Thread GitBox
moleske edited a comment on pull request #632: URL: https://github.com/apache/geode-native/pull/632#issuecomment-672965675 > Looks like it got fixed along the way! It's nice when that happens! Only wish I could give the right people credit!

[GitHub] [geode-benchmarks] rhoughton-pivot merged pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot merged pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot opened a new pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 Reverts apache/geode-benchmarks#132 This is an automated message from the Apache Git Service. To respond to the

<    2   3   4   5   6   7   8   9   10   11   >