[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576684 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] jinmeiliao commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-12 Thread GitBox
jinmeiliao commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r469576129 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] kirklund commented on pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund commented on pull request #5382: URL: https://github.com/apache/geode/pull/5382#issuecomment-673128651 I don't have time for this PR. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] kirklund closed pull request #5382: GEODE-8368: Upgrade ClassGraph from 4.8.52 to 4.8.87

2020-08-12 Thread GitBox
kirklund closed pull request #5382: URL: https://github.com/apache/geode/pull/5382 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] mhansonp closed pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp closed pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] kirklund opened a new pull request #5451: DRAFT: GEODE-8425: Add new handling netsearch statistics

2020-08-12 Thread GitBox
kirklund opened a new pull request #5451: URL: https://github.com/apache/geode/pull/5451 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mhansonp commented on pull request #5448: Changes to help reduce the occurence of GEODE-8422 for support 1.13

2020-08-12 Thread GitBox
mhansonp commented on pull request #5448: URL: https://github.com/apache/geode/pull/5448#issuecomment-673128283 Unnecessary. This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554888 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469554313 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] sabbeyPivotal opened a new pull request #5450: GEODE-8428: Update geode-redis README

2020-08-12 Thread GitBox
sabbeyPivotal opened a new pull request #5450: URL: https://github.com/apache/geode/pull/5450 Update geode-redis README with a short explanation of how to run a Geode server that accepts Redis commands. This is an automated

[GitHub] [geode] mhansonp commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
mhansonp commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469538956 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] onichols-pivotal commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
onichols-pivotal commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469534578 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode] DonalEvans commented on a change in pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-12 Thread GitBox
DonalEvans commented on a change in pull request #5447: URL: https://github.com/apache/geode/pull/5447#discussion_r469471781 ## File path: geode-core/src/test/java/org/apache/geode/internal/cache/TombstoneServiceTest.java ## @@ -0,0 +1,79 @@ +package

[GitHub] [geode-native] moleske edited a comment on pull request #632: Enforce warning no-shorten-64-to-32

2020-08-12 Thread GitBox
moleske edited a comment on pull request #632: URL: https://github.com/apache/geode-native/pull/632#issuecomment-672965675 > Looks like it got fixed along the way! It's nice when that happens! Only wish I could give the right people credit!

[GitHub] [geode-benchmarks] rhoughton-pivot merged pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot merged pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #133: Revert "allow AMI picking with arbitrary username accounts"

2020-08-12 Thread GitBox
rhoughton-pivot opened a new pull request #133: URL: https://github.com/apache/geode-benchmarks/pull/133 Reverts apache/geode-benchmarks#132 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode-benchmarks] rhoughton-pivot merged pull request #132: allow AMI picking with arbitrary username accounts

2020-08-12 Thread GitBox
rhoughton-pivot merged pull request #132: URL: https://github.com/apache/geode-benchmarks/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [geode-native] moleske commented on pull request #632: Enforce warning no-shorten-64-to-32

2020-08-12 Thread GitBox
moleske commented on pull request #632: URL: https://github.com/apache/geode-native/pull/632#issuecomment-672965675 > Looks like it got fixed along the way! It's nice when that happens! Only wish I could give the right people credit!

[GitHub] [geode] dschneider-pivotal merged pull request #5449: GEODE-8423: Updates Redis API for Geode docs 1.13

2020-08-12 Thread GitBox
dschneider-pivotal merged pull request #5449: URL: https://github.com/apache/geode/pull/5449 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-12 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r469063060 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468997420 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode-native] codecov-commenter commented on pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-11 Thread GitBox
codecov-commenter commented on pull request #628: URL: https://github.com/apache/geode-native/pull/628#issuecomment-672466654 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/628?src=pr=h1) Report > Merging

[GitHub] [geode-native] codecov-commenter commented on pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-11 Thread GitBox
codecov-commenter commented on pull request #630: URL: https://github.com/apache/geode-native/pull/630#issuecomment-672466067 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/630?src=pr=h1) Report > Merging

[GitHub] [geode-native] moleske opened a new pull request #632: Remove compile option no-shorten-64-to-32

2020-08-11 Thread GitBox
moleske opened a new pull request #632: URL: https://github.com/apache/geode-native/pull/632 Authored-by: M. Oleske curious if this is needed since quick test on my machine was compiling (so figured I'd make travis check real quick)

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-11 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468909733 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode-benchmarks] rhoughton-pivot opened a new pull request #132: allow AMI picking with arbitrary username accounts

2020-08-11 Thread GitBox
rhoughton-pivot opened a new pull request #132: URL: https://github.com/apache/geode-benchmarks/pull/132 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-11 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468894539 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode] sabbeyPivotal opened a new pull request #5449: GEODE-8423: Updates Redis API for Geode docs 1.13

2020-08-11 Thread GitBox
sabbeyPivotal opened a new pull request #5449: URL: https://github.com/apache/geode/pull/5449 Documentation for Redis API for Geode that will currently be published for 1.13 are not accurate and need to be updated. This is

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468823814 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] lgtm-com[bot] commented on pull request #5363: GEODE-8349: Reintroduce use of SSLSocket in cluster communications

2020-08-11 Thread GitBox
lgtm-com[bot] commented on pull request #5363: URL: https://github.com/apache/geode/pull/5363#issuecomment-672209899 This pull request **introduces 1 alert** and **fixes 1** when merging 5b573099845881a70be91e7e3c037cdcc6b9779b into 21e26094e5178d5af1ef554448da943e07352469 - [view on

[GitHub] [geode] mhansonp opened a new pull request #5448: Changes to help reduce the occurence of GEODE-8422

2020-08-11 Thread GitBox
mhansonp opened a new pull request #5448: URL: https://github.com/apache/geode/pull/5448 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] jchen21 commented on a change in pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-11 Thread GitBox
jchen21 commented on a change in pull request #5436: URL: https://github.com/apache/geode/pull/5436#discussion_r468778063 ## File path: geode-core/src/distributedTest/java/org/apache/geode/cache/query/partitioned/PRClearQueryIndexDUnitTest.java ## @@ -0,0 +1,157 @@ +/* + *

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468768049 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] jinmeiliao commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
jinmeiliao commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468762702 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] mhansonp opened a new pull request #5447: Changes to help reduce the occurence of GEODE-8422

2020-08-11 Thread GitBox
mhansonp opened a new pull request #5447: URL: https://github.com/apache/geode/pull/5447 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468754561 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] jinmeiliao commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
jinmeiliao commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468747434 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] dschneider-pivotal opened a new pull request #5446: GEODE-8393: fix flaky test and do not throw memberDeparted

2020-08-11 Thread GitBox
dschneider-pivotal opened a new pull request #5446: URL: https://github.com/apache/geode/pull/5446 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ###

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468723671 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode] DonalEvans closed pull request #5443: GEODE-7864: Fix most "Statement has empty body" IDE warnings

2020-08-11 Thread GitBox
DonalEvans closed pull request #5443: URL: https://github.com/apache/geode/pull/5443 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] jinmeiliao commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-11 Thread GitBox
jinmeiliao commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468698308 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBean.java ## @@ -214,11 +214,6 @@ public boolean

[GitHub] [geode] gesterzhou commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r468695763 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/beans/GatewaySenderMBean.java ## @@ -214,11 +214,6 @@ public boolean

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468692943 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
dschneider-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468688937 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -138,6 +161,25 @@ public void

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5420: GEODE-8333: Second attempt to fix PUBSUB hang

2020-08-11 Thread GitBox
jdeppe-pivotal commented on a change in pull request #5420: URL: https://github.com/apache/geode/pull/5420#discussion_r468663923 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/netty/ExecutionHandlerContext.java ## @@ -59,17 +60,21 @@ public class

[GitHub] [geode] mivanac merged pull request #5444: GEODE-8172_1: additional check added

2020-08-11 Thread GitBox
mivanac merged pull request #5444: URL: https://github.com/apache/geode/pull/5444 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] mivanac opened a new pull request #5445: GEODE-8421: replace cleaning of region with destroy/create

2020-08-11 Thread GitBox
mivanac opened a new pull request #5445: URL: https://github.com/apache/geode/pull/5445 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] mivanac opened a new pull request #5444: GEODE-8172_1: additional check added

2020-08-11 Thread GitBox
mivanac opened a new pull request #5444: URL: https://github.com/apache/geode/pull/5444 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-11 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671872424 Hi @jujoramos, After adding some logs I saw that in `offlineCompact` method it not executes `dsi.close() ` as it fails before on `createForOffline` while loading files in

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468439613 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java ## @@ -110,6 +110,7 @@ private void

[GitHub] [geode] albertogpz commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
albertogpz commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468439052 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode-native] alb3rtobr commented on pull request #629: GEODE-8364: Change log level at runtime

2020-08-11 Thread GitBox
alb3rtobr commented on pull request #629: URL: https://github.com/apache/geode-native/pull/629#issuecomment-671786298 @pivotal-jbarrett could you please check if the changes are ok for you? Thanks This is an automated

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468348971 ## File path: geode-wan/src/distributedTest/java/org/apache/geode/internal/cache/wan/parallel/ParallelWANPropagationLoopBackDUnitTest.java ## @@ -433,6

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468347041 ## File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/serial/SerialGatewaySenderImpl.java ## @@ -111,6 +111,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346846 ## File path: geode-wan/src/main/java/org/apache/geode/internal/cache/wan/parallel/ParallelGatewaySenderImpl.java ## @@ -102,6 +102,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346597 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java ## @@ -43,13 +43,19 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-11 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468346597 ## File path: geode-core/src/main/java/org/apache/geode/internal/cache/xmlcache/ParallelAsyncEventQueueCreation.java ## @@ -43,13 +43,19 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-10 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468341846 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java ## @@ -193,6 +194,7 @@ public void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-10 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468341654 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/SerialAsyncEventQueueImpl.java ## @@ -117,6 +117,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-10 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468341257 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java ## @@ -110,6 +110,7 @@ private void

[GitHub] [geode] gesterzhou commented on a change in pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-10 Thread GitBox
gesterzhou commented on a change in pull request #5434: URL: https://github.com/apache/geode/pull/5434#discussion_r468341467 ## File path: geode-core/src/main/java/org/apache/geode/cache/asyncqueue/internal/ParallelAsyncEventQueueImpl.java ## @@ -139,6 +140,7 @@ public void

[GitHub] [geode] jdeppe-pivotal merged pull request #5441: GEODE-8417: Revert GEODE-8393

2020-08-10 Thread GitBox
jdeppe-pivotal merged pull request #5441: URL: https://github.com/apache/geode/pull/5441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] DonalEvans opened a new pull request #5443: GEODE-7864: Fix most "Statement has empty body" IDE warnings

2020-08-10 Thread GitBox
DonalEvans opened a new pull request #5443: URL: https://github.com/apache/geode/pull/5443 Authored-by: Donal Evans Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have

[GitHub] [geode] masaki-yamakawa opened a new pull request #5442: GEODE-8420: Throws SQLException when SQLException occurs in JdbcWriter

2020-08-10 Thread GitBox
masaki-yamakawa opened a new pull request #5442: URL: https://github.com/apache/geode/pull/5442 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] dschneider-pivotal opened a new pull request #5441: GEODE-8417: Revert GEODE-8393

2020-08-10 Thread GitBox
dschneider-pivotal opened a new pull request #5441: URL: https://github.com/apache/geode/pull/5441 The fix for GEODE-8393 seems to have caused both GEODE-8417 and GEODE-8418. This revert should fix those new issues. This reverts commit 0a91484b05f1caffa8cc3a59cc7fc38abe4376ed.

[GitHub] [geode] rhoughton-pivot merged pull request #5440: GEODE-8406: Make early-return immune to the Geode dir not existing

2020-08-10 Thread GitBox
rhoughton-pivot merged pull request #5440: URL: https://github.com/apache/geode/pull/5440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] Bill edited a comment on pull request #5409: GEODE-8337: Redo: Rename Version enum to KnownVersion; VersionOrdinal to Version

2020-08-10 Thread GitBox
Bill edited a comment on pull request #5409: URL: https://github.com/apache/geode/pull/5409#issuecomment-667208641 sorry about the confusion @bschuchardt… I had to revert due to test failures in proprietary code. No changes were needed to this code, as it turns out. But it's taken

[GitHub] [geode] rhoughton-pivot opened a new pull request #5440: GEODE-8406: Make early-return immune to the Geode dir not existing

2020-08-10 Thread GitBox
rhoughton-pivot opened a new pull request #5440: URL: https://github.com/apache/geode/pull/5440 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For

[GitHub] [geode] karensmolermiller merged pull request #5437: GEODE-8410: remove offensive language from docs

2020-08-10 Thread GitBox
karensmolermiller merged pull request #5437: URL: https://github.com/apache/geode/pull/5437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] demery-pivotal opened a new pull request #5439: DO NOT REVIEW Do not enable SO_REUSEADDR to bind an ephemeral port

2020-08-10 Thread GitBox
demery-pivotal opened a new pull request #5439: URL: https://github.com/apache/geode/pull/5439 Do not enable `SO_REUSEADDR` when binding a socket to an ephemeral port. On some operating systems, enabling `SO_REUSEADDR` when binding to an ephemeral port allows the system to chose a

[GitHub] [geode] rhoughton-pivot merged pull request #5438: GEODE-8416: Add more Redis tests files to pipeline

2020-08-10 Thread GitBox
rhoughton-pivot merged pull request #5438: URL: https://github.com/apache/geode/pull/5438 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] sabbeyPivotal removed a comment on pull request #5438: GEODE-8416: Add more Redis tests files to pipeline

2020-08-10 Thread GitBox
sabbeyPivotal removed a comment on pull request #5438: URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159 @smgoller @rhoughton-pivot @onichols-pivotal @dickcav This is an automated message from the Apache

[GitHub] [geode] sabbeyPivotal commented on pull request #5438: GEODE-8416: Add more Redis tests files to pipeline

2020-08-10 Thread GitBox
sabbeyPivotal commented on pull request #5438: URL: https://github.com/apache/geode/pull/5438#issuecomment-671573159 @smgoller @rhoughton-pivot @onichols-pivotal @dickcav This is an automated message from the Apache Git

[GitHub] [geode] sabbeyPivotal opened a new pull request #5438: GEODE-8416: Add more Redis tests files to pipeline

2020-08-10 Thread GitBox
sabbeyPivotal opened a new pull request #5438: URL: https://github.com/apache/geode/pull/5438 Include more .tcl files in the Redis Tests CI job This is an automated message from the Apache Git Service. To respond to the

[GitHub] [geode] jdeppe-pivotal merged pull request #5431: GEODE-8393: change memberDeparted to disconnect the connection

2020-08-10 Thread GitBox
jdeppe-pivotal merged pull request #5431: URL: https://github.com/apache/geode/pull/5431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] dschneider-pivotal merged pull request #5429: GEODE-8409: S*STORE need to handle target that is not a redis set

2020-08-10 Thread GitBox
dschneider-pivotal merged pull request #5429: URL: https://github.com/apache/geode/pull/5429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [geode] lgtm-com[bot] commented on pull request #5390: ClassLoader isolation

2020-08-10 Thread GitBox
lgtm-com[bot] commented on pull request #5390: URL: https://github.com/apache/geode/pull/5390#issuecomment-671500760 This pull request **introduces 2 alerts** and **fixes 2** when merging c572e6dcb5ab2f73dd069eb697442ddb96906876 into 6a08bba48a92db682a3443b9ce47b44796cb4ab1 - [view on

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-10 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467116996 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

[GitHub] [geode] karensmolermiller opened a new pull request #5437: GEODE-8410: remove offensive language from docs

2020-08-10 Thread GitBox
karensmolermiller opened a new pull request #5437: URL: https://github.com/apache/geode/pull/5437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671321433 The `DescribeOfflineDiskStoreCommand` class calls `DiskStoreImpl.dumpInfo()`, which has an instance of the `DiskStoreImpl` class, it can be used directly to call `close()`, see

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671311587 > Sure, can you point me exactly to which commands you're referring here?. The original ticket ([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't mention

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671309686 Sure, can you point me exactly to which commands you're referring here?. The original ticket ([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't mention

[GitHub] [geode] mkevo commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-10 Thread GitBox
mkevo commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671299214 > @mkevo > Thanks for adding the extra tests. I'm not fully convinced about the implemented fix, however, did you consider my comments

[GitHub] [geode] jivthesh commented on pull request #5430: added code of conduct to project

2020-08-09 Thread GitBox
jivthesh commented on pull request #5430: URL: https://github.com/apache/geode/pull/5430#issuecomment-671079579 @metatype should i wnat to make any changes This is an automated message from the Apache Git Service. To

[GitHub] [geode] jivthesh commented on pull request #5430: added code of conduct to project

2020-08-07 Thread GitBox
jivthesh commented on pull request #5430: URL: https://github.com/apache/geode/pull/5430#issuecomment-670828286 @metatype okay This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [geode] jinmeiliao opened a new pull request #5436: GEODE-7672: add dunit test to verify OQL index after PR clear.

2020-08-07 Thread GitBox
jinmeiliao opened a new pull request #5436: URL: https://github.com/apache/geode/pull/5436 * allow ClusterStartupRule to launch dunit default locator This is an automated message from the Apache Git Service. To respond to

[GitHub] [geode-native] moleske commented on a change in pull request #628: GEODE-8344: Add GatewaySenderEventCallbackArgument class

2020-08-07 Thread GitBox
moleske commented on a change in pull request #628: URL: https://github.com/apache/geode-native/pull/628#discussion_r467228776 ## File path: cppcache/integration/test/Order.cpp ## @@ -0,0 +1,60 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

[GitHub] [geode-native] moleske commented on a change in pull request #625: GEODE-8340: Enforce Switch compiler warnings as errors

2020-08-07 Thread GitBox
moleske commented on a change in pull request #625: URL: https://github.com/apache/geode-native/pull/625#discussion_r467223869 ## File path: cppcache/src/ExceptionTypes.cpp ## @@ -297,7 +297,25 @@ const std::string& getThreadLocalExceptionMessage();

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

2020-08-07 Thread GitBox
jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-670655764 @mkevo Thanks for adding the extra tests. I'm not fully convinced about the implemented fix, however, did you consider my comments

[GitHub] [geode] bschuchardt closed pull request #5433: Revert "GEODE-8407: MergeLogFiles fails to include files with the sam…

2020-08-07 Thread GitBox
bschuchardt closed pull request #5433: URL: https://github.com/apache/geode/pull/5433 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt merged pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt merged pull request #5435: URL: https://github.com/apache/geode/pull/5435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] bschuchardt commented on pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt commented on pull request #5435: URL: https://github.com/apache/geode/pull/5435#issuecomment-670643196 Since this is a test-only change and the checks that use that test have passed I'm merging this PR before all of the non-required checks have finished.

[GitHub] [geode] bschuchardt opened a new pull request #5435: GEODE-8413: CI failure: MergeLogFilesIntegrationTest.testDircountZero fails on Windows

2020-08-07 Thread GitBox
bschuchardt opened a new pull request #5435: URL: https://github.com/apache/geode/pull/5435 Fixing directory path formation problem for Windows. I've tested these changes on a Mac and on a Windows machine. Thank you for submitting a contribution to Apache Geode. In order

[GitHub] [geode] DonalEvans merged pull request #5418: GEODE-8396: Fixing NullPointerException in create jdbc-mapping command

2020-08-07 Thread GitBox
DonalEvans merged pull request #5418: URL: https://github.com/apache/geode/pull/5418 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [geode] albertogpz opened a new pull request #5434: DRAFT: Solution to not queue forever dropped events with 2 timeouts

2020-08-07 Thread GitBox
albertogpz opened a new pull request #5434: URL: https://github.com/apache/geode/pull/5434 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all

[GitHub] [geode] agingade merged pull request #5424: GEODE-8394: Rewind the message Part on command failure

2020-08-07 Thread GitBox
agingade merged pull request #5424: URL: https://github.com/apache/geode/pull/5424 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] bschuchardt opened a new pull request #5433: Revert "GEODE-8407: MergeLogFiles fails to include files with the sam…

2020-08-07 Thread GitBox
bschuchardt opened a new pull request #5433: URL: https://github.com/apache/geode/pull/5433 …e name b… (#5428)" This reverts commit d6c3b1f20a55c5d867f162a338910d5df7d47de5. The new test fails consistently on Windows. Thank you for submitting a contribution to Apache Geode.

[GitHub] [geode] rhoughton-pivot merged pull request #5427: GEODE-8406: Enable early-return in CI scripts for CI-only changes

2020-08-07 Thread GitBox
rhoughton-pivot merged pull request #5427: URL: https://github.com/apache/geode/pull/5427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [geode] mivanac merged pull request #5432: GEODE-8191_1: test updated, added bucket initialization after creatio…

2020-08-07 Thread GitBox
mivanac merged pull request #5432: URL: https://github.com/apache/geode/pull/5432 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [geode] albertogpz commented on a change in pull request #5348: DRAFT: Add flag in gateway sender to not store dropped events while stopped …

2020-08-07 Thread GitBox
albertogpz commented on a change in pull request #5348: URL: https://github.com/apache/geode/pull/5348#discussion_r467116996 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/functions/GatewaySenderManageFunction.java ## @@ -0,0 +1,148

<    3   4   5   6   7   8   9   10   11   12   >