@kirklund you are right, the ticket does not consider other categories other
than integration/distributed tests. Will close this.
[ Full content available at: https://github.com/apache/geode/pull/2465 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Adding ConnectionAttempts=60 to all concourse scripts that are using
ssh. We are seeing jobs occasionally fail with connection refused. If
this is a transient issue, this change might fix it.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contrib
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2465 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I ran the clang-format tool in CLion, apparently it didn't do everything "our"
way, go figure.
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
If the file has a majority in one direction the formatting rule puts them all
to the majority direction. When starting a new file you should prefer right. I
suggest updating your formatting rules in CLion to auto format right and then
clang format will keep the file in line.
[ Full content avai
Renamed all instances `poolFactory`
[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
- Adding a pattern to match which is the bugfix
- Duplication reduction for readability
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a J
@WireBaron @balesh2 @galen-pivotal @upthewaterspout @pdxrunner @kirklund Could
you review this bug fix?
[ Full content available at: https://github.com/apache/geode/pull/2470 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* turning on assertion in classloader would not play nicely in jdk9 and later.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticke
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Change here for bugfix
[ Full content available at: https://github.com/apache/geode/pull/2470 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Change here for bugfix
[ Full content available at: https://github.com/apache/geode/pull/2470 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Please add alphabetically
[ Full content available at: https://github.com/apache/geode/pull/2469 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Please keep these in alphabetical order.
[ Full content available at: https://github.com/apache/geode/pull/2469 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2468 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2471 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2472 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
would be good to explain the reason of switching the order of these two lines
here, because I am wondering too.
[ Full content available at: https://github.com/apache/geode/pull/2426 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think the old code is trying to turn all exception type into
GemfireRestException with different messages. If we delete this block, we lose
that purpose.
[ Full content available at: https://github.com/apache/geode/pull/2426 ]
This message was relayed via gitbox.apache.org for
notifications@g
why do we have to make a distinction for GemfireRestException here? Would be
nice to put a comment here explaining this.
[ Full content available at: https://github.com/apache/geode/pull/2426 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2469 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
There seems to be some delay with the registering of interest. I'm not fond of
this wait, but there isn't a better way I saw. Nothing to check for that would
provide good feedback. I am open to suggestions.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was
This goes together with `convertErrorAsJson`. The other exceptions, in this
block, are very specific and the wrapping `GemFireRestException` can thus be
specific and meaningful. (Bear in mind that the exception will ultimately be
turned into json by `convertErrorAsJson` and returned to the user)
This is a magic timeout. Remove it and things fail. Add it in and things are
happy. I have no idea what this is really affecting, but it is necessary to
work properly.
[ Full content available at: https://github.com/apache/geode/pull/2463 ]
This message was relayed via gitbox.apache.org for
not
If we left this catch block then I think the exception should simply be
returned as:
```
throw new GemfireRestException(e.getMessage());
```
[ Full content available at: https://github.com/apache/geode/pull/2426 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
If we left this catch block then I think the exception should simply be
returned as:
```
throw new GemfireRestException(e.getMessage());
```
and that would also obviate the need for special handling in
`convertErrorAsJson`.
[ Full content available at: https://github.com/apache/geode/pull/2426
this code change is covered by analyzeDataSerializable test already.
this should not impact runs on jdk8, but the test was failing using jdk9 and
later without this fix.
Port the fix to develop to make sure this does not interfere with jdk8.
Thank you for submitting a contribution to Apache Geo
* Refactor gradle tasks generating .buildinfo
and GemFireVerion.properties files
* Treat .buildinfo as the source of truth for
those properties shared in GemFireVersion.properties
Co-authored-by: Patrick Rhomberg
Thank you for submitting a contribution to Apache Geode.
In order to streamline th
[ pull request closed by gesterzhou ]
[ Full content available at: https://github.com/apache/geode/pull/2458 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode/pull/2451 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Is this afterEvaluate really necessary too?
[ Full content available at: https://github.com/apache/geode/pull/2422 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2473 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
how about: throw new GemfireRestException(e.getMessage(), e);
[ Full content available at: https://github.com/apache/geode/pull/2426 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* javadoc task will fail if we include internal packages using java9 and later
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticke
* upgrade library to be java9 compatible to fix running tomcat7sessionJUnitTest
in java9
* fix InstallerJUnitTest
* fix DeprecatedAgentLauncherIntegrationTest (only include -d64 in
ProcessWrapper for Solaris machines)
* PowerMock needs to ignore more modules in PulseControllerJunitTest in java9
…in java9
* this fixes RestSecurityIntegrationTest
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR?
…ded in java9 and later
* this fix *launcher*IntegrationTests when running with java9
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JI
Does this mean that "-d64" is no longer a valid option for Mac or Linux?
[ Full content available at: https://github.com/apache/geode/pull/2476 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…amplerIntegrationTest needs to use production code to find the right
Statistics to use.
* this fixes testLocalStatListenerRegistration test
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps ha
…ilable, skip using the FileProcessController
* this would fix the issue that the
StatusServerExitCodeAcceptanceTest.statusWithWrongPid taking too long to exit.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure th
An in-flight operation may not be seen by the new GII requester if the GII
provider cache closes. This happens when there are more than one replica for
the region.
The change checks for cache close after replicating the data; if cache is
closed, throws exception back to the accessor/caller, whic
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Co-Authored-By: Bill Burcham
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in th
Tests using relative paths had depended on running as a user other than root.
The tests expected that file or directory creation would fail because the user
would not have permission to write to '/'.
A further problem was the several tests had hard-coded '/' in pathnames,
which is incompatible wit
Here is the important change for the primary problem. Elsewhere we cleaned up
and normalized most of the timeouts to 3 minutes each, and used Awaitility.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geod
[ pull request closed by mhansonp ]
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by jinmeiliao ]
[ Full content available at: https://github.com/apache/geode/pull/2475 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
t; > @@ -61,3 +61,7 @@ task zip(type: Zip) {
> }
>
> assemble.dependsOn 'zip'
> +
> +afterEvaluate {
>
> Is this afterEvaluate really necessary too?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it
This should say "1 or more". The big learning here was that it's not possible
to test for zero connected servers via the API (calling through the API in that
case results in the `NoSubscriptionServersAvailableException` exception).
[ Full content available at: https://github.com/apache/geode/pul
Should throw `IllegalArgumentException` if `connectedServers < 1` or
`redundantServers < 0`
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Can’t wait to take time to review this. Why can’t we have fully autonomous cars
already!!
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Now that the C++ doesn’t lookup this type anymore can’t we just used GetType on
Object?
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Formatting? Looks like tabs?
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think this function is unused
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Some missed commented code
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Indeed we can. Good catch.
Done.
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What was wrong with 42? ;)
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/351 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/352 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Good catch Michael.
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Nice catch.
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2244 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by PurelyApplied ]
[ Full content available at: https://github.com/apache/geode/pull/2466 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
2 spaces
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
2 spaces
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think `PdxType` can go away. It isn't really a `DSCode`.
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
`std::type_info` not "type name"
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This should be refactored out. It is not really a primitive type, it just
pretends to be one. Give it the same treatment we did for `PdxTypeHandler` and
`DataSerializableHandler`. In fact rename `PdxTypeHander` to
`PdxSerializableHandler`, the current name is confusing with `PdxType`, which
is
I like 7.
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think we can get rid of this option for all the platforms. This is from java9
documentation:
-d32
This option is deprecated and will be removed in a future release.
-d64
This option is deprecated and will be removed in a future release.
Oracle Solaris, Linux, and OS X: Runs the application in
Do we have a lot of unused member functions in the test code? What's the
extent of this problem? I'd hate to disable this warning if we don't have to...
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notificatio
Namespace with no name again
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Should we be consistent with the test namespace? I'm not certain there's a
significant reason to have both apache::geode::testing and
apache::geode::client::testing. Seems to me the one including client is the
right way to go, since we're not supposed to be testing geode itself.
[ Full conten
No-name namespace again. Looks like there are more of these, I'm gonna stop
flagging them here.
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Pls remove commented code here and below
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Probably don't need this comment
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Would `= default` work here?
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
... and again
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I'm not familiar with this construct. An anonymous namespace? Was this
intentional?
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Pls remove commented code
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
These comments add no value, let's get rid of em
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxrunner ]
[ Full content available at: https://github.com/apache/geode/pull/2483 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It's still used by `DistributedSystem::AppDomainInstanceInitialization` and
`TcrMessage`. Will address in separate ticket:
https://issues.apache.org/jira/browse/GEODE-5743
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.or
Yes! There are several headers that are included that implement lots of methods
that are never used in some units. If these were compiled separately as a
library the issue would go away but that is way beyond the point of this change
right now. The goal is to get the production code clear. So f
Probably
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Yup! Its a technique to isolate otherwise global namespace `using` or type
definitions to the current compilation unit.
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Yup!
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
They don't but this was an auto format change.
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
These comments are logging statements that get uncommented when there is a
problem with this tests. Given this isn't production code and to be deprecated
tests that I am not going to touch logging comments.
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This messa
Will address in separate ticket:
https://issues.apache.org/jira/browse/GEODE-5743
[ Full content available at: https://github.com/apache/geode-native/pull/354 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
These comments are logging statements that get uncommented when there is a
problem with this tests. Given this isn't production code and to be deprecated
tests that I am not going to touch logging comments. This would be a months
long effort to get rid of this behavior in all the tests.
[ Full
[ pull request closed by agingade ]
[ Full content available at: https://github.com/apache/geode/pull/2481 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
commit messages fixed
[ Full content available at: https://github.com/apache/geode/pull/2480 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2462 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode/pull/2422 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Sure be nice to get rid of these Helper classes...
[ Full content available at: https://github.com/apache/geode-native/pull/353 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
101 - 200 of 9074 matches
Mail list logo
