As an extension developer, gradle's `rootProject` may not refer
to the Geode root project, depending on the extension's structure.
Co-authored-by: Robert Houghton
Co-authored-by: Patrick Rhomberg
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the
- use consistent variable name for transaction manager object
- Boolean -> boolean in function example
- move boolean success to be after commit, so that an exception
upon commit does not report success when a subsequent attempt
does not have sufficent quantity
- get the cache from the context
[
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I agree with reviewer @mmartell - this directory change is really a workaround
for an issue with bookbinder. As such, it's an imperfect and temporary solution.
I will withdraw this PR in favor of a more lasting fix to the tool itself.
[ Full content available at: https://github.com/apache/geode-n
[ pull request closed by davebarnes97 ]
[ Full content available at: https://github.com/apache/geode-native/pull/356 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
A one second timeout seems really small? Does this mean the test will fail if
it takes longer than 1 second? We should probably change this to at least one
minute, or remove it.
[ Full content available at: https://github.com/apache/geode/pull/2492 ]
This message was relayed via gitbox.apache.or
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/358 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@galen-pivotal I switched to using sout in NetSearchMessagingDUnitTest as per
your suggestion
[ Full content available at: https://github.com/apache/geode/pull/2461 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It's not clear to me how a developer is supposed to maintain these lists going
forward. Now if I touch any of these classes I have to run this test with two
different versions of Java? Since this test seems to be here to fail whenever
the developer changes one of these methods, maybe we should j
After removing the nexus plugin, we no longer use uploadArchive as the
method of publishing. Replace the 'archive' configuration with the
proper publication of these artifacts
Co-authored-by: Robert Houghton
Co-authored-by: Patrick Rhomberg
Thank you for submitting a contribution to Apache Geod
[ pull request closed by karensmolermiller ]
[ Full content available at: https://github.com/apache/geode/pull/2498 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We observed that several tests in AlterRuntimeCommandDUnitTest class
were taking minutes when they should be taking a few seconds at most.
After some debugging, we determined that the JVM itself is struggling to
deal with having 100K+ classes loaded. They are loaded because the test
is repeated sta
@dhemery
[ Full content available at: https://github.com/apache/geode/pull/2500 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* Hold write lock when cleanUpAfterFailedGII.
* Hold read lock when cache operation is performed on the farside if region is
not yet initialized.
* Also hold read lock when transaction is performed on the farside if region
not initialized yet.
[ Full content available at: https://github.com/
Exactly this use. Glad you asked
[ Full content available at: https://github.com/apache/geode/pull/2492 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
- Remove problematic clang-format options
- Anonymize unused parameters
- Remove unnecessary type cast
[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think a more complete refactor for this `metadataEqualTo` is in order... look
at the call site of this method and let's think about if `DataSerializables`
have meta data for comparison, maybe it all just gets removed...? and we'll
want a test to drive out the change in any case as there was n
a better name might be "failedInitialImageLock". We want to get away from
acronyms. And "clear" does not need to be in the name.
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
these changes should be in AbstractRegionMapPut to be shared with CommitPut
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
see other comments. I know you are adding calls every place we do
lockForCacheModification but I do wonder if this one is needed while
initializing. Better safe than sorry, but I was wondering if you know if
basicUpdateEntryVersion needed to be prevented during cleanup after a failed GII
[ Full
The order should be like this:
A
B
try/finally
B
A
You currently have:
A
B
try/finally
A
B
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
make "locked" final
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
declare locked on this line; make it final; give it its own try/finally
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It would be better for this code to be added to RegionMapCommitPut instead of
AbstractRegionMap.
In the RegionMapCommitPut is should be done following the pattern in that class
of a method that takes a Runnable.
For an example see:
org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhil
declare "locked" on this line instead of line 1345.
The finally block that does the unlock and the old releaseCacheModLock should
not be the outer one that it currently is. In the old code we would of called
releaseCacheModLock even if we did not call lockForCacheMod (if
waitForIndexInit threw a
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2499 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Implicitly +1 as a co-author, but I'd love someone else to give an "official"
checkmark.
[ Full content available at: https://github.com/apache/geode/pull/2497 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/355 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I think it boils down to what exactly this test is supposed to test. This PR is
to prompt the thinking of how we test data serialization. I admit this is just
a hack to make test pass.
[ Full content available at: https://github.com/apache/geode/pull/2491 ]
This message was relayed via gitbox.a
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2494 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The other `DataSerializable`* have metadata to compare. Rather than rewriting
the common bits of the comparison in each type we use this template class to do
the compare. At compile time this results in a no-op for the
`DataSerializableInternal`.
[ Full content available at: https://github.com/
Awesome. Thanks for fixing!
[ Full content available at: https://github.com/apache/geode/pull/2250 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by galen-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2250 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
- Also fix issue with CQ and AppDomains
[ Full content available at: https://github.com/apache/geode-native/pull/361 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
As far as I can tell, there is no geospatial support in Geode, although we have
created examples of geospatial queries, for example
https://issues.apache.org/jira/browse/GEODE-3907
[ Full content available at: https://github.com/apache/geode/pull/2210 ]
This message was relayed via gitbox.apache
Test waits for stats sampler to run _twice_ before reading
archive (file). Prevents reading before all stat changes arrive in file.
Co-authored-by: Ken Howe
Co-authored-by: Bill Burcham
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contributi
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2497 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I would delete all usage of pollInterval and then crank up the atMost to FIVE
MINUTES.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pdxrunner @mhansonp @upthewaterspout
[ Full content available at: https://github.com/apache/geode/pull/2502 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Since you're changing so much, I'll mention this as a good thing to also do.
Any time you see a test creating a new CacheServer and returning the
server.getPort(), delete the use of getRandomAvailablePort, change it to
setPort(0) and then return that port. It'll find a randomly available port on
I recommend deleting old author names from comments.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I typically remove all usage of deprecated code. You can change this to:
```java
cache = new CacheFactory(props).create();
```
And delete assertThat(cache).isNotNull(); because it cannot be null unless it
threw a Throwable.
[ Full content available at: https://github.com/apache/geode/pull/2482
I would delete all System.out.println statements.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
You might want to rename all var names.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
You might want to crank up the timeouts to FIVE MINUTES. I know it seems like a
lot, but many of our flaky tests are caused by overloaded CI machine that
results in some pauses in the test that surpass 1 or 2 minutes.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This
sometimes, I don't want the system to poll more frequently than specified.
Thats why I use pollInterval. Do you think that is a bad approach? I thought
the default was 100ms
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org f
done
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
done
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
In this case, it doesn't look like we need to have fair lock; as there are only
few write lock to be acquired, during failed clear. How about using
StoppableReentrantReadWriteLock which takes cancel criteria.
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message w
Is there a reason not to catch `IOException` more generally?
[ Full content available at: https://github.com/apache/geode/pull/2484 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxcodemonkey ]
[ Full content available at: https://github.com/apache/geode-native/pull/360 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2461 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
les of geospatial queries, for example
> https://issues.apache.org/jira/browse/GEODE-3907
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/geode/pull/2210#issuecomment-423621238>, or mute
>
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2500 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2484 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@upthewaterspout @kirklund I have reviewed Kirk's concerns and addressed them
I believe. The failure in Build was in an unrelated are of the code. Please
merge if you get the opportunity.
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via git
I agree with @upthewaterspout. If I wonder if there is a better way to notice
that serialization of a class has changed w/o needing to run tests on multiple
JVM's.
[ Full content available at: https://github.com/apache/geode/pull/2491 ]
This message was relayed via gitbox.apache.org for
notifi
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2492 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Co-authored-by Barry Oglesby
@boglesby @agingade
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? I
#x27;s.
>
> —
> You are receiving this because you are subscribed to this thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
[ Full content available at: https://github.com/apache/geode/pull/2491 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Do you have more than one cache??
[ Full content available at: https://github.com/apache/geode-native/pull/361 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxrunner ]
[ Full content available at: https://github.com/apache/geode/pull/2502 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Attempting to make handling of EOFException and SocketException consistent.
This exception handling and an Assert were the only differences between
readDataSerializable(DataInput) and readDataSerializableFixedID(DataInput), so
we refactored that and were able to delete the FixedID version of th
testReplicatedSerialAsyncEventQueueWithPersistenceEnabled_Restart()
starts a cache with an AsyncEventListener, pauses the gateway sender,
puts 1000 entries, stops and restarts the cache with a new listener, and
verifies that all 1000 entry events are delivered to the new listener.
When the other t
Allows these tests to be run in parallel.
[ Full content available at: https://github.com/apache/geode-native/pull/362 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
cob Barrett wrote:
>
> @pivotal-jbarrett approved this pull request.
>
> Where you able to identify the issue with the ssl test?
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub, or mute the thread.
[ Full
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/362 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Does it still hang even with the jmx port for shutdown too? Does the C++ use
jmx port to connect for shutdown?
[ Full content available at: https://github.com/apache/geode-native/pull/362 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
ou are receiving this because you modified the open/close state.
> Reply to this email directly, view it on GitHub, or mute the thread.
[ Full content available at: https://github.com/apache/geode-native/pull/362 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The internal class `DefaultHashMap` was designed as an internal
workaround to return a default value whenever the value returned by
`Map.get(K)` was `null`. Starting with Java 8 the `Map` interface
added the method `getOrDefault`, which does something similar in a more
efficient way but it returns
Requested change to client cache name has been made.
[ Full content available at: https://github.com/apache/geode-native/pull/361 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The call to equals() assumed that coordinator was non-null, but
coordinator may legitimately be null.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [
[ pull request closed by igodwin ]
[ Full content available at: https://github.com/apache/geode-native/pull/361 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This test was failing on windows with a unexpected
suspect string. The underlying problem is that an
input stream kept open and causes the deletion to
fail.
This fix also fixes:
* CreateRegionCommandDUnitTest
* DeployCommandRedeployDUnitTest
- hotDeployShouldNotResultInAnyFai
auto?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
auto?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
return !(m_caching == "false") - too cryptic?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Typo: tombstone-gc-threshold
Also on 1309.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Again, auto?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Should this go into develop?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Could add braces.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Why this type of cast?
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2482 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I would remove these two new blank lines and then AbstractRegionMapPut will no
longer be modified by this pull request
[ Full content available at: https://github.com/apache/geode/pull/2501 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
It would be nice if we could share this code by putting it in
AbstractRegionMapPut.
Here is how we could do it. Move the runWhileLockedForCacheModification you
have in RegionMapCommitPut to AbstractRegionMapPut. Then change this one to
just do the old cacheModLock but in the body do this:
super.
Pre-checkin DistributedTest failure on the pre-checkin is a known issue -
GEODE-5728 with open PR#2507
[ Full content available at: https://github.com/apache/geode/pull/2496 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2508 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pdxrunner ]
[ Full content available at: https://github.com/apache/geode/pull/2507 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2495 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
@PurelyApplied Can you review this PR and provide feedback?
[ Full content available at: https://github.com/apache/geode/pull/2509 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Most of this code was auto fixed using `clang-tidy -fix`. I suppose I can go
back and touch up all the fixed lines with cleaner C++.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Not my typo.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
There is another ticket for `clang-tidy` that addresses those.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I don't understand your question.
[ Full content available at: https://github.com/apache/geode-native/pull/359 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
rsync code to the build machine fails intermintently
on windows and so retrying for now until we find a
solution.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all c
301 - 400 of 9074 matches
Mail list logo
