[ Full content available at: https://github.com/apache/geode-native/pull/372 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Good point. I switched to using depency-versions.properties and now we are
using consistent versions of tomcat. Thanks!
[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
What exactly does this do? It looks like you've swapped around initialization
order and perhaps declaration order of a bunch of member variables in several
classes. I'm familiar with having to do this quite often to get rid of
compiler warnings when using gcc, but this is Clang and referring t
What this is doing is trying to avoid a lot of unnecessary padding that can
bloat the size of you objects in memory. The order is important because certain
types will have to pad out to fix the alignment types. For example, I can't
have an int that starts after a single boolean without padding o
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/372 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Merged with #372
[ Full content available at: https://github.com/apache/geode-native/pull/371 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
GEODE-5830: Fix `NONE` enum for SSL configuration
The `SecurableCommunicationChannel.NONE` enum instance now references
the correct constant string, `none`, instead of `NO_COMPONENT`.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution w
GEODE-5838: Fix warnings in javadocs generation
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is i
[ Full content available at: https://github.com/apache/geode-native/pull/373 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This is the last of the major clang-tidy fixes. Still working with Travis.ci to
get a functional clang-tidy build to enforce these rules.
[ Full content available at: https://github.com/apache/geode-native/pull/373 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.o
[ pull request closed by mmartell ]
[ Full content available at: https://github.com/apache/geode-native/pull/363 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
since not much discussion about this on the dev list, looks like people don't
care much if we go either way. Can we do this for now? We can always reevaluate
if further upgrade tests fail on 9+ and get rid of all old versions.
[ Full content available at: https://github.com/apache/geode/pull/257
In several tests, a listener calls disconnectFromDS() to disconnect its member
when a certain event occurs.
The tests do not wait for the listener to finish disconnecting.
When the tests end, the cleanup also calls `disconnectFromDS()` to disconnect
the same member.
Within `disconnectFromDS()`
+1 I missed that on my recent changes
[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Although not strictly part of this refactoring, the above test,
`testAddJvmOptionsForOutOfMemoryErrors` would be better placed in the
`StartServerCommandTest`, as the method being tested is (now a static) in
`StartServerCommand`.
[ Full content available at: https://github.com/apache/geode/pull
Co-authored-by: @pivotal-eshu
This ticket is already closed by the checkin
db8ba67d98d75aeb0e72b55274757e67f69c9c51
This PR is to add a dunit test to reproduce and verify the fix.
Also, incorporated the release comments missed out in the previous checkin.
- [Yes] Is there a JIRA ticket associat
When GEODE-2644 is merged to develop, we should be able to change
the StatusLogger level back down to WARN.
This will prevent this noise:
```
2018-10-06 23:19:31,304 DisconnectThread ERROR Attempted to append to
non-started appender
org.apache.geode.internal.logging.log4j.LogWriterAppender-org.a
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
[ Full content available at: https://github.com/apache/geode-native/pull/374 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
The failures in the DistributedTest run
(https://concourse.apachegeode-ci.info/builds/3683) are unrelated.
[ Full content available at: https://github.com/apache/geode/pull/2583 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Introduced new classes the use xUnit test framework in a way that mirrors C++
integration-test-2. New tests have been created for the these classes, and
existing tests have been retrofitted.
Co-authored-by: Blake Bender
[ Full content available at: https://github.com/apache/geode-native/pull/3
[ pull request closed by jdeppe-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2578 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [X] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [X] Has y
We ran into a runtime error where we use the help map in SystemAdmin because of
an argument mismatch. This eliminates that problem by using '+' concatenation
instead of String.Format. Although '+' concatenation is slightly less
performant than String.Format, this is not a concern in help docum
We ran into a runtime error where we use the help map in SystemAdmin because of
an argument count mismatch. This eliminates that problem by using '+'
concatenation instead of String.Format. Although '+' concatenation is slightly
less performant than String.Format, this is not a concern in help
[ pull request closed by upthewaterspout ]
[ Full content available at: https://github.com/apache/geode/pull/2568 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
We ran into a runtime error when we use the help map in SystemAdmin because of
an argument count mismatch. This eliminates that problem by using '+'
concatenation instead of String.Format. Although '+' concatenation is slightly
less performant than String.Format, this is not a concern in help
We ran into a runtime error when we use the help map in SystemAdmin because of
an argument count mismatch. This PR eliminates that problem by using '+'
concatenation instead of String.Format. Although '+' concatenation is slightly
less performant than String.Format, this is not a concern in he
Where's the jar deploy command?
[ Full content available at: https://github.com/apache/geode-native/pull/375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
How does this test run without a jar deploy?
[ Full content available at: https://github.com/apache/geode-native/pull/375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by kirklund ]
[ Full content available at: https://github.com/apache/geode/pull/2585 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Requested to close until another branch may be merged. Will rebase and reopen.
[ Full content available at: https://github.com/apache/geode-native/pull/375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by igodwin ]
[ Full content available at: https://github.com/apache/geode-native/pull/375 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by mcmellawatt ]
[ Full content available at: https://github.com/apache/geode/pull/2587 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/373 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by pivotal-jbarrett ]
[ Full content available at: https://github.com/apache/geode-native/pull/367 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This should be made a constant, `SecurableCommunicationChannels.NONE`, to be
consistent with the other declarations.
[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
See output from travis build. Sadly it takes about 2h to run. I was able to get
travis.ci to increase our build timeout to accommodate. Hopefully as we improve
includes that build time will improve.
[ Full content available at: https://github.com/apache/geode-native/pull/374 ]
This message was
This should be made a constant, `SecurableCommunicationChannels.NONE`, to be
consistent with the other declarations.
I think I was wrong about this -- however, we have the other channels supported
as a comma-separated list, and I don't think it makes sense to have `none`
included as a member of
Tests shouldn't be writing things to console. Shouldn't there be some flag this
call is setting so that you can assert it was called later?
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache
We'll clean that up
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This was meant to go in before the test framework changes in GEODE-5746, which
resolves this old way...
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by rhoughton-pivot ]
[ Full content available at: https://github.com/apache/geode/pull/2557 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…s being ignored
Two problems have been addressed:
First, the recursive reconnect logic in InternalDistributedSystem was
broken. After recursion created a new cache the higher up reconnect()
method did not handle things correctly and called things like
createAndStartCacheServers() on the
@pivotal-jbarrett those debug statements are cleaned up and GEODE-5746 will
take care of your other concerns.
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by agingade ]
[ Full content available at: https://github.com/apache/geode/pull/2584 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by echobravopapa ]
[ Full content available at: https://github.com/apache/geode-native/pull/376 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
…ng sleeps
Refactored several tests to use Awaitility instead of sleeping.
Removed other sleep calls that were not impacting their test case.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps ha
Should not block the system notifications for membership changes.
@boglesby @sboorlagadda
Co-authored-by: Sai Boorlagadda
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
#
The fact that we can't run this test means the product also could not be run
this way, which is a known and accepted limitation (users MUST upgrade geode
BEFORE upgrading java). So skipping this test is the right thing to do.
[ Full content available at: https://github.com/apache/geode/pull/257
Depends on #374
[ Full content available at: https://github.com/apache/geode-native/pull/377 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
As an alternative, I am going to try reducing the scope of read-write lock.
The lock is guarding the state inside `ManagementAdapter` as
`handleCacheRemoval` is setting them to `null`
[ Full content available at: https://github.com/apache/geode/pull/2590 ]
This message was relayed via gitbox.ap
[ pull request closed by gesterzhou ]
[ Full content available at: https://github.com/apache/geode/pull/2590 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
without knowing any potential issue, reducing the scope could cause some other
hydra tests to fail. We can watch and see.
[ Full content available at: https://github.com/apache/geode/pull/2590 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has y
Thanks @galen-pivotal!
You're right, it doesn't even make sense to reference the other example
(`SimpleSecurityManager`) so I'll remove that part entirely from the javadocs.
Cheers.
[ Full content available at: https://github.com/apache/geode/pull/2582 ]
This message was relayed via gitbox.apache
Agreed @galen-pivotal, I'll remove the `none` constant altogether and update
the docs + tests.
Cheers.
[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This change puts all of the old framework cpp integration tests into a legacy
subdirectory to make it easier to find the other test related projects.
[ Full content available at: https://github.com/apache/geode-native/pull/378 ]
This message was relayed via gitbox.apache.org for
notifications@ge
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2586 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Just curious, is this related to adding the JAXB dependencies or does it solve
a different issue?
[ Full content available at: https://github.com/apache/geode/pull/2591 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
this one is related to LogService, I believe
[ Full content available at: https://github.com/apache/geode/pull/2591 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Does removing this not make the test flaky? Seems like it would have the
potential to fail on that verify. I have the same question about removing lines
370 and 443 (in the old file's numbering)
[ Full content available at: https://github.com/apache/geode/pull/2589 ]
This message was relayed via
You could use "untilAsserted" here. You would have to use a soft assertion if
you wanted to see all three of those values every time, but even if you just
use regular assertions you'll get an error message that is a little more
informative (as it stands, you'll just see "expected true and was fa
Good cleanup here.
However, per [the style
guide](https://cwiki.apache.org/confluence/display/GEODE/Code+Style+Guide),
"Always use braces, even around one-line `if`, `else` and other control
statements."
[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was
Suuuper minor grammatical suggestion: put a comma after "all", so that there
are clearly three commma-separated options.
[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
No, the suspect state we're checking is set synchronously in the suspect call
above. I'm not sure why this sleep was ever here. InstallView also
synchronously sets all the state needed for the test, making the old sleeps at
370 and 443 similarly pointless.
[ Full content available at: https:/
Testing this it looks like awaitility swallows the assertion failure and simply
outputs: ```org.awaitility.core.ConditionTimeoutException: Assertion condition
defined as a lambda expression in
org.apache.geode.distributed.internal.membership.gms.fd.GMSHealthMonitorJUnitTest
null within 1000 mil
[ pull request closed by WireBaron ]
[ Full content available at: https://github.com/apache/geode/pull/2589 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has y
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has y
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Any opinions on where this data container class should live? I kept it on the
path to be the same as the test that needs it, but that's not really necessary.
It could belong to `geode-dunit` as a shared resource, if we track down other
places that need a simple `java.io.Serializable` data cont
@pivotal-jbarrett @onichols-pivotal Please review this build fix.
[ Full content available at: https://github.com/apache/geode/pull/2595 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Similar to the other comment, there's no real reason this has to get packaged
in the `jar` to the full `o.a.g.m.i.c.c` package. Would this test read cleaner
if the jar put the `SerializableNameContainer` at the top-level package?
I know I'm overthinking this.
[ Full content available at: https
[ pull request closed by galen-pivotal ]
[ Full content available at: https://github.com/apache/geode/pull/2595 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
why do you have two assignments of "runtimeException"? Seems like the second
assignment just throws away your new one.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Upon immediate hindsight, this is absolutely not the right way to do this.
Maybe examine the class, get a list of dependencies, and depend on those. As
it stands, our `repeat-new-tests.sh` will run the entire `*Test` instead of
just repeating the changed tests within that scope.
[ Full conten
[ pull request closed by echobravopapa ]
[ Full content available at: https://github.com/apache/geode-native/pull/374 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@jujoramos if you want, I'm happy to add the braces and merge. Just figured it
might be helpful to get feedback on the style guide.
[ Full content available at: https://github.com/apache/geode/pull/2581 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
* as 1.7.0 has been released, this version must be tested against the
current snapshot
* thus 1.7.0 has been added to the build.gradle file of the
geode-old-version project.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contrib
Done!
[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
[ pull request closed by dickcav ]
[ Full content available at: https://github.com/apache/geode/pull/2591 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
This looks awesome! I assume this corrects any IDE formatting issues so that as
long as I compile before I check-in, they will be corrected.
[ Full content available at: https://github.com/apache/geode-native/pull/377 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apach
You are right, it should not set runtimeException as
getCancelCriterion().generateCancelledException would throw exception if cache
is closing. I was just use the code in basicPutAll.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apa
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [ ] Has y
Important part of the fix here...
[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@WireBaron @galen-pivotal @upthewaterspout
[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Actually, the method may not throw CacheClosedException but return
CacheClosedException instead. Made the change necessary.
[ Full content available at: https://github.com/apache/geode/pull/2594 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
If clang-format is found, yes.
[ Full content available at: https://github.com/apache/geode-native/pull/377 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@WireBaron @galen-pivotal @upthewaterspout
[ Full content available at: https://github.com/apache/geode/pull/2597 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in the
commit message?
- [x] Has y
Should this be `java_test_version.name.endsWith("JDK11")` ?
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
I almost hate to comment on one-line PRs, but if the intent is "only the things
that act as blocking for `UpdatePassingRef`, then we should use the same as
that block:
```
- name: UpdatePassingRef- name: UpdatePassingRef
public: truepublic: true
serial: trueserial: true
I almost hate to comment on one-line PRs, but if the intent is "only the things
that act as blocking for `UpdatePassingRef`, then we should use the same as
that block:
```
- name: UpdatePassingRef
public: true
serial: true
plan:
- get: geode
passed:
{% for test in tests if not (t
[ pull request closed by sboorlagadda ]
[ Full content available at: https://github.com/apache/geode/pull/2580 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pivotal-amurmann may want to review this.
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
@pivotal-amurmann Should we then have an All or Complete so we can see them
all?
[ Full content available at: https://github.com/apache/geode/pull/2598 ]
This message was relayed via gitbox.apache.org for
notifications@geode.apache.org
701 - 800 of 9074 matches
Mail list logo
