[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-677529060 Sounds good @mkevo, thanks for the update and sorry for all the back and forth, I wish I have had spotted the single line fix before to spare you some time :-/. Once the `PR`

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671321433 The `DescribeOfflineDiskStoreCommand` class calls `DiskStoreImpl.dumpInfo()`, which has an instance of the `DiskStoreImpl` class, it can be used directly to call `close()`, see

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-671309686 Sure, can you point me exactly to which commands you're referring here?. The original ticket ([GEODE-8119](https://issues.apache.org/jira/browse/GEODE-8119)) doesn't mention

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-670655764 @mkevo Thanks for adding the extra tests. I'm not fully convinced about the implemented fix, however, did you consider my comments

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-657507636 Hello @mkevo, This PR has been inactive for quite some time now, should we close it or are you planning to continue working on it?.

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-638793177 @mkevo > In all offline disk-store commands it calls DiskStoreImpl in which is startAsyncFlusher which starts these threads. E.g. AlterOfflineDiskStoreCommand use

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-637555044 @mkevo I don't see anything related to threads within the `DiskStoreCommandsUtils.validatedDirectories()` method, it's just a regular java method that executes sequentially

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-637520546 @mkevo One thing I forgot to mention is that I ran the internal tests again and I can see exactly the same failure messages as before: ``` Executing - validate

[GitHub] [geode] jujoramos commented on pull request #5175: GEODE-8119: Threads hangs when offline disk store command is invoked

jujoramos commented on pull request #5175: URL: https://github.com/apache/geode/pull/5175#issuecomment-635849316 Hey @mkevo Thanks for working on this, I'll start the review once all `CI` tests are green. Cheers.