[GitHub] [geode] jujoramos commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox 


jujoramos commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670514196


   Dang!, somehow I totally missed that notification and there wasn't any new 
comments on the `PR` (other than the one from Owen) so I didn't get any 
specific email addressed to myself (hard to keep track of old `PRs` when there 
are so many emails coming and going), sorry about that!.
   I can have a look at the `PR` if you re-open it  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [geode] jujoramos commented on pull request #5227: GEODE-8191: flaky test correction

2020-08-07 Thread GitBox 


jujoramos commented on pull request #5227:
URL: https://github.com/apache/geode/pull/5227#issuecomment-670504376


   Hello @mivanac , 
   Just for the record, I've been actively reviewing this `PR` since it was 
opened but I don't think the fix is sufficient to fix the flakiness, that's why 
I requested changes on `15/06/2020`; there wasn't any response from your side 
afterwards.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org