PurelyApplied commented on a change in pull request #5427:
URL: https://github.com/apache/geode/pull/5427#discussion_r466052198
##########
File path: ci/scripts/execute_tests.sh
##########
@@ -34,6 +34,11 @@ if [[ -z "${GRADLE_TASK}" ]]; then
exit 1
fi
+. ${SCRIPTDIR}/short_circuit_pr_tasks.sh
+cd geode
+ is_source_from_pr_testable "ci" "dev-tools" "etc" "geode-book" "geode-docs"
|| exit 0
Review comment:
I also have little skin in the game, but here are some options that jump
out at me:
* Like Jake said, let `short_circuit_pr_tasks` be the source of truth for
what directories are excluded.
* Take an arg list, and specify those args in the task's `yml`. Jinja or
yml anchoring could reduce duplication.
* Get exceedingly convoluted by having this check be an independent
Concourse job which outputs a sentinel file, which test jobs use to determine
whether or not to short-circuit to green.
I feel like the first option is best for the first iteration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
