[GitHub] [geode] alb3rtobr commented on pull request #4978: Fix for regression introduced by GEODE-7565
alb3rtobr commented on pull request #4978: URL: https://github.com/apache/geode/pull/4978#issuecomment-620729123 > I've added a small `DistributedTest` to my [branch](https://github.com/apache/geode/pull/4990/files#diff-b478e9ee8bbd7e0de69c1bac78ee0db2), you can use it as the starting point to test the different scenarios of the `Ping` execution. The method [`memberShouldNotRedirectPingMessageWhenClientCachedViewIdIsWrong`](https://github.com/apache/geode/pull/4990/files#diff-b478e9ee8bbd7e0de69c1bac78ee0db2R188) reproduces exactly the `ClassCastException` I'm seeing during our internal testing. Thanks @jujoramos , I have used your code to create a test and identify the problem. I will add more tests as requested. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #4978: Fix for regression introduced by GEODE-7565
alb3rtobr commented on pull request #4978: URL: https://github.com/apache/geode/pull/4978#issuecomment-619030061 > @alb3rtobr: I've executed the tests again and still see some failures, see my inline comments within the `Ping.java` class. > As a side note, I still don't see tests added to this pull request (only one new, which is really scarce considering the amount of changes introduced through `GEODE-7565`), please add multiple tests to verify all the code changes and additions. I hope last two commits solve the failure I introduced, sorry for that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [geode] alb3rtobr commented on pull request #4978: Fix for regression introduced by GEODE-7565
You are right, it seems they are not used, I will remove them. [ Full content available at: https://github.com/apache/geode/pull/4978 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org
