[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-06-03 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r434807254 ## File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/general/ShutdownIntegrationTest.java ## @@ -56,6 +57,7 @@ public void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-06-03 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r434756871 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/RedisKeyInRegion.java ## @@ -102,4 +102,16 @@ protected

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-06-03 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r434749357 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/RenameExecutor.java ## @@ -47,47 +35,15 @@ public void

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-05-23 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r429522379 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/RedisKeyInRegion.java ## @@ -46,4 +47,13 @@ public boolean

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5152: Change Redis Rename Functions to Make use of Striped Executor

2020-05-22 Thread GitBox
dschneider-pivotal commented on a change in pull request #5152: URL: https://github.com/apache/geode/pull/5152#discussion_r429477577 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/executor/CommandFunction.java ## @@ -84,10 +88,32 @@ protected Object