[GitHub] [geode] dschneider-pivotal commented on pull request #4067: GEODE-6871: Disk free space info exposed via JMX

2019-09-18 Thread GitHub
Geode exposes much of the external apis on interfaces. Many of those interfaces are not meant to be implemented by geode users. Instead they are used to hide the internal geode implementation. For example Region is an interface that a geode user never needs to implement. So in the past as we

[GitHub] [geode] dschneider-pivotal commented on pull request #4067: GEODE-6871: Disk free space info exposed via JMX

2019-09-18 Thread GitHub
@jujoramos I like the idea of adding a default to interface methods we add to existing external interfaces. [ Full content available at: https://github.com/apache/geode/pull/4067 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] dschneider-pivotal commented on pull request #4067: GEODE-6871: Disk free space info exposed via JMX

2019-09-18 Thread GitHub
I think this mix of camel case and underscores was intentional to help highlight the three sections (given, when, then). @dhemery may have some helpful input on this. [ Full content available at: https://github.com/apache/geode/pull/4067 ] This message was relayed via gitbox.apache.org for

[GitHub] [geode] dschneider-pivotal commented on pull request #4067: GEODE-6871: Disk free space info exposed via JMX

2019-09-18 Thread GitHub
@jujoramos Does the addition of a new method on an interface break old code that is already compiled against the old interface? When you say it "breaks backward compatibility" what do you mean? Is it that the old class files will no longer run with the new product jar? Or is it that old code