[GitHub] [geode] gesterzhou commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

2020-05-27 Thread GitBox


gesterzhou commented on a change in pull request #5147:
URL: https://github.com/apache/geode/pull/5147#discussion_r431450182



##
File path: geode-core/src/main/java/org/apache/geode/cache/Region.java
##
@@ -1362,49 +1362,77 @@ Object selectValue(String queryPredicate) throws 
FunctionDomainException, TypeMi
* Scope.LOCAL.
*
* If an exception is thrown due to this call, it can imply that there may 
have been a partial
-   * update performed on the region. Use putAll from within a transaction to 
to obtain an atomic
-   * update.
+   * update performed on the region.
* 
*
* @see java.util.Map#putAll(Map map)
-   * @param map the key/value pairs to put in this region.
+   * @param map the key/value pairs to put in this region
+   * @throws ServerOperationException if called from a client, and the server 
throws an exception
+   * such as CacheWriterException, PartitionedRegionStorageException 
or LowMemoryException.
+   * These server exceptions become the ServerOperationException cause
+   * @throws ServerConnectivityException if called from a client, and the 
server throws
+   * CancelException. CancelException will be the 
ServerConnectivityException cause
* @throws NullPointerException if key is null or if value is null (use 
invalidate instead), or if
* the key or value do not meet serializability requirements

Review comment:
   fixed. 

##
File path: geode-core/src/main/java/org/apache/geode/cache/Region.java
##
@@ -1362,49 +1362,77 @@ Object selectValue(String queryPredicate) throws 
FunctionDomainException, TypeMi
* Scope.LOCAL.
*
* If an exception is thrown due to this call, it can imply that there may 
have been a partial
-   * update performed on the region. Use putAll from within a transaction to 
to obtain an atomic
-   * update.
+   * update performed on the region.
* 
*
* @see java.util.Map#putAll(Map map)
-   * @param map the key/value pairs to put in this region.
+   * @param map the key/value pairs to put in this region
+   * @throws ServerOperationException if called from a client, and the server 
throws an exception
+   * such as CacheWriterException, PartitionedRegionStorageException 
or LowMemoryException.
+   * These server exceptions become the ServerOperationException cause
+   * @throws ServerConnectivityException if called from a client, and the 
server throws
+   * CancelException. CancelException will be the 
ServerConnectivityException cause
* @throws NullPointerException if key is null or if value is null (use 
invalidate instead), or if
* the key or value do not meet serializability requirements
* @throws ClassCastException if key does not satisfy the keyConstraint
-   * @throws org.apache.geode.distributed.LeaseExpiredException if lease 
expired on distributed lock
-   * for Scope.GLOBAL
-   * @throws TimeoutException if timed out getting distributed lock for 
Scope.GLOBAL
+   * @throws org.apache.geode.distributed.LeaseExpiredException if lease 
expired on distributed
+   * lock for regions with Scope.GLOBAL

Review comment:
   fixed





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [geode] gesterzhou commented on a change in pull request #5147: GEODE-8171: javadoc for putAll need to have accurate exception

2020-05-22 Thread GitBox


gesterzhou commented on a change in pull request #5147:
URL: https://github.com/apache/geode/pull/5147#discussion_r429359435



##
File path: geode-core/src/main/java/org/apache/geode/cache/Region.java
##
@@ -1359,10 +1359,30 @@ Object selectValue(String queryPredicate) throws 
FunctionDomainException, TypeMi
* in the specified map. This operation will be distributed to other caches 
if the scope is not
* Scope.LOCAL.
*
-   * @param map the key/value pairs to put in this region.
-   * @since GemFire 5.0
+   * If any exception is thrown due to this call, it can imply that there may 
have been a partial
+   * update performed on the region. Use putAll from within a transaction to 
get atomicity with all
+   * the

Review comment:
   fixed.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org