jdeppe-pivotal opened a new pull request #5488: URL: https://github.com/apache/geode/pull/5488
- Do not use Netty threads for the entire request lifecycle. Each instance of ExecutionHandlerContext (essentially each client connection) uses a command queue which is actioned by a single thread taken from the Geode 'waiting pool'. - Every SUBSCRIBEed client is moved to a separate EventGroupLoop so that PUBLISHed messages are not sent back using the 'normal' Worker EventLoopGroup. This avoids a deadlock issue where PUBLISHed messages need to be sent using the same thread that the PUBLISH response needs to happen on. - Fix issues with PubSub where switching the EventLoopGroup may fail (because a client has already closed the connection) thus resulting in hanging PUBLISHers waiting for a Subscription to be marked as 'readyForPublish'. - Consolidate various MockSubscriber classes Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org