[GitHub] [geode] kirklund commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-27 Thread GitHub
I think we should have change every \n in the code base to be System.getProperty("line.separator") in one PR, but I'll go ahead and change this class. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This message was relayed via gitbox.apache.org for notifications@geode.

[GitHub] [geode] kirklund commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-27 Thread GitHub
@pdxrunner @sboorlagadda I'm actually not sure how to handle some of this logic: ```java if (endChar == '\n') { // trim off the \n since println will do it for us wordEnd--; if (wordEnd > 0 && target.charAt(wordEnd - 1) == '\r') { wordEnd--; } ``` I c

[GitHub] [geode] kirklund commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-27 Thread GitHub
I think we should change every \n in the code base to be System.getProperty("line.separator") in one PR, but I'll go ahead and change this class. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This message was relayed via gitbox.apache.org for notifications@geode.apach

[GitHub] [geode] kirklund commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-26 Thread GitHub
What do you want to replace the hardcoded newlines with? Without them the stack trace will be all on one line. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org