ladyVader commented on a change in pull request #4928:
URL: https://github.com/apache/geode/pull/4928#discussion_r429320060
##########
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/CreateGatewaySenderCommand.java
##########
@@ -75,6 +75,11 @@ public ResultModel createGatewaySender(
mandatory = true,
help =
CliStrings.CREATE_GATEWAYSENDER__REMOTEDISTRIBUTEDSYSTEMID__HELP) Integer
remoteDistributedSystemId,
+ @CliOption(key = CliStrings.CREATE_GATEWAYSENDER__GROUPTRANSACTIONEVENTS,
+ specifiedDefaultValue = "true",
+ unspecifiedDefaultValue = "false",
+ help =
CliStrings.CREATE_GATEWAYSENDER__GROUPTRANSACTIONEVENTS__HELP) boolean
groupTransactionEvents,
+
Review comment:
Thanks for both the new Exception on misconfiguring the
SerialGatewaySender with groupTransactionEvents enabled + dispatcherThreads > 1.
In addition, I'm no longer seeing the data inconsistencies or hangs waiting
for the primary gateway sender queue to drain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
