[GitHub] [geode] pdxrunner commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-27 Thread GitHub
Sounds OK. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] pdxrunner commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-27 Thread GitHub
Sorry, my original comment was too terse. My intent was as @sboorlagadda said. All part of the effort to remove platform dependencies like pathname separators, end of line conventions, classpath separators, etc. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This messag

[GitHub] [geode] pdxrunner commented on pull request #2517: GEODE-2644: Cleanup logging classes

2018-09-26 Thread GitHub
I think we should get rid of all these hardcoded newlines. [ Full content available at: https://github.com/apache/geode/pull/2517 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org