[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-22 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r429255221 ## File path: geode-core/src/main/java/org/apache/geode/distributed/ConfigurationProperties.java ## @@ -1943,6 +1931,36 @@ * Default: "" */

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428653882 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java ## @@ -301,6 +301,13 @@ ResultModel

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428640516 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java ## @@ -275,7 +275,8 @@ public GeodeRedisServer(String

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428639899 ## File path: geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java ## @@ -241,7 +241,7 @@ private int

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428637710 ## File path: geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/StartServerCommand.java ## @@ -301,6 +301,13 @@ ResultModel

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428635821 ## File path: geode-core/src/main/java/org/apache/geode/management/internal/i18n/CliStrings.java ## @@ -2557,14 +2557,14 @@ "The

[GitHub] [geode] sabbeyPivotal commented on a change in pull request #5142: GEODE-8138: Improve semantics of the redis-port option

2020-05-21 Thread GitBox
sabbeyPivotal commented on a change in pull request #5142: URL: https://github.com/apache/geode/pull/5142#discussion_r428632736 ## File path: geode-core/src/main/java/org/apache/geode/distributed/internal/AbstractDistributionConfig.java ## @@ -1312,11 +1313,13 @@ static Class