[GitHub] [geode] upthewaterspout commented on pull request #3922: GEODE-7085: Ensuring the bitset stays within BIT_SET_WIDTH

Well, this is in the else clause - we we know that newVersion <= bitSetVersion+bitSet.size(). But maybe it would have been better to use Math.toIntExact here to validate that. [ Full content available at: https://github.com/apache/geode/pull/3922 ] This message was relayed via gitbox.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #3922: GEODE-7085: Ensuring the bitset stays within BIT_SET_WIDTH

Good point. I will add a check. [ Full content available at: https://github.com/apache/geode/pull/3922 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org

[GitHub] [geode] upthewaterspout commented on pull request #3922: GEODE-7085: Ensuring the bitset stays within BIT_SET_WIDTH

This assertion is a little stronger than toIntExact. We are asserting that the bitToSet is less than or equal to BIT_SET_WIDTH (around 1K). [ Full content available at: https://github.com/apache/geode/pull/3922 ] This message was relayed via gitbox.apache.org for notifications@geode.apache.org