alb3rtobr edited a comment on pull request #635: URL: https://github.com/apache/geode-native/pull/635#issuecomment-677451250
> > I'm also hitting this on Windows builds now, though it appears to have come in with yesterday's PR for GatewaySenderEventCallbackArgument: > > `Z:\nativeclient\cppcache\integration\test\WanDeserializationTest.cpp(169): error C3861: 'sleep': identifier not found` > > continuing to investigate... > > Not sure how that ever worked given that's not really a standard function. > You want `std::this_thread::sleep_for`. > > Also, sleeping in a test just makes it flaky. > > https://en.cppreference.com/w/cpp/thread/sleep_for Ok, Im going to fix it in a separate PR. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
