[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751787 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466751011 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748307 ## File path: cppcache/src/TcpConn.hpp ## @@ -65,75 +62,33 @@ class APACHE_GEODE_EXPORT TcpConn : public Connector { virtual void

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-08-06 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r466748099 ## File path: cppcache/src/TcpConn.cpp ## @@ -318,14 +237,35 @@ size_t TcpConn::socketOp(TcpConn::SockOp op, char *buff, size_t len,

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #630: GEODE-8102 Link and load OpenSSL library directly

2020-07-31 Thread GitBox
pivotal-jbarrett commented on a change in pull request #630: URL: https://github.com/apache/geode-native/pull/630#discussion_r463914946 ## File path: clicache/src/CMakeLists.txt ## @@ -23,7 +23,7 @@ configure_file(${CMAKE_CURRENT_SOURCE_DIR}/impl/AssemblyInfo.cpp.in