[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473251486 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473244538 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473107131 ## File path: cppcache/integration/test/sni-test-config/geode-config/truststore_sni.pem ## @@ -0,0 +1,68 @@ +-BEGIN CERTIFICATE-

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-19 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r473106328 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472527125 ## File path: clicache/src/PoolFactory.hpp ## @@ -279,6 +279,20 @@ namespace Apache /// PoolFactory^ AddServer(String^

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472525063 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-18 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r472524195 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [geode-native] pivotal-jbarrett commented on a change in pull request #634: GEODE-8398: Add SNI support to .NET API

2020-08-17 Thread GitBox
pivotal-jbarrett commented on a change in pull request #634: URL: https://github.com/apache/geode-native/pull/634#discussion_r471800583 ## File path: clicache/integration-test2/SNITests.cs ## @@ -0,0 +1,127 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one