pivotal-jbarrett commented on pull request #676: URL: https://github.com/apache/geode-native/pull/676#issuecomment-710089765
> > I need more time to review this for correctness. I think the locking is required here to both protect concurrent updates to the `m_poolSize` value in various places as well as synchronize the CPU caches of this member. > > Wouldn't that already be guaranteed given that the type of `m_poolSize` is `std::atomic<int32_t>`? I hadn't looked into the type yet but mostly yes that should be safe. Though if the pool and count are mutated independently there could be some issues with a mismatch. I will poke into this later today. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
