[jira] [Issue Comment Deleted] (GROOVY-7725) compatibility issue of class groovy.lang.IntRange

2016-01-04 Thread ZENG Jipeng (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZENG Jipeng updated GROOVY-7725: Comment: was deleted (was: Thanks for you quick reply, really appreciate that. One more question, i

[jira] [Commented] (GROOVY-7725) compatibility issue of class groovy.lang.IntRange

2016-01-04 Thread ZENG Jipeng (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082476#comment-15082476 ] ZENG Jipeng commented on GROOVY-7725: - Thanks for you quick reply, really appreciate

[jira] [Commented] (GROOVY-7725) compatibility issue of class groovy.lang.IntRange

2016-01-04 Thread ZENG Jipeng (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082475#comment-15082475 ] ZENG Jipeng commented on GROOVY-7725: - Thanks for you quick reply, really appreciate

[jira] [Commented] (GROOVY-6220) Compiler gives very cryptic error messages for unterminated regexes

2016-01-04 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-6220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082380#comment-15082380 ] Paul King commented on GROOVY-6220: --- I imagine this will be easier to try to resolve on

[jira] [Commented] (GROOVY-7725) compatibility issue of class groovy.lang.IntRange

2016-01-04 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082374#comment-15082374 ] Paul King commented on GROOVY-7725: --- Unfortunately, there was a limitation in the origi

[jira] [Updated] (GROOVY-7725) compatibility issue of class groovy.lang.IntRange

2016-01-04 Thread ZENG Jipeng (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ZENG Jipeng updated GROOVY-7725: Summary: compatibility issue of class groovy.lang.IntRange (was: compatibility issue of function I

[jira] [Created] (GROOVY-7725) compatibility issue of function IntRange()

2016-01-04 Thread ZENG Jipeng (JIRA)
ZENG Jipeng created GROOVY-7725: --- Summary: compatibility issue of function IntRange() Key: GROOVY-7725 URL: https://issues.apache.org/jira/browse/GROOVY-7725 Project: Groovy Issue Type: Bug

[GitHub] groovy pull request: Two branches in the same conditional structur...

2016-01-04 Thread paulk-asert
Github user paulk-asert commented on a diff in the pull request: https://github.com/apache/groovy/pull/232#discussion_r48809410 --- Diff: src/main/org/codehaus/groovy/classgen/asm/OperandStack.java --- @@ -336,14 +336,12 @@ private void doConvertAndCast(ClassNode targetType, boolea

[jira] [Resolved] (GROOVY-6835) flow typing activated by if statement doing an "instanceof" check doesn't work as expected with interface types

2016-01-04 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-6835?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-6835. --- Resolution: Fixed Assignee: Paul King (was: Cédric Champeau) Fix Version/s: 2.4.6 Ad

[GitHub] groovy pull request: Empty statements should be removed

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/233 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] groovy pull request: Collection.isEmpty() should be used to test f...

2016-01-04 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/231 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[jira] [Commented] (GROOVY-7530) disjoint() does not work correctly if objects don't implement Comparable

2016-01-04 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082047#comment-15082047 ] Paul King commented on GROOVY-7530: --- I'm still keen to understand if there is a vulnera

[jira] [Commented] (GROOVY-7673) Remove synchronized methods of groovy.sql.Sql and document it as not thread-safe

2016-01-04 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15082035#comment-15082035 ] Paul King commented on GROOVY-7673: --- Yes, I see that now. Sorry for the noise - I thoug

[jira] [Commented] (GROOVY-7530) disjoint() does not work correctly if objects don't implement Comparable

2016-01-04 Thread Andrew Preston (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7530?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081857#comment-15081857 ] Andrew Preston commented on GROOVY-7530: Hi Tobias - would you be able to raise t

[jira] [Resolved] (GROOVY-7673) Remove synchronized methods of groovy.sql.Sql and document it as not thread-safe

2016-01-04 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pascal Schumacher resolved GROOVY-7673. --- Resolution: Fixed Hi Paul, I already reverted this in 2_4_X [https://github.com/apa

[jira] [Comment Edited] (GROOVY-7673) Remove synchronized methods of groovy.sql.Sql and document it as not thread-safe

2016-01-04 Thread Pascal Schumacher (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15081494#comment-15081494 ] Pascal Schumacher edited comment on GROOVY-7673 at 1/4/16 6:05 PM:

[GitHub] groovy pull request: Empty statements should be removed

2016-01-04 Thread kirill-vlasov
GitHub user kirill-vlasov opened a pull request: https://github.com/apache/groovy/pull/233 Empty statements should be removed This pull request is focused on resolving occurrences of Sonar rule squid:EmptyStatementUsageCheck - Empty statements should be removed You can find more

[GitHub] groovy pull request: Two branches in the same conditional structur...

2016-01-04 Thread kirill-vlasov
GitHub user kirill-vlasov opened a pull request: https://github.com/apache/groovy/pull/232 Two branches in the same conditional structure should not have exactly the same implementation This pull request is focused on resolving occurrences of Sonar rule squid:S1871 - Two branches i

[GitHub] groovy pull request: Collection.isEmpty() should be used to test f...

2016-01-04 Thread kirill-vlasov
GitHub user kirill-vlasov opened a pull request: https://github.com/apache/groovy/pull/231 Collection.isEmpty() should be used to test for emptiness This pull request is focused on resolving occurrences of Sonar rule squid:S1155 - Collection.isEmpty() should be used to test for empt