[GitHub] groovy pull request: make private fields final where possible

2016-03-14 Thread shils
Github user shils commented on a diff in the pull request: https://github.com/apache/groovy/pull/292#discussion_r56113728 --- Diff: src/main/groovy/grape/GrapeIvy.groovy --- @@ -76,11 +76,11 @@ class GrapeIvy implements GrapeEngine { Set resolvedDependencies Set

[GitHub] groovy pull request: make private fields final where possible

2016-03-14 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/292#discussion_r56097572 --- Diff: subprojects/groovy-sql/src/main/java/groovy/sql/BatchingStatementWrapper.java --- @@ -34,10 +34,10 @@ * automatically. If batchSize is

[GitHub] groovy pull request: make private fields final where possible

2016-03-14 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/292#discussion_r56096947 --- Diff: src/main/org/codehaus/groovy/control/MultipleCompilationErrorsException.java --- @@ -27,7 +27,7 @@ public class

[jira] [Created] (GROOVY-7788) Groovy does not run on 64 bit Windows 7

2016-03-14 Thread Shawn Cole (JIRA)
Shawn Cole created GROOVY-7788: -- Summary: Groovy does not run on 64 bit Windows 7 Key: GROOVY-7788 URL: https://issues.apache.org/jira/browse/GROOVY-7788 Project: Groovy Issue Type: Bug

[GitHub] groovy pull request: Fixed a typo

2016-03-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/293 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Assigned] (GROOVY-7758) GroovyCastException when both @CompileStatic and @Newify are used

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shil Sinha reassigned GROOVY-7758: -- Assignee: Shil Sinha > GroovyCastException when both @CompileStatic and @Newify are used >

[GitHub] groovy pull request: GROOVY-7758: GroovyCastException when both @C...

2016-03-14 Thread shils
GitHub user shils opened a pull request: https://github.com/apache/groovy/pull/294 GROOVY-7758: GroovyCastException when both @CompileStatic and @Newify… … are used You can merge this pull request into a Git repository by running: $ git pull https://github.com/shils/groovy

[GitHub] groovy pull request: Fixed a typo

2016-03-14 Thread maciekwiso
GitHub user maciekwiso opened a pull request: https://github.com/apache/groovy/pull/293 Fixed a typo You can merge this pull request into a Git repository by running: $ git pull https://github.com/maciekwiso/groovy master Alternatively you can review and apply these changes

[jira] [Commented] (GROOVY-7758) GroovyCastException when both @CompileStatic and @Newify are used

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193942#comment-15193942 ] Shil Sinha commented on GROOVY-7758: This occurs because 'implicitThis' is not set correctly in

[jira] [Comment Edited] (GROOVY-7774) Collection addAll fails CompileStatic type checking when adding a collection of subtypes

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193509#comment-15193509 ] Shil Sinha edited comment on GROOVY-7774 at 3/14/16 3:47 PM: - The compiler

[jira] [Comment Edited] (GROOVY-7774) Collection addAll fails CompileStatic type checking when adding a collection of subtypes

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193509#comment-15193509 ] Shil Sinha edited comment on GROOVY-7774 at 3/14/16 3:46 PM: - The compiler

[jira] [Commented] (GROOVY-7774) Collection addAll fails CompileStatic type checking when adding a collection of subtypes

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7774?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193509#comment-15193509 ] Shil Sinha commented on GROOVY-7774: The compiler determines the target method for

[jira] [Commented] (GROOVY-7784) TypeChecked/CompileStatic: IndexOutOfBoundsException

2016-03-14 Thread Shil Sinha (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-7784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15193450#comment-15193450 ] Shil Sinha commented on GROOVY-7784: This occurs during SAM type inference when the target method has