[jira] [Commented] (GROOVY-8193) TraitReceiverTransformer does not set source position on property expressions

2017-05-20 Thread Arsen Babakhanyan (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018616#comment-16018616 ] Arsen Babakhanyan commented on GROOVY-8193: --- thanks [~jwagenleitner] for help >

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615150 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait,

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117615134 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait,

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614896 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait,

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/544#discussion_r117614868 --- Diff: src/main/org/codehaus/groovy/transform/trait/Traits.java --- @@ -355,19 +355,19 @@ static String getSuperTraitMethodName(ClassNode trait,

[GitHub] groovy pull request #544: refactor: type safety and formatting

2017-05-20 Thread jwagenleitner
GitHub user jwagenleitner opened a pull request: https://github.com/apache/groovy/pull/544 refactor: type safety and formatting You can merge this pull request into a Git repository by running: $ git pull https://github.com/jwagenleitner/groovy refactor Alternatively you can

[jira] [Resolved] (GROOVY-8193) TraitReceiverTransformer does not set source position on property expressions

2017-05-20 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Wagenleitner resolved GROOVY-8193. --- Resolution: Fixed Assignee: John Wagenleitner Fix Version/s: 2.4.12

[GitHub] groovy pull request #:

2017-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219191 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In

[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219164 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In

[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219142 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In

[GitHub] groovy pull request #:

2017-05-20 Thread PascalSchumacher
Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219131 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In

[GitHub] groovy pull request #:

2017-05-20 Thread danielsun1106
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219095 In src/main/org/apache/groovy/util/Maps.java: In src/main/org/apache/groovy/util/Maps.java on line 11: Thanks for

[jira] [Commented] (GROOVY-8193) TraitReceiverTransformer does not set source position on property expressions

2017-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018498#comment-16018498 ] ASF GitHub Bot commented on GROOVY-8193: Github user asfgit closed the pull request at:

[GitHub] groovy pull request #542: GROOVY-8193: setting sourcePosition on Property Ex...

2017-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/542 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[jira] [Resolved] (GROOVY-8166) Repeated operations in AnnotationCollectorTransform and Traits

2017-05-20 Thread John Wagenleitner (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] John Wagenleitner resolved GROOVY-8166. --- Resolution: Fixed Assignee: John Wagenleitner Fix Version/s: 2.4.12

[GitHub] groovy pull request #:

2017-05-20 Thread jwagenleitner
Github user jwagenleitner commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22218912 In src/main/org/apache/groovy/util/Maps.java: In src/main/org/apache/groovy/util/Maps.java on line 11: JDK9 added

[jira] [Commented] (GROOVY-8166) Repeated operations in AnnotationCollectorTransform and Traits

2017-05-20 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16018461#comment-16018461 ] ASF GitHub Bot commented on GROOVY-8166: Github user asfgit closed the pull request at:

[GitHub] groovy pull request #543: GROOVY-8166: Repeated operations in AnnotationColl...

2017-05-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/543 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] groovy pull request #532: Prevent CachedField and CachedMethod from leaking ...

2017-05-20 Thread dpolivaev
Github user dpolivaev commented on a diff in the pull request: https://github.com/apache/groovy/pull/532#discussion_r117609738 --- Diff: src/main/groovy/lang/MetaClassImpl.java --- @@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object object, String name, boolean