[GitHub] [groovy] danielsun1106 commented on issue #1021: GROOVY-9270: add checks for invalid instanceof reference types

2019-10-08 Thread GitBox
danielsun1106 commented on issue #1021: GROOVY-9270: add checks for invalid instanceof reference types URL: https://github.com/apache/groovy/pull/1021#issuecomment-539779457 LGTM This is an automated message from the Apache

[GitHub] [groovy] danielsun1106 commented on issue #1024: Minor: Improve code readability

2019-10-08 Thread GitBox
danielsun1106 commented on issue #1024: Minor: Improve code readability URL: https://github.com/apache/groovy/pull/1024#issuecomment-539774752 +1 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [groovy] scovetta opened a new pull request #1024: Minor: Improve code readability

2019-10-08 Thread GitBox
scovetta opened a new pull request #1024: Minor: Improve code readability URL: https://github.com/apache/groovy/pull/1024 This change includes some basic formatting fixes (spaces around operators, etc.), which wasn't consistent in the original version. I also added a space that was

[jira] [Commented] (GROOVY-8946) @CompileStatic ignores declared type and forces a cast when inside a closure

2019-10-08 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-8946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16947021#comment-16947021 ] Eric Milles commented on GROOVY-8946: - [~kikoalemao] One thing I have used to get at a deeply nested

[GitHub] [groovy] danielsun1106 commented on issue #1023: Avoid deprecated `compile` and `testCompile`

2019-10-08 Thread GitBox
danielsun1106 commented on issue #1023: Avoid deprecated `compile` and `testCompile` URL: https://github.com/apache/groovy/pull/1023#issuecomment-539556159 @blindpirate After `compile` replaced with `implementation`, `:groovy-groovydoc:compileJava` failed because its dependency was

[GitHub] [groovy] danielsun1106 opened a new pull request #1023: Avoid deprecated `compile` and `testCompile`

2019-10-08 Thread GitBox
danielsun1106 opened a new pull request #1023: Avoid deprecated `compile` and `testCompile` URL: https://github.com/apache/groovy/pull/1023 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [groovy] danielsun1106 merged pull request #1022: Minor refactoring: Refine collecting errors when generating bytecode for native method reference

2019-10-08 Thread GitBox
danielsun1106 merged pull request #1022: Minor refactoring: Refine collecting errors when generating bytecode for native method reference URL: https://github.com/apache/groovy/pull/1022 This is an automated message from the

[GitHub] [groovy] paulk-asert commented on issue #1022: Minor refactoring: Refine collecting errors when generating bytecode for native method reference

2019-10-08 Thread GitBox
paulk-asert commented on issue #1022: Minor refactoring: Refine collecting errors when generating bytecode for native method reference URL: https://github.com/apache/groovy/pull/1022#issuecomment-539472943 +1 This is an

[jira] [Commented] (GROOVY-9268) Access to ... is forbidden

2019-10-08 Thread A. Lepe (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-9268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16946616#comment-16946616 ] A. Lepe commented on GROOVY-9268: - Thank you. Is there any nightly build that can be tested? I will

[GitHub] [groovy] danielsun1106 opened a new pull request #1022: Refine collecting errors when generating bytecode for native method r…

2019-10-08 Thread GitBox
danielsun1106 opened a new pull request #1022: Refine collecting errors when generating bytecode for native method r… URL: https://github.com/apache/groovy/pull/1022 …eference This is an automated message from the Apache Git