[GitHub] [groovy] danielsun1106 commented on a change in pull request #1645: GROOVY-10298: Refine records to not use system properties

2021-10-21 Thread GitBox
danielsun1106 commented on a change in pull request #1645: URL: https://github.com/apache/groovy/pull/1645#discussion_r734223821 ## File path: src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java ## @@ -1603,21 +1604,18 @@ public ClassNode visitClassDeclaration(final

[GitHub] [groovy] paulk-asert commented on a change in pull request #1645: GROOVY-10298: Refine records to not use system properties

2021-10-21 Thread GitBox
paulk-asert commented on a change in pull request #1645: URL: https://github.com/apache/groovy/pull/1645#discussion_r734125253 ## File path: src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java ## @@ -1603,21 +1604,18 @@ public ClassNode visitClassDeclaration(final

[GitHub] [groovy] danielsun1106 commented on a change in pull request #1645: GROOVY-10298: Refine records to not use system properties

2021-10-21 Thread GitBox
danielsun1106 commented on a change in pull request #1645: URL: https://github.com/apache/groovy/pull/1645#discussion_r734118172 ## File path: src/main/java/org/apache/groovy/parser/antlr4/AstBuilder.java ## @@ -1603,21 +1604,18 @@ public ClassNode visitClassDeclaration(final

[jira] [Commented] (GROOVY-6954) map.foo = "bar" not optimized by the static compiler

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432738#comment-17432738 ] Eric Milles commented on GROOVY-6954: - https://github.com/apache/groovy/pull/1646 > map.foo = "bar"

[GitHub] [groovy] eric-milles opened a new pull request #1646: GROOVY-6954: SC: optimize `map.foo = 'bar'` using `java.util.Map#put(K,V)`

2021-10-21 Thread GitBox
eric-milles opened a new pull request #1646: URL: https://github.com/apache/groovy/pull/1646 This does not cover `map['foo'] = 'bar'` which routes through "getAt" (by design). This also covers: ```groovy @groovy.transform.CompileStatic class C extends HashMap { void

[jira] [Assigned] (GROOVY-6954) map.foo = "bar" not optimized by the static compiler

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-6954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-6954: --- Assignee: Eric Milles > map.foo = "bar" not optimized by the static compiler >

[jira] [Updated] (GROOVY-5502) If/else branch does not always infer the variable type

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-5502: Affects Version/s: (was: 2.4.3) (was: 2.3.0) > If/else branch does

[jira] [Updated] (GROOVY-5502) If/else branch does not always infer the variable type

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-5502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-5502: Description: Suppose we have the following code: {code} class A { void m() { } } class B

[jira] [Resolved] (GROOVY-7690) TypeChecked Groovy does not throw illegal assignment error at compile time when using raw generic type

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles resolved GROOVY-7690. - Fix Version/s: 4.0.0-beta-2 Resolution: Fixed > TypeChecked Groovy does not throw

[jira] [Assigned] (GROOVY-7690) TypeChecked Groovy does not throw illegal assignment error at compile time when using raw generic type

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles reassigned GROOVY-7690: --- Assignee: Eric Milles > TypeChecked Groovy does not throw illegal assignment error at

[jira] [Updated] (GROOVY-10312) MissingMethodException in method with default parameter in trait - regression in 3.0.9

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-10312: - Fix Version/s: 3.0.10 > MissingMethodException in method with default parameter in trait -

[jira] [Updated] (GROOVY-10303) Compiler NPE within CompileStack#clear

2021-10-21 Thread Eric Milles (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Eric Milles updated GROOVY-10303: - Fix Version/s: 3.0.10 > Compiler NPE within CompileStack#clear >

[jira] [Commented] (GROOVY-10303) Compiler NPE within CompileStack#clear

2021-10-21 Thread David Estes (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10303?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17432449#comment-17432449 ] David Estes commented on GROOVY-10303: -- Can this be resolved in 3 as this breaks some grails apps

[jira] [Created] (GROOVY-10324) STC is unable to infer type variable when combining parameterized types and the diamond operator

2021-10-21 Thread Thodoris Sotiropoulos (Jira)
Thodoris Sotiropoulos created GROOVY-10324: -- Summary: STC is unable to infer type variable when combining parameterized types and the diamond operator Key: GROOVY-10324 URL:

[jira] [Created] (GROOVY-10323) Compiler crashes on parameterized function with duplicate type variables

2021-10-21 Thread Thodoris Sotiropoulos (Jira)
Thodoris Sotiropoulos created GROOVY-10323: -- Summary: Compiler crashes on parameterized function with duplicate type variables Key: GROOVY-10323 URL: https://issues.apache.org/jira/browse/GROOVY-10323

[jira] [Created] (GROOVY-10322) Type variable of function does not shadow the corresponding type variable of class

2021-10-21 Thread Thodoris Sotiropoulos (Jira)
Thodoris Sotiropoulos created GROOVY-10322: -- Summary: Type variable of function does not shadow the corresponding type variable of class Key: GROOVY-10322 URL: