[jira] [Commented] (GROOVY-10942) Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690845#comment-17690845 ] ASF GitHub Bot commented on GROOVY-10942: - Goooler commented on PR #1859: URL:

[GitHub] [groovy] Goooler commented on pull request #1859: GROOVY-10942 Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
Goooler commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435915780 GROOVY-10942 1. Agreed. 2. I misjudged `Path.getFileName()` to return a non-null String, will fix it later. 3. Will add a `getBaseName()`. -- This is an automated message fr

[jira] [Commented] (GROOVY-10881) FastStringUtils does not work in an OSGi environment

2023-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690843#comment-17690843 ] ASF GitHub Bot commented on GROOVY-10881: - royteeuwen closed pull request #1836

[jira] [Commented] (GROOVY-10881) FastStringUtils does not work in an OSGi environment

2023-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690844#comment-17690844 ] ASF GitHub Bot commented on GROOVY-10881: - royteeuwen commented on PR #1836: UR

[GitHub] [groovy] royteeuwen commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
royteeuwen commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915627 > @royteeuwen Should we close this now given the alternative fix? Done! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [groovy] royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
royteeuwen closed pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment URL: https://github.com/apache/groovy/pull/1836 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[jira] [Commented] (GROOVY-10881) FastStringUtils does not work in an OSGi environment

2023-02-18 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10881?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690842#comment-17690842 ] ASF GitHub Bot commented on GROOVY-10881: - paulk-asert commented on PR #1836: U

[GitHub] [groovy] paulk-asert commented on pull request #1836: GROOVY-10881: Make FastStringUtils work in an OSGi environment

2023-02-18 Thread via GitHub
paulk-asert commented on PR #1836: URL: https://github.com/apache/groovy/pull/1836#issuecomment-1435915335 @royteeuwen Should we close this now given the alternative fix? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[jira] [Commented] (GROOVY-10942) Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread Zongle Wang (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10942?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690841#comment-17690841 ] Zongle Wang commented on GROOVY-10942: -- https://github.com/apache/groovy/pull/1859

[jira] [Created] (GROOVY-10942) Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread Zongle Wang (Jira)
Zongle Wang created GROOVY-10942: Summary: Add `extension` & `nameWithoutExtension` extension methods Key: GROOVY-10942 URL: https://issues.apache.org/jira/browse/GROOVY-10942 Project: Groovy

[GitHub] [groovy] paulk-asert commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
paulk-asert commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435914481 I like the idea behind these extensions. Can you create a corresponding Jira issue? Also, some minor points: - I think using `getExtension` rather than `extension` would b

[GitHub] [groovy] paulk-asert merged pull request #1858: Defer more task configurations

2023-02-18 Thread via GitHub
paulk-asert merged PR #1858: URL: https://github.com/apache/groovy/pull/1858 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] codecov-commenter commented on pull request #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
codecov-commenter commented on PR #1859: URL: https://github.com/apache/groovy/pull/1859#issuecomment-1435771833 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1859?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw

[jira] [Commented] (GROOVY-10307) Groovy 4 runtime performance on average 2.4x slower than Groovy 3

2023-02-18 Thread mgroovy (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690823#comment-17690823 ] mgroovy commented on GROOVY-10307: -- [~emilles]: I will try to get to this asap, but we

[jira] (GROOVY-10307) Groovy 4 runtime performance on average 2.4x slower than Groovy 3

2023-02-18 Thread mgroovy (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10307 ] mgroovy deleted comment on GROOVY-10307: -- was (Author: emge): [~emilles]: The test project which I was finally able to extract from our code base & posted some time back is of no help in debug

[jira] [Commented] (GROOVY-10307) Groovy 4 runtime performance on average 2.4x slower than Groovy 3

2023-02-18 Thread mgroovy (Jira)
[ https://issues.apache.org/jira/browse/GROOVY-10307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690820#comment-17690820 ] mgroovy commented on GROOVY-10307: -- [~emilles]: The test project which I was finally a

[GitHub] [groovy] Goooler opened a new pull request, #1859: Add `extension` & `nameWithoutExtension` extension methods

2023-02-18 Thread via GitHub
Goooler opened a new pull request, #1859: URL: https://github.com/apache/groovy/pull/1859 Ref: https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/extension.html https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.io.path/java.nio.file.-path/name-without-ex

[GitHub] [groovy] codecov-commenter commented on pull request #1858: Defer more task configurations

2023-02-18 Thread via GitHub
codecov-commenter commented on PR #1858: URL: https://github.com/apache/groovy/pull/1858#issuecomment-1435757057 # [Codecov](https://codecov.io/gh/apache/groovy/pull/1858?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Softw