[GitHub] [groovy] daniellansun commented on pull request #1770: GROOVY-6668, GROOVY-8212, GROOVY-9617: STC: distance of `GString` for `String` target

2022-09-17 Thread GitBox
daniellansun commented on PR #1770: URL: https://github.com/apache/groovy/pull/1770#issuecomment-1250101219 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1770: GROOVY-6668, GROOVY-8212, GROOVY-9617: STC: distance of `GString` for `String` target

2022-09-17 Thread GitBox
daniellansun merged PR #1770: URL: https://github.com/apache/groovy/pull/1770 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] paulk-asert opened a new pull request, #1783: GROOVY-10759: groovy-datetime should support collections of fields wh…

2022-09-17 Thread GitBox
paulk-asert opened a new pull request, #1783: URL: https://github.com/apache/groovy/pull/1783 …en accessing a temporal accessor -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [groovy] daniellansun commented on pull request #1782: Minor improvements for Operators documentation

2022-09-17 Thread GitBox
daniellansun commented on PR #1782: URL: https://github.com/apache/groovy/pull/1782#issuecomment-1250074087 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1782: Minor improvements for Operators documentation

2022-09-17 Thread GitBox
daniellansun merged PR #1782: URL: https://github.com/apache/groovy/pull/1782 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] Alex-Golub opened a new pull request, #1782: Minor improvements for Operators documentation

2022-09-17 Thread GitBox
Alex-Golub opened a new pull request, #1782: URL: https://github.com/apache/groovy/pull/1782 See commit messages -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

[GitHub] [groovy] daniellansun commented on pull request #1778: GROOVY-7919: add `isCase(Iterable,Object)` for `in` and `!in` support

2022-09-17 Thread GitBox
daniellansun commented on PR #1778: URL: https://github.com/apache/groovy/pull/1778#issuecomment-1250035376 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1778: GROOVY-7919: add `isCase(Iterable,Object)` for `in` and `!in` support

2022-09-17 Thread GitBox
daniellansun merged PR #1778: URL: https://github.com/apache/groovy/pull/1778 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun commented on pull request #1779: GROOVY-7992: DGM: `Comparator` for comparator parameters

2022-09-17 Thread GitBox
daniellansun commented on PR #1779: URL: https://github.com/apache/groovy/pull/1779#issuecomment-1250031627 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1779: GROOVY-7992: DGM: `Comparator` for comparator parameters

2022-09-17 Thread GitBox
daniellansun merged PR #1779: URL: https://github.com/apache/groovy/pull/1779 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun merged pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

2022-09-05 Thread GitBox
daniellansun merged PR #1781: URL: https://github.com/apache/groovy/pull/1781 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun commented on a diff in pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

2022-09-05 Thread GitBox
daniellansun commented on code in PR #1781: URL: https://github.com/apache/groovy/pull/1781#discussion_r962830207 ## src/main/java/org/codehaus/groovy/runtime/ArrayUtil.java: ## @@ -61,31 +55,32 @@ public class ArrayUtil { private static final Object[] EMPTY = new Object[0

[GitHub] [groovy] daniellansun commented on pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

2022-09-05 Thread GitBox
daniellansun commented on PR #1781: URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236902735 @paulk-asert Thanks for your reviewing. I'll tweak it a bit later -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [groovy] paulk-asert commented on pull request #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

2022-09-05 Thread GitBox
paulk-asert commented on PR #1781: URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236896656 LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [groovy] daniellansun opened a new pull request, #1781: GROOVY-10747: Fix illegal access for object clone on JDK16+

2022-09-04 Thread GitBox
daniellansun opened a new pull request, #1781: URL: https://github.com/apache/groovy/pull/1781 https://issues.apache.org/jira/browse/GROOVY-10747 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [groovy] Goooler commented on a diff in pull request #1780: Migrate buildSrc to composite build

2022-09-02 Thread GitBox
Goooler commented on code in PR #1780: URL: https://github.com/apache/groovy/pull/1780#discussion_r962105007 ## build.gradle: ## @@ -35,11 +35,6 @@ buildScanRecipes { archivesBaseName = 'groovy' -repositories { -// todo Some repos are needed only for some configs. Decla

[GitHub] [groovy] Goooler opened a new pull request, #1780: Migrate buildSrc to composite build

2022-09-02 Thread GitBox
Goooler opened a new pull request, #1780: URL: https://github.com/apache/groovy/pull/1780 Ref https://github.com/detekt/detekt/pull/4090 https://docs.gradle.org/7.5.1/userguide/composite_builds.html -- This is an automated message from the Apache Git Service. To respond to the messa

[GitHub] [groovy] eric-milles opened a new pull request, #1779: GROOVY-7992: DGM: `Comparator` for comparator parameters

2022-09-02 Thread GitBox
eric-milles opened a new pull request, #1779: URL: https://github.com/apache/groovy/pull/1779 https://issues.apache.org/jira/browse/GROOVY-7992 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [groovy] eric-milles opened a new pull request, #1778: GROOVY-7919: add `isCase(Iterable,Object)` for `in` and `!in` support

2022-09-02 Thread GitBox
eric-milles opened a new pull request, #1778: URL: https://github.com/apache/groovy/pull/1778 https://issues.apache.org/jira/browse/GROOVY-7919 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [groovy] paulk-asert merged pull request #1777: GROOVY-10737: Groovydoc deprecation list page is always empty even if…

2022-09-02 Thread GitBox
paulk-asert merged PR #1777: URL: https://github.com/apache/groovy/pull/1777 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert merged pull request #1776: GROOVY-10743: The use method for Category classes can't take an inter…

2022-09-02 Thread GitBox
paulk-asert merged PR #1776: URL: https://github.com/apache/groovy/pull/1776 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert merged pull request #1775: GROOVY-10739: Improve error message for malformed grab coordinate

2022-09-02 Thread GitBox
paulk-asert merged PR #1775: URL: https://github.com/apache/groovy/pull/1775 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] erdi commented on pull request #1777: GROOVY-10737: Groovydoc deprecation list page is always empty even if…

2022-09-02 Thread GitBox
erdi commented on PR #1777: URL: https://github.com/apache/groovy/pull/1777#issuecomment-1235877264 LGTM, thanks for fixing so quickly! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [groovy] paulk-asert opened a new pull request, #1777: GROOVY-10737: Groovydoc deprecation list page is always empty even if…

2022-09-02 Thread GitBox
paulk-asert opened a new pull request, #1777: URL: https://github.com/apache/groovy/pull/1777 … @deprecated is used in groovydoc comments on some elements -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [groovy] paulk-asert opened a new pull request, #1776: GROOVY-10743: The use method for Category classes can't take an inter…

2022-09-01 Thread GitBox
paulk-asert opened a new pull request, #1776: URL: https://github.com/apache/groovy/pull/1776 …face with static methods due to a NPE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [groovy] paulk-asert commented on pull request #311: Generate tuple constructor with all args and annotations

2022-08-29 Thread GitBox
paulk-asert commented on PR #311: URL: https://github.com/apache/groovy/pull/311#issuecomment-1231169948 I know it doesn't cover all use cases, but for records in Groovy 4, annotations on the record are carried over to the constructor if placed on the record. It would cover the original use

[GitHub] [groovy] paulk-asert commented on pull request #312: GROOVY-7814: Support Arrays of arbitrary annotations as the return ty…

2022-08-29 Thread GitBox
paulk-asert commented on PR #312: URL: https://github.com/apache/groovy/pull/312#issuecomment-1231162382 I'll close this for now. I think it is a nice feature but we have other changes for annotations with higher priority, so we can come back to this at a later date if we progress other ite

[GitHub] [groovy] paulk-asert closed pull request #312: GROOVY-7814: Support Arrays of arbitrary annotations as the return ty…

2022-08-29 Thread GitBox
paulk-asert closed pull request #312: GROOVY-7814: Support Arrays of arbitrary annotations as the return ty… URL: https://github.com/apache/groovy/pull/312 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [groovy] paulk-asert merged pull request #1774: GROOVY-10732: @Immutable handling of cloneable types should have the …

2022-08-29 Thread GitBox
paulk-asert merged PR #1774: URL: https://github.com/apache/groovy/pull/1774 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert commented on pull request #1773: GitHub Workflows security hardening

2022-08-29 Thread GitBox
paulk-asert commented on PR #1773: URL: https://github.com/apache/groovy/pull/1773#issuecomment-1230140637 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [groovy] paulk-asert merged pull request #1773: GitHub Workflows security hardening

2022-08-29 Thread GitBox
paulk-asert merged PR #1773: URL: https://github.com/apache/groovy/pull/1773 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert opened a new pull request, #1774: GROOVY-10732: @Immutable handling of cloneable types should have the …

2022-08-29 Thread GitBox
paulk-asert opened a new pull request, #1774: URL: https://github.com/apache/groovy/pull/1774 …same behavior for non-cloneables on JDK16+ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [groovy] sashashura opened a new pull request, #1773: GitHub Workflows security hardening

2022-08-29 Thread GitBox
sashashura opened a new pull request, #1773: URL: https://github.com/apache/groovy/pull/1773 This PR adds explicit [permissions section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions) to workflows. This is a security best practice because

[GitHub] [groovy] daniellansun commented on pull request #1772: Bump Gradle Enterprise plugin to 3.11.1

2022-08-28 Thread GitBox
daniellansun commented on PR #1772: URL: https://github.com/apache/groovy/pull/1772#issuecomment-1229845573 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1772: Bump Gradle Enterprise plugin to 3.11.1

2022-08-28 Thread GitBox
daniellansun merged PR #1772: URL: https://github.com/apache/groovy/pull/1772 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] Goooler opened a new pull request, #1772: Bump Gradle Enterprise plugin to 3.11.1

2022-08-28 Thread GitBox
Goooler opened a new pull request, #1772: URL: https://github.com/apache/groovy/pull/1772 Follow up #1771. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e

[GitHub] [groovy] daniellansun merged pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun merged PR #1771: URL: https://github.com/apache/groovy/pull/1771 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun commented on pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on PR #1771: URL: https://github.com/apache/groovy/pull/1771#issuecomment-1229478272 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956725378 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956722628 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956722628 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
paulk-asert commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956713473 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offend

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956701779 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956701779 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-28 Thread GitBox
paulk-asert commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956682803 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offend

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956661653 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956660505 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
paulk-asert commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956653531 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offend

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
paulk-asert commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956653365 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offend

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956590276 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] daniellansun commented on a diff in pull request #1771: GROOVY-10730: Bump Gradle to 7.5.1

2022-08-27 Thread GitBox
daniellansun commented on code in PR #1771: URL: https://github.com/apache/groovy/pull/1771#discussion_r956590276 ## buildSrc/src/main/groovy/org.apache.groovy-tested.gradle: ## @@ -32,12 +32,18 @@ sourceSets { } } +// TODO remove the jdk16+ add-opens jvm args once offen

[GitHub] [groovy] paulk-asert merged pull request #1769: GROOVY-10728: Enhance groovy-dateutil extensions to support collectio…

2022-08-24 Thread GitBox
paulk-asert merged PR #1769: URL: https://github.com/apache/groovy/pull/1769 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] eric-milles opened a new pull request, #1770: GROOVY-6668: STC: reduce distance of `GString` for `String` target

2022-08-24 Thread GitBox
eric-milles opened a new pull request, #1770: URL: https://github.com/apache/groovy/pull/1770 Here is the more controversial change of https://github.com/apache/groovy/pull/1766 so it can be debated/evaluated in isolation. A small change in `StaticTypeCheckingSupport#getDistance` can

[GitHub] [groovy] paulk-asert opened a new pull request, #1769: GROOVY-10728: Enhance groovy-dateutil extensions to support collectio…

2022-08-24 Thread GitBox
paulk-asert opened a new pull request, #1769: URL: https://github.com/apache/groovy/pull/1769 …ns of indices when accessing Calendar/Date -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [groovy] eric-milles merged pull request #1768: GROOVY-8788: STC: prefer closer parameter match over receiver-type match

2022-08-23 Thread GitBox
eric-milles merged PR #1768: URL: https://github.com/apache/groovy/pull/1768 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] eric-milles commented on pull request #1601: GROOVY-10099: Resolve ambiguous varargs behaviour in dynamic mode by recourse to compiler-stage information

2022-08-23 Thread GitBox
eric-milles commented on PR #1601: URL: https://github.com/apache/groovy/pull/1601#issuecomment-1224298737 -1 for me I will look over your tests and see about adding them to the build at least to demonstrate GROOVY-10099. `InvocationWriter#loadArguments` already has significant

[GitHub] [groovy] eric-milles closed pull request #1601: GROOVY-10099: Resolve ambiguous varargs behaviour in dynamic mode by recourse to compiler-stage information

2022-08-23 Thread GitBox
eric-milles closed pull request #1601: GROOVY-10099: Resolve ambiguous varargs behaviour in dynamic mode by recourse to compiler-stage information URL: https://github.com/apache/groovy/pull/1601 -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [groovy] paulk-asert commented on pull request #1764: Gradle tweaks

2022-08-22 Thread GitBox
paulk-asert commented on PR #1764: URL: https://github.com/apache/groovy/pull/1764#issuecomment-1223483559 Merged. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [groovy] paulk-asert merged pull request #1764: Gradle tweaks

2022-08-22 Thread GitBox
paulk-asert merged PR #1764: URL: https://github.com/apache/groovy/pull/1764 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] eric-milles closed pull request #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match

2022-08-21 Thread GitBox
eric-milles closed pull request #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match URL: https://github.com/apache/groovy/pull/1766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [groovy] eric-milles opened a new pull request, #1768: GROOVY-8788: STC: prefer closer parameter match over receiver-type match

2022-08-21 Thread GitBox
eric-milles opened a new pull request, #1768: URL: https://github.com/apache/groovy/pull/1768 Given choice between methods m(String,Object) and m(Object,String), prefer closer parameter matching. This aligns with the method selection of the dynamic runtime. There is much more discussion of

[GitHub] [groovy] eric-milles opened a new pull request, #1767: GROOVY-8283: field hides getter of super class (not interface)

2022-08-19 Thread GitBox
eric-milles opened a new pull request, #1767: URL: https://github.com/apache/groovy/pull/1767 For the dynamic side of 8283, field can be selected in `MetaClassImpl`. If access method is declared by an interface, the interface method is the one indexed so it is considered pervasive in the t

[GitHub] [groovy] daniellansun commented on pull request #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match

2022-08-19 Thread GitBox
daniellansun commented on PR #1766: URL: https://github.com/apache/groovy/pull/1766#issuecomment-1220335936 I am keen to vote +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [groovy] eric-milles commented on pull request #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match

2022-08-18 Thread GitBox
eric-milles commented on PR #1766: URL: https://github.com/apache/groovy/pull/1766#issuecomment-1219738720 With the addition of `getAt(Map,String)` a small change in `StaticTypeCheckingSupport#getDistance` can resolve the `map["$key"]` issues. I know Cedric stated in 6668 that this should

[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match

2022-08-17 Thread GitBox
sonatype-lift[bot] commented on code in PR #1766: URL: https://github.com/apache/groovy/pull/1766#discussion_r948409220 ## src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java: ## @@ -1103,6 +1104,21 @@ Person foo(B b) {} onlyExtens

[GitHub] [groovy] eric-milles opened a new pull request, #1766: GROOVY-8788: STC: prefer closer parameter match over self-type match

2022-08-17 Thread GitBox
eric-milles opened a new pull request, #1766: URL: https://github.com/apache/groovy/pull/1766 Given choice between extension methods `m(String,Object)` and `m(Object,String)`, prefer closer parameter matching. This aligns with the method selection of the dynamic runtime. So there are some

[GitHub] [groovy] paulk-asert commented on pull request #1764: Gradle tweaks

2022-08-16 Thread GitBox
paulk-asert commented on PR #1764: URL: https://github.com/apache/groovy/pull/1764#issuecomment-1216532089 Most of the commits seem okay. I'll wait a little longer for any other feedback and I want to try a few more things. -- This is an automated message from the Apache Git Service. To r

[GitHub] [groovy] paulk-asert commented on pull request #1762: GROOVY-10713 Document ClassCodeExpressionTransformer limitation when dealing with Closure.

2022-08-16 Thread GitBox
paulk-asert commented on PR #1762: URL: https://github.com/apache/groovy/pull/1762#issuecomment-1216529378 I've merged and plan to tweak the wording very slightly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [groovy] paulk-asert merged pull request #1762: GROOVY-10713 Document ClassCodeExpressionTransformer limitation when dealing with Closure.

2022-08-16 Thread GitBox
paulk-asert merged PR #1762: URL: https://github.com/apache/groovy/pull/1762 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert merged pull request #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-16 Thread GitBox
paulk-asert merged PR #1765: URL: https://github.com/apache/groovy/pull/1765 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-14 Thread GitBox
sonatype-lift[bot] commented on code in PR #1765: URL: https://github.com/apache/groovy/pull/1765#discussion_r945363680 ## src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java: ## @@ -562,6 +565,181 @@ public static List primitiveArrayToList(Obje

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-14 Thread GitBox
paulk-asert commented on code in PR #1765: URL: https://github.com/apache/groovy/pull/1765#discussion_r945363666 ## src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java: ## @@ -562,6 +565,181 @@ public static List primitiveArrayToList(Object arra

[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-14 Thread GitBox
sonatype-lift[bot] commented on code in PR #1765: URL: https://github.com/apache/groovy/pull/1765#discussion_r945299722 ## src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java: ## @@ -562,6 +565,181 @@ public static List primitiveArrayToList(Obje

[GitHub] [groovy] paulk-asert commented on pull request #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-14 Thread GitBox
paulk-asert commented on PR #1765: URL: https://github.com/apache/groovy/pull/1765#issuecomment-1214389544 Applies the same treatment also to some primitive toSet operations which were double copying. -- This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [groovy] paulk-asert commented on pull request #1756: GROOVY-5744, GROOVY-10666: multi-assign via `iterator()` or `getAt(int)`

2022-08-14 Thread GitBox
paulk-asert commented on PR #1756: URL: https://github.com/apache/groovy/pull/1756#issuecomment-1214388826 On my list to look at tomorrow. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [groovy] paulk-asert opened a new pull request, #1765: GROOVY-10710: operator == is slow when comparing primitive arrays and…

2022-08-14 Thread GitBox
paulk-asert opened a new pull request, #1765: URL: https://github.com/apache/groovy/pull/1765 … lists -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail

[GitHub] [groovy] Goooler commented on a diff in pull request #1764: Gradle tweaks

2022-08-13 Thread GitBox
Goooler commented on code in PR #1764: URL: https://github.com/apache/groovy/pull/1764#discussion_r945217603 ## buildSrc/src/main/groovy/org.apache.groovy-common.gradle: ## @@ -42,10 +42,6 @@ group = 'org.apache.groovy' version = sharedConfiguration.groovyVersion.get() repos

[GitHub] [groovy] daniellansun commented on pull request #1763: Use gradle-build-action on CI

2022-08-13 Thread GitBox
daniellansun commented on PR #1763: URL: https://github.com/apache/groovy/pull/1763#issuecomment-1214240200 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1763: Use gradle-build-action on CI

2022-08-13 Thread GitBox
daniellansun merged PR #1763: URL: https://github.com/apache/groovy/pull/1763 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] Goooler opened a new pull request, #1763: Use gradle-build-action on GHA

2022-08-13 Thread GitBox
Goooler opened a new pull request, #1763: URL: https://github.com/apache/groovy/pull/1763 Use [gradle-build-action](https://github.com/gradle/gradle-build-action) to speed up build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[GitHub] [groovy] daniellansun commented on pull request #1761: Perf tweaks

2022-08-12 Thread GitBox
daniellansun commented on PR #1761: URL: https://github.com/apache/groovy/pull/1761#issuecomment-1213120290 Merged. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[GitHub] [groovy] daniellansun merged pull request #1761: Perf tweaks

2022-08-12 Thread GitBox
daniellansun merged PR #1761: URL: https://github.com/apache/groovy/pull/1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] sonatype-lift[bot] commented on a diff in pull request #1761: Perf tweaks

2022-08-10 Thread GitBox
sonatype-lift[bot] commented on code in PR #1761: URL: https://github.com/apache/groovy/pull/1761#discussion_r942401268 ## subprojects/performance/src/files/pleac01_04.groovy: ## @@ -0,0 +1,1702 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more

[GitHub] [groovy] paulk-asert commented on a diff in pull request #1761: Perf tweaks

2022-08-10 Thread GitBox
paulk-asert commented on code in PR #1761: URL: https://github.com/apache/groovy/pull/1761#discussion_r942401156 ## subprojects/performance/src/files/pleac01_04.groovy: ## @@ -0,0 +1,1702 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contrib

[GitHub] [groovy] eric-milles opened a new pull request, #1760: GROOVY-10278: `CompilerConfiguration`: improve target bytecode selection

2022-08-06 Thread GitBox
eric-milles opened a new pull request, #1760: URL: https://github.com/apache/groovy/pull/1760 As described in GROOVY-10278, select the nearest target bytecode version. As described on the mailing list, set minimum Java to 11 for Groovy 5. This sets the stage for using nestmates ([JEP-181]

[GitHub] [groovy] daniellansun merged pull request #1758: GROOVY-10715: Make StreamingTemplateEngine support reusing ClassLoader

2022-08-05 Thread GitBox
daniellansun merged PR #1758: URL: https://github.com/apache/groovy/pull/1758 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] daniellansun merged pull request #1759: GROOVY-10719: Bump javaparser to 3.24.4

2022-08-04 Thread GitBox
daniellansun merged PR #1759: URL: https://github.com/apache/groovy/pull/1759 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@

[GitHub] [groovy] blackdrag commented on pull request #1756: GROOVY-5744, GROOVY-10666: multi-assign via `iterator()` or `getAt(int)`

2022-08-04 Thread GitBox
blackdrag commented on PR #1756: URL: https://github.com/apache/groovy/pull/1756#issuecomment-1205300751 I don't see changes from double quotes to single quotes as formatting change, nor do I see a change from {} to {->} as such a change. So where any of these changes required for this code

[GitHub] [groovy] daniellansun opened a new pull request, #1758: GROOVY-10715: Make StreamingTemplateEngine support reusing ClassLoader

2022-08-02 Thread GitBox
daniellansun opened a new pull request, #1758: URL: https://github.com/apache/groovy/pull/1758 https://issues.apache.org/jira/browse/GROOVY-10715 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

[GitHub] [groovy] paulk-asert commented on pull request #1757: GROOVY-10709: Performance regression in Gradle with Groovy 4

2022-08-01 Thread GitBox
paulk-asert commented on PR #1757: URL: https://github.com/apache/groovy/pull/1757#issuecomment-1201814479 Merged. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [groovy] paulk-asert merged pull request #1757: GROOVY-10709: Performance regression in Gradle with Groovy 4

2022-08-01 Thread GitBox
paulk-asert merged PR #1757: URL: https://github.com/apache/groovy/pull/1757 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] daniellansun commented on pull request #1757: GROOVY-10709: Performance regression in Gradle with Groovy 4

2022-08-01 Thread GitBox
daniellansun commented on PR #1757: URL: https://github.com/apache/groovy/pull/1757#issuecomment-1201187879 +1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [groovy] eric-milles opened a new pull request, #1756: GROOVY-5744, GROOVY-10666: multi-assign via `iterator()` or `getAt(int)`

2022-07-31 Thread GitBox
eric-milles opened a new pull request, #1756: URL: https://github.com/apache/groovy/pull/1756 Support multi-assign for `Stream` and `Iterator`. Improve efficiency of multi-assign for types like `Set` and `Collection` which do not support direct indexing. Translate "def (one,two) = r

[GitHub] [groovy] eric-milles merged pull request #1755: GROOVY-10695: `Type.name` within `Type` gets explicit-`this` treatment

2022-07-29 Thread GitBox
eric-milles merged PR #1755: URL: https://github.com/apache/groovy/pull/1755 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

[GitHub] [groovy] paulk-asert closed pull request #1752: Persist the order of methods

2022-07-26 Thread GitBox
paulk-asert closed pull request #1752: Persist the order of methods URL: https://github.com/apache/groovy/pull/1752 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscri

[GitHub] [groovy] paulk-asert commented on pull request #1752: Persist the order of methods

2022-07-26 Thread GitBox
paulk-asert commented on PR #1752: URL: https://github.com/apache/groovy/pull/1752#issuecomment-1196274360 Merged, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [groovy] paulk-asert closed pull request #1753: sort the methods from the trait when generating methods

2022-07-26 Thread GitBox
paulk-asert closed pull request #1753: sort the methods from the trait when generating methods URL: https://github.com/apache/groovy/pull/1753 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [groovy] paulk-asert commented on pull request #1753: sort the methods from the trait when generating methods

2022-07-26 Thread GitBox
paulk-asert commented on PR #1753: URL: https://github.com/apache/groovy/pull/1753#issuecomment-1196273964 I think the other offered solution is preferred in terms of styling with the rest of the Groovy codebase. We don't sort except in very particular circumstances. -- This is an automa

[GitHub] [groovy] eric-milles opened a new pull request, #1755: GROOVY-10695: `Type.name` within `Type` gets explicit-`this` treatment

2022-07-26 Thread GitBox
eric-milles opened a new pull request, #1755: URL: https://github.com/apache/groovy/pull/1755 Provides consistent handling for read and write access of static fields: ```groovy class Type { private static field static getField() { // not used } static sm() {

[GitHub] [groovy] paulk-asert merged pull request #1754: GROOVY-10705: ToString order bug for super properties

2022-07-26 Thread GitBox
paulk-asert merged PR #1754: URL: https://github.com/apache/groovy/pull/1754 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@g

<    1   2   3   4   5   6   7   8   9   10   >