daniellansun commented on PR #1770:
URL: https://github.com/apache/groovy/pull/1770#issuecomment-1250101219
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1770:
URL: https://github.com/apache/groovy/pull/1770
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
paulk-asert opened a new pull request, #1783:
URL: https://github.com/apache/groovy/pull/1783
…en accessing a temporal accessor
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific commen
daniellansun commented on PR #1782:
URL: https://github.com/apache/groovy/pull/1782#issuecomment-1250074087
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1782:
URL: https://github.com/apache/groovy/pull/1782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Alex-Golub opened a new pull request, #1782:
URL: https://github.com/apache/groovy/pull/1782
See commit messages
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
daniellansun commented on PR #1778:
URL: https://github.com/apache/groovy/pull/1778#issuecomment-1250035376
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1778:
URL: https://github.com/apache/groovy/pull/1778
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #1779:
URL: https://github.com/apache/groovy/pull/1779#issuecomment-1250031627
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1779:
URL: https://github.com/apache/groovy/pull/1779
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #1781:
URL: https://github.com/apache/groovy/pull/1781
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on code in PR #1781:
URL: https://github.com/apache/groovy/pull/1781#discussion_r962830207
##
src/main/java/org/codehaus/groovy/runtime/ArrayUtil.java:
##
@@ -61,31 +55,32 @@
public class ArrayUtil {
private static final Object[] EMPTY = new Object[0
daniellansun commented on PR #1781:
URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236902735
@paulk-asert Thanks for your reviewing. I'll tweak it a bit later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
paulk-asert commented on PR #1781:
URL: https://github.com/apache/groovy/pull/1781#issuecomment-1236896656
LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
daniellansun opened a new pull request, #1781:
URL: https://github.com/apache/groovy/pull/1781
https://issues.apache.org/jira/browse/GROOVY-10747
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
Goooler commented on code in PR #1780:
URL: https://github.com/apache/groovy/pull/1780#discussion_r962105007
##
build.gradle:
##
@@ -35,11 +35,6 @@ buildScanRecipes {
archivesBaseName = 'groovy'
-repositories {
-// todo Some repos are needed only for some configs. Decla
Goooler opened a new pull request, #1780:
URL: https://github.com/apache/groovy/pull/1780
Ref https://github.com/detekt/detekt/pull/4090
https://docs.gradle.org/7.5.1/userguide/composite_builds.html
--
This is an automated message from the Apache Git Service.
To respond to the messa
eric-milles opened a new pull request, #1779:
URL: https://github.com/apache/groovy/pull/1779
https://issues.apache.org/jira/browse/GROOVY-7992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
eric-milles opened a new pull request, #1778:
URL: https://github.com/apache/groovy/pull/1778
https://issues.apache.org/jira/browse/GROOVY-7919
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
paulk-asert merged PR #1777:
URL: https://github.com/apache/groovy/pull/1777
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #1776:
URL: https://github.com/apache/groovy/pull/1776
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #1775:
URL: https://github.com/apache/groovy/pull/1775
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
erdi commented on PR #1777:
URL: https://github.com/apache/groovy/pull/1777#issuecomment-1235877264
LGTM, thanks for fixing so quickly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
paulk-asert opened a new pull request, #1777:
URL: https://github.com/apache/groovy/pull/1777
… @deprecated is used in groovydoc comments on some elements
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
paulk-asert opened a new pull request, #1776:
URL: https://github.com/apache/groovy/pull/1776
…face with static methods due to a NPE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
paulk-asert commented on PR #311:
URL: https://github.com/apache/groovy/pull/311#issuecomment-1231169948
I know it doesn't cover all use cases, but for records in Groovy 4,
annotations on the record are carried over to the constructor if placed on the
record. It would cover the original use
paulk-asert commented on PR #312:
URL: https://github.com/apache/groovy/pull/312#issuecomment-1231162382
I'll close this for now. I think it is a nice feature but we have other
changes for annotations with higher priority, so we can come back to this at a
later date if we progress other ite
paulk-asert closed pull request #312: GROOVY-7814: Support Arrays of arbitrary
annotations as the return ty…
URL: https://github.com/apache/groovy/pull/312
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
paulk-asert merged PR #1774:
URL: https://github.com/apache/groovy/pull/1774
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert commented on PR #1773:
URL: https://github.com/apache/groovy/pull/1773#issuecomment-1230140637
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert merged PR #1773:
URL: https://github.com/apache/groovy/pull/1773
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert opened a new pull request, #1774:
URL: https://github.com/apache/groovy/pull/1774
…same behavior for non-cloneables on JDK16+
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
sashashura opened a new pull request, #1773:
URL: https://github.com/apache/groovy/pull/1773
This PR adds explicit [permissions
section](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#permissions)
to workflows. This is a security best practice because
daniellansun commented on PR #1772:
URL: https://github.com/apache/groovy/pull/1772#issuecomment-1229845573
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1772:
URL: https://github.com/apache/groovy/pull/1772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Goooler opened a new pull request, #1772:
URL: https://github.com/apache/groovy/pull/1772
Follow up #1771.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e
daniellansun merged PR #1771:
URL: https://github.com/apache/groovy/pull/1771
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun commented on PR #1771:
URL: https://github.com/apache/groovy/pull/1771#issuecomment-1229478272
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956725378
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956722628
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956722628
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
paulk-asert commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956713473
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offend
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956701779
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956701779
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
paulk-asert commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956682803
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offend
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956661653
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956660505
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
paulk-asert commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956653531
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offend
paulk-asert commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956653365
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offend
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956590276
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
daniellansun commented on code in PR #1771:
URL: https://github.com/apache/groovy/pull/1771#discussion_r956590276
##
buildSrc/src/main/groovy/org.apache.groovy-tested.gradle:
##
@@ -32,12 +32,18 @@ sourceSets {
}
}
+// TODO remove the jdk16+ add-opens jvm args once offen
paulk-asert merged PR #1769:
URL: https://github.com/apache/groovy/pull/1769
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles opened a new pull request, #1770:
URL: https://github.com/apache/groovy/pull/1770
Here is the more controversial change of
https://github.com/apache/groovy/pull/1766 so it can be debated/evaluated in
isolation.
A small change in `StaticTypeCheckingSupport#getDistance` can
paulk-asert opened a new pull request, #1769:
URL: https://github.com/apache/groovy/pull/1769
…ns of indices when accessing Calendar/Date
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
eric-milles merged PR #1768:
URL: https://github.com/apache/groovy/pull/1768
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles commented on PR #1601:
URL: https://github.com/apache/groovy/pull/1601#issuecomment-1224298737
-1 for me
I will look over your tests and see about adding them to the build at least
to demonstrate GROOVY-10099.
`InvocationWriter#loadArguments` already has significant
eric-milles closed pull request #1601: GROOVY-10099: Resolve ambiguous varargs
behaviour in dynamic mode by recourse to compiler-stage information
URL: https://github.com/apache/groovy/pull/1601
--
This is an automated message from the Apache Git Service.
To respond to the message, please log
paulk-asert commented on PR #1764:
URL: https://github.com/apache/groovy/pull/1764#issuecomment-1223483559
Merged. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert merged PR #1764:
URL: https://github.com/apache/groovy/pull/1764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
eric-milles closed pull request #1766: GROOVY-8788: STC: prefer closer
parameter match over self-type match
URL: https://github.com/apache/groovy/pull/1766
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
eric-milles opened a new pull request, #1768:
URL: https://github.com/apache/groovy/pull/1768
Given choice between methods m(String,Object) and m(Object,String), prefer
closer parameter matching. This aligns with the method selection of the dynamic
runtime. There is much more discussion of
eric-milles opened a new pull request, #1767:
URL: https://github.com/apache/groovy/pull/1767
For the dynamic side of 8283, field can be selected in `MetaClassImpl`. If
access method is declared by an interface, the interface method is the one
indexed so it is considered pervasive in the t
daniellansun commented on PR #1766:
URL: https://github.com/apache/groovy/pull/1766#issuecomment-1220335936
I am keen to vote +1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific c
eric-milles commented on PR #1766:
URL: https://github.com/apache/groovy/pull/1766#issuecomment-1219738720
With the addition of `getAt(Map,String)` a small change in
`StaticTypeCheckingSupport#getDistance` can resolve the `map["$key"]` issues.
I know Cedric stated in 6668 that this should
sonatype-lift[bot] commented on code in PR #1766:
URL: https://github.com/apache/groovy/pull/1766#discussion_r948409220
##
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingSupport.java:
##
@@ -1103,6 +1104,21 @@ Person foo(B b) {}
onlyExtens
eric-milles opened a new pull request, #1766:
URL: https://github.com/apache/groovy/pull/1766
Given choice between extension methods `m(String,Object)` and
`m(Object,String)`, prefer closer parameter matching. This aligns with the
method selection of the dynamic runtime. So there are some
paulk-asert commented on PR #1764:
URL: https://github.com/apache/groovy/pull/1764#issuecomment-1216532089
Most of the commits seem okay. I'll wait a little longer for any other
feedback and I want to try a few more things.
--
This is an automated message from the Apache Git Service.
To r
paulk-asert commented on PR #1762:
URL: https://github.com/apache/groovy/pull/1762#issuecomment-1216529378
I've merged and plan to tweak the wording very slightly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
paulk-asert merged PR #1762:
URL: https://github.com/apache/groovy/pull/1762
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert merged PR #1765:
URL: https://github.com/apache/groovy/pull/1765
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
sonatype-lift[bot] commented on code in PR #1765:
URL: https://github.com/apache/groovy/pull/1765#discussion_r945363680
##
src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java:
##
@@ -562,6 +565,181 @@ public static List primitiveArrayToList(Obje
paulk-asert commented on code in PR #1765:
URL: https://github.com/apache/groovy/pull/1765#discussion_r945363666
##
src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java:
##
@@ -562,6 +565,181 @@ public static List primitiveArrayToList(Object arra
sonatype-lift[bot] commented on code in PR #1765:
URL: https://github.com/apache/groovy/pull/1765#discussion_r945299722
##
src/main/java/org/codehaus/groovy/runtime/typehandling/DefaultTypeTransformation.java:
##
@@ -562,6 +565,181 @@ public static List primitiveArrayToList(Obje
paulk-asert commented on PR #1765:
URL: https://github.com/apache/groovy/pull/1765#issuecomment-1214389544
Applies the same treatment also to some primitive toSet operations which
were double copying.
--
This is an automated message from the Apache Git Service.
To respond to the message,
paulk-asert commented on PR #1756:
URL: https://github.com/apache/groovy/pull/1756#issuecomment-1214388826
On my list to look at tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spec
paulk-asert opened a new pull request, #1765:
URL: https://github.com/apache/groovy/pull/1765
… lists
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail
Goooler commented on code in PR #1764:
URL: https://github.com/apache/groovy/pull/1764#discussion_r945217603
##
buildSrc/src/main/groovy/org.apache.groovy-common.gradle:
##
@@ -42,10 +42,6 @@ group = 'org.apache.groovy'
version = sharedConfiguration.groovyVersion.get()
repos
daniellansun commented on PR #1763:
URL: https://github.com/apache/groovy/pull/1763#issuecomment-1214240200
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1763:
URL: https://github.com/apache/groovy/pull/1763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
Goooler opened a new pull request, #1763:
URL: https://github.com/apache/groovy/pull/1763
Use [gradle-build-action](https://github.com/gradle/gradle-build-action) to
speed up build.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Gi
daniellansun commented on PR #1761:
URL: https://github.com/apache/groovy/pull/1761#issuecomment-1213120290
Merged. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
daniellansun merged PR #1761:
URL: https://github.com/apache/groovy/pull/1761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
sonatype-lift[bot] commented on code in PR #1761:
URL: https://github.com/apache/groovy/pull/1761#discussion_r942401268
##
subprojects/performance/src/files/pleac01_04.groovy:
##
@@ -0,0 +1,1702 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
paulk-asert commented on code in PR #1761:
URL: https://github.com/apache/groovy/pull/1761#discussion_r942401156
##
subprojects/performance/src/files/pleac01_04.groovy:
##
@@ -0,0 +1,1702 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contrib
eric-milles opened a new pull request, #1760:
URL: https://github.com/apache/groovy/pull/1760
As described in GROOVY-10278, select the nearest target bytecode version.
As described on the mailing list, set minimum Java to 11 for Groovy 5. This
sets the stage for using nestmates ([JEP-181]
daniellansun merged PR #1758:
URL: https://github.com/apache/groovy/pull/1758
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
daniellansun merged PR #1759:
URL: https://github.com/apache/groovy/pull/1759
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@
blackdrag commented on PR #1756:
URL: https://github.com/apache/groovy/pull/1756#issuecomment-1205300751
I don't see changes from double quotes to single quotes as formatting
change, nor do I see a change from {} to {->} as such a change. So where any of
these changes required for this code
daniellansun opened a new pull request, #1758:
URL: https://github.com/apache/groovy/pull/1758
https://issues.apache.org/jira/browse/GROOVY-10715
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
paulk-asert commented on PR #1757:
URL: https://github.com/apache/groovy/pull/1757#issuecomment-1201814479
Merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
paulk-asert merged PR #1757:
URL: https://github.com/apache/groovy/pull/1757
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
daniellansun commented on PR #1757:
URL: https://github.com/apache/groovy/pull/1757#issuecomment-1201187879
+1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
eric-milles opened a new pull request, #1756:
URL: https://github.com/apache/groovy/pull/1756
Support multi-assign for `Stream` and `Iterator`. Improve efficiency of
multi-assign for types like `Set` and `Collection` which do not support direct
indexing.
Translate "def (one,two) = r
eric-milles merged PR #1755:
URL: https://github.com/apache/groovy/pull/1755
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
paulk-asert closed pull request #1752: Persist the order of methods
URL: https://github.com/apache/groovy/pull/1752
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscri
paulk-asert commented on PR #1752:
URL: https://github.com/apache/groovy/pull/1752#issuecomment-1196274360
Merged, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
paulk-asert closed pull request #1753: sort the methods from the trait when
generating methods
URL: https://github.com/apache/groovy/pull/1753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
paulk-asert commented on PR #1753:
URL: https://github.com/apache/groovy/pull/1753#issuecomment-1196273964
I think the other offered solution is preferred in terms of styling with the
rest of the Groovy codebase. We don't sort except in very particular
circumstances.
--
This is an automa
eric-milles opened a new pull request, #1755:
URL: https://github.com/apache/groovy/pull/1755
Provides consistent handling for read and write access of static fields:
```groovy
class Type {
private static field
static getField() {
// not used
}
static sm() {
paulk-asert merged PR #1754:
URL: https://github.com/apache/groovy/pull/1754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@g
301 - 400 of 1001 matches
Mail list logo