[GitHub] groovy pull request #808: Documentation for @TailRecursive

Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/808#discussion_r224093386 --- Diff: src/spec/doc/core-metaprogramming.adoc --- @@ -1985,7 +1985,19 @@ _protectedCacheSize>0_ would create an unlimited cache with s

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a7ebe87b8cb4ff7ce220a13af96788118d316006#commitcomment-30427718 In subprojects/groovy-test-junit5/build.gradle: In subprojects/groovy-test-junit5/build.gradle on line 28: Great

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219191 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/b02d2f57c09ba6ba46553ed77aff191ec9ab274e#commitcomment-22219131 In subprojects/parser-antlr4/src/main/java/org/apache/groovy/parser/antlr4/util/StringUtils.java: In subprojects

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21966439 @danielsun1106 So is it a bug in the new groovy parser? --- If your project is set up for it, you can reply

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/0fb89906aa587920d11fae063bba1d1f8fe26254#commitcomment-21962912 test fails on travis, see: https://travis-ci.org/apache/groovy/builds/227402483?utm_source=github_status_medium

[GitHub] groovy pull request #527: remove skipping of tests for builds.apache.org as ...

GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/527 remove skipping of tests for builds.apache.org as we no longer use it even groovy decides to use builds.apache.org again, these workarounds may not be necessary today You can merge

[GitHub] groovy pull request #526: cleanup now that jdk7 is baseline

GitHub user PascalSchumacher opened a pull request: https://github.com/apache/groovy/pull/526 cleanup now that jdk7 is baseline for master and the GROOVY_2_5_X branch You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] groovy pull request #132: GROOVY-7502: Add IOGroovyMethods.getText(ByteArray...

Github user PascalSchumacher closed the pull request at: https://github.com/apache/groovy/pull/132 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] groovy pull request #442: GROOVY-7953: property expressions for extension me...

Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/442#discussion_r82509499 --- Diff: src/spec/test-resources/META-INF/services/org.codehaus.groovy.runtime.ExtensionModule --- @@ -17,5 +17,5 @@ # IT IS A WORKAROUND

[GitHub] groovy pull request #:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/e21d6226b9a4cc411fb0e7d24cf7b6023edc9002#commitcomment-18124607 Nice :+1: I thought nobody would ever fix these tests. --- If your project is set up for it, you can reply

[GitHub] groovy pull request:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545920 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line

[GitHub] groovy pull request:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545765 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line

[GitHub] groovy pull request:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16545493 In src/main/org/codehaus/groovy/ast/PropertyNode.java: In src/main/org/codehaus/groovy/ast/PropertyNode.java on line

[GitHub] groovy pull request: Add jaxb marshalling support

Github user PascalSchumacher commented on a diff in the pull request: https://github.com/apache/groovy/pull/255#discussion_r55146131 --- Diff: subprojects/groovy-xml/src/test/groovy/groovy/xml/jaxb/JaxbGroovyMethodsTest.groovy --- @@ -0,0 +1,41 @@ +/* + * Licensed

[GitHub] groovy pull request:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/2e7c69dc4d185dc790b7d15857235458ef3eb7a6#commitcomment-15660685 Thanks! Sorry for not checking before merging the pull request. --- If your project is set up for it, you can reply

[GitHub] groovy pull request:

Github user PascalSchumacher commented on the pull request: https://github.com/apache/groovy/commit/606891d85bedbda8139882f41eef531f5752d99f#commitcomment-15434092 I guess this could/should also be merged into 2.4.x What do you think? --- If your project is set up for it, you can