Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/811#discussion_r225293219
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java ---
@@ -18,14 +18,78 @@
*/
package org.codehaus.groovy.vmplugin.v9
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/811#discussion_r225299922
--- Diff: src/main/java/org/codehaus/groovy/vmplugin/v9/Java9.java ---
@@ -18,14 +18,78 @@
*/
package org.codehaus.groovy.vmplugin.v9
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/708#discussion_r188869080
--- Diff:
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
---
@@ -4101,13 +4101,17 @@ protected static ClassNode
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/708#discussion_r188822722
--- Diff: src/test/groovy/bugs/Groovy6668Bug.groovy ---
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/708#discussion_r188821809
--- Diff:
src/main/java/org/codehaus/groovy/transform/stc/StaticTypeCheckingVisitor.java
---
@@ -4101,13 +4101,17 @@ protected static ClassNode
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/708#discussion_r188821671
--- Diff:
src/main/java/org/codehaus/groovy/classgen/asm/sc/StaticInvocationWriter.java
---
@@ -468,7 +469,11 @@ protected void loadArguments(List
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26461672
I have the tendency that the failure comes from not using asm 6 in this
build.
---
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/1972c21cb2ccade3109cf9befdbbc3ff9c7dad68#commitcomment-26461453
yes, that looks very much like a result of my change... hmm
---
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/29727ea0c0318304ded181aebfa8cce661d34c56#commitcomment-26193580
In src/main/org/codehaus/groovy/runtime/memoize/CommonCache.java:
In src/main/org/codehaus/groovy/runtime/memoize
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/b58342060031f517d6ba42a64dd3ddf392e820bb#commitcomment-25679530
In src/main/groovy/lang/Binding.java:
In src/main/groovy/lang/Binding.java on line 99:
I think it is correct
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/631#discussion_r149848170
--- Diff: gradle/assemble.gradle ---
@@ -247,6 +247,7 @@ allprojects {
if (isRootProject
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/068ce3d445d0b5ce5c77517acb86e4cc11648b3b#commitcomment-25079300
In src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java:
In src/main/org/codehaus/groovy/classgen
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/559#discussion_r126288338
--- Diff: src/main/org/codehaus/groovy/classgen/AsmClassGenerator.java ---
@@ -1218,7 +1218,7 @@ public void
visitVariableExpression(VariableExpression
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/546#discussion_r117645462
--- Diff:
src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy ---
@@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/546#discussion_r117645390
--- Diff:
src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy ---
@@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/546#discussion_r117640763
--- Diff:
src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy ---
@@ -236,7 +236,28 @@ public class DefaultGroovyMethodsTest extends
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/532#discussion_r117177738
--- Diff: src/main/org/codehaus/groovy/reflection/CachedMethod.java ---
@@ -90,6 +92,12 @@ public CachedClass getDeclaringClass() {
public
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/532#discussion_r117177601
--- Diff: src/main/groovy/lang/MetaClassImpl.java ---
@@ -1832,6 +1832,9 @@ public Object getProperty(Class sender, Object
object, String name, boolean
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/523#discussion_r111070966
--- Diff: src/main/org/codehaus/groovy/vmplugin/VMPluginFactory.java ---
@@ -26,39 +28,10 @@
*/
public class VMPluginFactory
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107536629
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -270,7 +270,8 @@ protected int compareTo(Comparable first, Comparable
second
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107541243
--- Diff: src/main/org/codehaus/groovy/vmplugin/v7/IndyArrayAccess.java ---
@@ -96,29 +96,6 @@ private static MethodHandle buildSetter(Class
arrayClass
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107539033
--- Diff: src/main/org/codehaus/groovy/reflection/GeneratedMetaMethod.java
---
@@ -162,7 +162,7 @@ public static void saveDgmInfo(List
records, String
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107540485
--- Diff: src/main/org/codehaus/groovy/tools/shell/IO.java ---
@@ -130,7 +130,7 @@ public boolean isDebug() {
/**
* Flush both output
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107536859
--- Diff: src/main/groovy/lang/ProxyMetaClass.java ---
@@ -53,7 +51,7 @@ public static ProxyMetaClass getInstance(Class theClass)
throws IntrospectionExc
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/282#discussion_r107540260
--- Diff: src/main/org/codehaus/groovy/tools/DgmConverter.java ---
@@ -37,7 +37,7 @@
public class DgmConverter implements Opcodes
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/716d3e67e744c7edeed7cbc3f874090d39355764#commitcomment-19510217
09e9778 is not enough
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/438#discussion_r83155709
--- Diff:
subprojects/groovy-groovysh/src/main/groovy/org/codehaus/groovy/tools/shell/completion/ImportsSyntaxCompletor.groovy
---
@@ -87,51 +78,49
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/445#discussion_r82782344
--- Diff: src/main/groovy/lang/GroovyClassLoader.java ---
@@ -969,13 +970,24 @@ public Void run() {
*/
public void clearCache
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/9be5459c906ba106f235d40ebe0f25b7193a0467#commitcomment-19181654
In src/main/org/apache/groovy/metaclass/Realm.java:
In src/main/org/apache/groovy/metaclass/Realm.java on line 43:
I
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/403#discussion_r76537642
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -10563,13 +10563,21 @@ private void prepare
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/376#discussion_r73109779
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -5176,7 +5176,9 @@ public static Map groupBy(Object[] self,
List closures
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/376#discussion_r73000754
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -5176,7 +5176,9 @@ public static Map groupBy(Object[] self,
List closures
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/376#discussion_r72938131
--- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java ---
@@ -5169,12 +5170,13 @@ public static Map groupBy(Object[] self,
List closures
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/370#discussion_r72755079
--- Diff: src/main/org/codehaus/groovy/ast/VariableScope.java ---
@@ -178,4 +178,26 @@ public Object removeReferencedClassVariable(String
name
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r71062645
--- Diff: src/main/groovy/lang/IntRange.java ---
@@ -385,26 +385,23 @@ public void step(int step, Closure closure) {
return; // from
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r70181647
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -537,8 +539,9 @@ protected Object increment(Object value) {
* @param value the value
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69555298
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -37,7 +37,7 @@
* Note: This class is similar to {@link IntRange}. If you make any
changes
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69550447
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -397,7 +392,10 @@ public boolean contains(Object value) {
@Override
public
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69549904
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -397,7 +392,10 @@ public boolean contains(Object value) {
@Override
public
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69522189
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -338,22 +337,22 @@ public int size() {
// Performance detail
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69522013
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -409,106 +406,86 @@ public void step(int step, Closure closure) {
*/
@Override
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69521163
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -397,7 +392,10 @@ public boolean contains(Object value) {
@Override
public
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/360#discussion_r69520315
--- Diff: src/main/groovy/lang/ObjectRange.java ---
@@ -306,14 +303,13 @@ public int size() {
}
} else
GitHub user blackdrag opened a pull request:
https://github.com/apache/groovy/pull/326
GROOVY-7832: add null guard
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/blackdrag/groovy GROOVY-7832
Alternatively you can review
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61769520
--- Diff: src/main/org/codehaus/groovy/reflection/ClassInfo.java ---
@@ -35,13 +36,13 @@
*
* @author Alex.Tkachman
*/
-public class
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61761881
--- Diff: src/main/org/codehaus/groovy/reflection/ClassInfo.java ---
@@ -35,13 +36,13 @@
*
* @author Alex.Tkachman
*/
-public class
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/219#discussion_r61761426
--- Diff: src/main/org/codehaus/groovy/util/ManagedReference.java ---
@@ -46,7 +46,6 @@ public final T get() {
public final void clear
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/287#discussion_r55440244
--- Diff: src/main/org/codehaus/groovy/runtime/MethodClosure.java ---
@@ -62,9 +74,34 @@ public String getMethod() {
}
protected
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/287#discussion_r55433138
--- Diff: src/spec/test/CoercionTest.groovy ---
@@ -214,7 +214,7 @@ boolean doFilter(String s) { s.contains('G') }
Predicate filter = this.
assert
Github user blackdrag commented on the pull request:
https://github.com/apache/groovy/commit/a0aed6c6e523d176ebd480075d54aa9a3e19b472#commitcomment-16558458
In src/main/org/codehaus/groovy/ast/PropertyNode.java:
In src/main/org/codehaus/groovy/ast/PropertyNode.java on line 125
Github user blackdrag closed the pull request at:
https://github.com/apache/groovy/pull/125
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/232#discussion_r48842494
--- Diff:
src/main/org/codehaus/groovy/classgen/asm/sc/StaticInvocationWriter.java ---
@@ -602,7 +602,7 @@ private static void pushZero(final MethodVisitor
Github user blackdrag commented on a diff in the pull request:
https://github.com/apache/groovy/pull/232#discussion_r48842357
--- Diff: src/main/org/codehaus/groovy/classgen/asm/OperandStack.java ---
@@ -336,14 +336,12 @@ private void doConvertAndCast(ClassNode targetType,
boolean
53 matches
Mail list logo
