[GitHub] groovy pull request #:

2018-10-28 Thread pditommaso
Github user pditommaso commented on the pull request: https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075820 👍 ---

[GitHub] groovy pull request #:

2018-10-28 Thread pditommaso
Github user pditommaso commented on the pull request: https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075630 Oh, right! I was missing the the groovy shell gives to the same script different file names. But in this case would not make

[GitHub] groovy pull request #:

2018-10-28 Thread pditommaso
Github user pditommaso commented on the pull request: https://github.com/apache/groovy/commit/3341dcd9a4f151b71b90ceb0be59fcdca403c300#commitcomment-31075266 Out of curiosity, what's the benefit of caching classes using as key the source hash code instead of the class name? ---

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2018-02-06 Thread pditommaso
Github user pditommaso commented on a diff in the pull request: https://github.com/apache/groovy/pull/566#discussion_r166250753 --- Diff: src/main/org/codehaus/groovy/runtime/DefaultGroovyMethods.java --- @@ -12026,6 +12026,9 @@ public static boolean equals(List left, List right

[GitHub] groovy pull request #566: Added IgnoreDefaultEqualsAndToString

2017-06-25 Thread pditommaso
GitHub user pditommaso opened a pull request: https://github.com/apache/groovy/pull/566 Added IgnoreDefaultEqualsAndToString This annotation allows custom `Collection` and `Map` objects to bypass the default Groovy format and equality methods ie. `toString` and `equals`. You can