[GitHub] [groovy] blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-08 Thread GitBox
blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-572151846 It is simple: your approach is faster than the old one without adding a lot of complicated code. Go for it.

[GitHub] [groovy] blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570908249 @danielsun1106 which version of Java are you using for your tests? In my test CS was slower for the first case than indy1, in

[GitHub] [groovy] blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570829416 frankly I think I am missing something completely right now. You say setTarget is causing the bad performance... there is a hit

[GitHub] [groovy] blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
blackdrag commented on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570808378 Just to be sure I understand the code correctly... We install a CachedCallableCallsite, which will have similar logic to