[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-14 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-574100086 I picked the fastest results of the different versions of Groovy indy2: 4693ms; indy1: 5268ms; cs: 6007ms

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-08 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-571961230 @blackdrag Jochen, I measured the performance of cs, indy1 and indy2 with JMH (

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-08 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-571961230 @blackdrag Jochen, I measured the performance of cs, indy1 and indy2 with JMH (

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-06 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570983832 Here is an edge case: we set `groovy.indy.optimize.threshold` to `0` at first, so the target of callsite `toString`

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570983832 Here is an edge case: we set `groovy.indy.optimize.threshold` to `0`, and the target of callsite `toString` will be

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509 Jochen, as you found, the regular case is the most inefficient one. So in the latest commit I introduce a threshold

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-05 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570900509 Jochen, as you found, the regular case is the most inefficient one. So in the latest commit I introduce a threshold

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, you got the point ;-) The main idea can be described as the following simplified code: ```java if

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following simplified code: ```java if

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //

[GitHub] [groovy] danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic

2020-01-04 Thread GitBox
danielsun1106 edited a comment on issue #1135: GROOVY-8298: Slow Performance Caused by Invoke Dynamic URL: https://github.com/apache/groovy/pull/1135#issuecomment-570811643 Jochen, the main idea can be described as the following code: ```java if (cacheHits(receiverCassName)) { //