[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param

2022-11-08 Thread GitBox
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307353408 I merged the main changes that should fix GROOVY-9541 and will cherry-pick them back as well. The `ExtendedVerifier` spot has some history -- `getTypeClass()` -- I'm reworking it to

[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param

2022-11-08 Thread GitBox
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1307253615 Thanks. I should be able to look at it today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param

2022-11-02 Thread GitBox
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1300451462 For the two resolve strategy lines, you could even pass `null` or use the old signature. The strategy value is usually `Closure.DELEGATE_FIRST` or one of the others and these have

[GitHub] [groovy] eric-milles commented on pull request #1816: Bugfix/groovy 9541 stc take classloader param

2022-11-02 Thread GitBox
eric-milles commented on PR #1816: URL: https://github.com/apache/groovy/pull/1816#issuecomment-1300426700 Instead of creating a new instance of `GroovyClassLoader` you can skip the `closeQuietly` call in the `finally` block if passed loader is non-null. `StaticTypeCheckingVisitor`