[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-03 Thread GitBox
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369834434 Not sure why the new methods are listed as "since 4.0.8". Are these such a must have that they should be available immediately. If kept for 5+, the array-based overloads can start of

[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-01 Thread GitBox
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368491569 Okay, just picked up on the difference. `find` and `findAll` apply groovy truth and `findResult` and `findResults` check `null` only. Is that too subtle a difference? If this

[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-01 Thread GitBox
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368484663 And since `find` and `findAll` are based on groovy truth, to get a default value, you can just pepper in elvis: ```groovy def list = [null,false,'',[]] def result = list.find()

[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-01 Thread GitBox
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368483874 I don't think it is hole in existing functionality though. I'm missing the clear and obvious part of all this. Leaving the default value stuff aside, ```groovy def list = [null,

[GitHub] [groovy] eric-milles commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2022-12-31 Thread GitBox
eric-milles commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368284125 -1 for me unless some description is provided. What is the specific purpose of this and what does to replace that is currently available? More discussion from Feb 2019: https://www.m