[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-03 Thread GitBox
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1370224768 My thinking was since this is missing functionality it makes sense for 4.0.8. We have the find/findAll variants (Groovy truth) in 4.0.7 why not the missing findResult/s variants (null-

[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-03 Thread GitBox
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1369681830 Is the "further clarification request" on your -1 veto satisfied? Perhaps you can formally remove it? -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2023-01-01 Thread GitBox
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368542797 We picked the name `findResult` many years ago. Naming is hard. I wasn't going to open the naming can of worms myself. Just plugging that hole in the existing named functions. B

[GitHub] [groovy] paulk-asert commented on pull request #1839: GROOVY-10891: We should have variants of findResult/s with no Closure…

2022-12-31 Thread GitBox
paulk-asert commented on PR #1839: URL: https://github.com/apache/groovy/pull/1839#issuecomment-1368316519 It is filling a hole in existing functionality. Take `find` and `findAll` for instance, they have the no Closure variants: ``` var list = [null, '', 'A', null, 'B'] assert list