GitHub user rvprasad opened a pull request:
https://github.com/apache/groovy/pull/682
GroovyCollections.combinations(Iterable) exhibits incorrect (asymmetric)
behavior.
The fix ensures no combination is returned if any of the input iterables to
GroovyCollections.combinations()
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/c7dc5e411685cfe4d35e9254d7f8db7188d96ae2#commitcomment-28472840
Forgot the license header again...
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/681
---
GitHub user danielsun1106 opened a pull request:
https://github.com/apache/groovy/pull/681
GROOVY-4585: backslash can not be escaped by `SimpleTemplateEngine`
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/danielsun1106/groovy
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/f88d0122525cabf6bdf61ab051533f9983f352f1#commitcomment-28390941
In src/test/groovy/SerializableCompatibilityTest.groovy:
In src/test/groovy/SerializableCompatibilityTest.groovy on line
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/f88d0122525cabf6bdf61ab051533f9983f352f1#commitcomment-28390910
In src/test/groovy/SerializableCompatibilityTest.groovy:
In src/test/groovy/SerializableCompatibilityTest.groovy on line
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388536
Reverted all... trying to add missing `serialVersionUID` for 2.4 first
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388135
Technically we only need to "fix" the broken bits but it will be easiest to
revert on all branches and work from the 2.4
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28388111
Reverted on 2.4 branch:
https://github.com/apache/groovy/commit/c4253d71abdef1499d59f3d55c5b86aac5b82292
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387971
revert the commit on all branches?
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387886
Please revert. That just also breaks serializable compability between
2.4.15 and 2_4_X HEAD!!
Run this script on
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387615
See
https://github.com/apache/groovy/commit/b7c9db3aa0e50cef860c43e0d9e303671106ae89
The missing `serialVersionUID`
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387375
Let me generate you an example ...
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387373
my last reply was to your earlier comment.
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387349
Not all the classes probably gave errors but yep, that will probably be the
easiest. The only other comment I'll make is that
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387340
Paul, if we sync the changes of 2.5 to 2.4, the result should be same...
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387318
Let me revert the commit and generate missing `serialVersionUID` for 2.4,
at last sync the changes to other branches.
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387291
Bonus points if you can pin-point what is causing the false positives - we
should submit a bug report/PR to japicmp to fix
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387263
Best bet for checking is to just serialize from 2.4 using
ObjectOutputStream into a dat file (binary file) and read that back
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387229
Also, I'd note that in some cases, like the ObservableList/Map/Set example
which weren't serializable in the first place -
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387216
To keep serializability compatible within 2.4 we can add serialVersionUID
values generated from the 2.4 codebase. We can then
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28387182
Yes but it will break serializability within a point release!
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386578
Syncing the changes to 2.4 branch will remove these warnings?
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/1bcaaeaf60078dd5a9aca5cbf1df8f45de68db60#commitcomment-28386425
If you get a chance to check the "Serializable incompatible(!)" warnings
from the checkBinaryCompatibility task that would be
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/680
---
GitHub user nikchugunov opened a pull request:
https://github.com/apache/groovy/pull/680
GROOVY-8523 Static type checking instanceof_not
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nikchugunov/groovy master
Alternatively
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/675
---
Github user paulk-asert closed the pull request at:
https://github.com/apache/groovy/pull/678
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/679
---
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421035
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -199,20 +208,35 @@ public int size() {
return
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178421016
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178419989
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -199,20 +208,35 @@ public int size() {
return
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/679#discussion_r178419950
--- Diff:
src/main/java/org/codehaus/groovy/runtime/memoize/StampedCommonCache.java ---
@@ -175,6 +174,11 @@ private V compute(K key, ValueProvider
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347747
In src/antlr/GroovyLexer.g4:
If we do not like `'''1234''`, we can forbid it by lexer. To be honest,
I don't care
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347515
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
But ''' and """ can quote themselves given the
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347461
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
Let's discuss at
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28347291
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
`/` and `'` can not quote themselves, so
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346795
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
I don't see this as a case of it can be done so
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346491
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
Paul, `'''` and `"""` should be able to quote
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/7e7b508c02bf35e72fca1efcb7cc0d8a4f25038a#commitcomment-28346403
In src/antlr/GroovyLexer.g4:
In src/antlr/GroovyLexer.g4 on line 317:
There is no doubt some merit to this approach
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/678
GROOVY-8525: Binary compatibility issue for GroovyClassLoader betweenâ¦
⦠2.4 vs later branches
You can merge this pull request into a Git repository by running:
$ git pull
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/00af138c0b0d6a9a06cf7f87d654ef7fb9505d60#commitcomment-28266023
In build.gradle:
In build.gradle on line 151:
Cool! I realise that I'm being pushy, but Gradle 4.7-RC1 is not far away,
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/675#discussion_r176603885
--- Diff: src/main/groovy/groovy/lang/MissingMethodException.java ---
@@ -48,7 +48,7 @@ public MissingMethodException(String method, Class type,
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/675#discussion_r176602934
--- Diff:
subprojects/groovy-jsr223/src/main/java/org/codehaus/groovy/jsr223/GroovyScriptEngineImpl.java
---
@@ -367,6 +367,22 @@ private Object
Github user danielsun1106 commented on a diff in the pull request:
https://github.com/apache/groovy/pull/675#discussion_r175424466
--- Diff: src/main/groovy/groovy/lang/MissingMethodException.java ---
@@ -48,7 +48,7 @@ public MissingMethodException(String method, Class type,
Github user paulk-asert commented on a diff in the pull request:
https://github.com/apache/groovy/pull/676#discussion_r176448808
--- Diff:
src/test/org/codehaus/groovy/runtime/DefaultGroovyMethodsTest.groovy ---
@@ -310,4 +312,18 @@ class DefaultGroovyMethodsTest extends
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/674
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/b3e042191a7acc1c7bdfdfdc0c39fe93e2de3d94#commitcomment-28156790
@paulk-asert Thanks! Given that the jdk10 release is just around the corner
I hope the asm upgrade goes through.
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/b3e042191a7acc1c7bdfdfdc0c39fe93e2de3d94#commitcomment-28155690
It is up to Paul's plan ;-)
---
GitHub user bdkosher opened a pull request:
https://github.com/apache/groovy/pull/674
GROOVY-8334: Java 8 Date/Time type support in Groovy JDK
Reference: https://issues.apache.org/jira/browse/GROOVY-8334
You can merge this pull request into a Git repository by running:
$ git
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107442
In src/test/groovy/bugs/Groovy8439Bug.groovy:
The previous commit is wrong, so the current commit reverts it and fixes
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107275
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50:
The test passed
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/3eb491cded846c352952cdb3a6fffed817e14741#commitcomment-28107251
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 50:
It would be
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/e154c3e560e998e158985316566c7e321579b193#commitcomment-28107242
In src/test/groovy/bugs/Groovy8439Bug.groovy:
In src/test/groovy/bugs/Groovy8439Bug.groovy on line 22:
It would be
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/493
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/494
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28082375
@paulk-asert Only one day until Greach :-o
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28043214
Very cool. Looking forward to it!
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28040924
I was hoping to have it out (for Apache voting) by now. I might still get
that done before I hop on a plane tonight -
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28039864
According to the plan, 2.5.0-rc-1 will be released before or around Greach.
In other words, very soon.
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28039517
Super! Any idea when 2.5.0-beta-4 (or rc-1) is due?
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28037958
Done ;-)
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28037922
Great!
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28036349
Nice. I will bump asm later.
Thanks for your reminding ;-)
---
Github user henrik242 commented on the pull request:
https://github.com/apache/groovy/commit/ce256aab7653fa020ac323ef260d0c4a4cf25e44#commitcomment-28036285
@danielsun1106 Asm 6.1 is released now:
https://gitlab.ow2.org/asm/asm/commit/6969d6ebefcd1083d812a5af0bc478b1fcf544a1
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/673
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/673
GROOVY-8501: Switch internal details of @ImmutableBase existing constâ¦
â¦ructor validation
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/672
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/672
GROOVY-7624: Collection asImmutable() methods aren't immutable
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/671
---
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/671
GROOVY-8422: Incorrect properties copy in Sql.newInstance
The provided Properties should be passed to the DriverManager as-is.
A copy is only needed when changes are made to the provided
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/669
---
Github user jwagenleitner closed the pull request at:
https://github.com/apache/groovy/pull/670
---
GitHub user jwagenleitner opened a pull request:
https://github.com/apache/groovy/pull/670
GROOVY-8475: unable to instantiate objects using the "new" keyword in
groovysh
PR #100 was merged into 2_5_X and comments on GROOVY-7562 indicate it
wasn't merged into 2_4_X due to binary
GitHub user Linary opened a pull request:
https://github.com/apache/groovy/pull/669
Fix ArrayIndexOutOfBoundsException in
CallSiteWriter.getCreateArraySignature()
It would throw `ArrayIndexOutOfBoundsException` if the `numberOfArguments`
exceed 255,
but there is no check for
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/668
---
GitHub user sergeyh opened a pull request:
https://github.com/apache/groovy/pull/668
Fix XmlParser default constructor Javadoc
Currently, Javadoc says it creates "non-validating and non-namespace-aware"
parser, but in fact, it _is_ namespace aware.
You can merge this pull request
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/667
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/667
GROOVY-8379: Rework groovy-json FastStringUtils
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/paulk-asert/groovy groovy8379
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/666
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/660
---
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27737030
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
I just added OpenJDK9 build to run groovy
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736836
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
Nice.
BTW,
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736817
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
Just as a side note, it would be worth writing
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736777
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
It's missing an Apache header - but I just
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736769
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
Or move the shell script to the root of
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736725
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
we should use sh instead of bash?
---
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/63fc0a4036538fcf329d3a5b104dd32aa56d2d56#commitcomment-27736578
In src/install/install-jdk.sh:
In src/install/install-jdk.sh on line 1:
fails RAT report
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/666
GROOVY-8480: org.codehaus.groovy.runtime.ExtensionModule should move â¦
â¦to META-INF/groovy
You can merge this pull request into a Git repository by running:
$ git pull
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/665
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/453
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/664
---
GitHub user paulk-asert opened a pull request:
https://github.com/apache/groovy/pull/664
GROOVY-7956: Provide an AST transformation which improves named paramâ¦
â¦eter support
You can merge this pull request into a Git repository by running:
$ git pull
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/9699e99483b8f53e4a77762225343a86ee3c4783#commitcomment-27642627
In src/main/java/org/apache/groovy/util/Maps.java:
In src/main/java/org/apache/groovy/util/Maps.java on line 5802:
Github user danielsun1106 commented on the pull request:
https://github.com/apache/groovy/commit/9699e99483b8f53e4a77762225343a86ee3c4783#commitcomment-27637860
In src/main/java/org/apache/groovy/util/Maps.java:
In src/main/java/org/apache/groovy/util/Maps.java on line 5802:
Github user paulk-asert commented on the pull request:
https://github.com/apache/groovy/commit/9699e99483b8f53e4a77762225343a86ee3c4783#commitcomment-27636375
In src/main/java/org/apache/groovy/util/Maps.java:
In src/main/java/org/apache/groovy/util/Maps.java on line 5802:
We
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/654
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/662
---
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/663
---
Github user daniel-huss commented on a diff in the pull request:
https://github.com/apache/groovy/pull/643#discussion_r168272512
--- Diff: src/test/groovy/transform/stc/MethodCallsSTCTest.groovy ---
@@ -383,6 +406,94 @@ class MethodCallsSTCTest extends
StaticTypeCheckingTestCase {
401 - 500 of 1632 matches
Mail list logo
