[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

2016-09-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/416 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

2016-09-09 Thread jwagenleitner
Github user jwagenleitner commented on a diff in the pull request: https://github.com/apache/groovy/pull/416#discussion_r78228482 --- Diff: src/main/org/codehaus/groovy/transform/trait/TraitComposer.java --- @@ -293,7 +293,8 @@ private static void createForwarderMethod(

[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

2016-09-09 Thread graemerocher
Github user graemerocher commented on a diff in the pull request: https://github.com/apache/groovy/pull/416#discussion_r78217077 --- Diff: src/main/org/codehaus/groovy/transform/trait/TraitComposer.java --- @@ -293,7 +293,8 @@ private static void createForwarderMethod(

[GitHub] groovy pull request #416: GROOVY-7926 - Don't use a CastExpression if the re...

2016-09-08 Thread graemerocher
GitHub user graemerocher opened a pull request: https://github.com/apache/groovy/pull/416 GROOVY-7926 - Don't use a CastExpression if the return type is void. As per https://issues.apache.org/jira/browse/GROOVY-7926 traits currently try to cast the void type which leads to