[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-12-24 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16728513#comment-16728513 ] Anton Pryamostanov commented on GROOVY-8834: Just as a side note: please take a look at

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-12-20 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16725963#comment-16725963 ] Eric Milles commented on GROOVY-8834: - Since the AST is exposed to user modification, I don't think

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-12-18 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724125#comment-16724125 ] Anton Pryamostanov commented on GROOVY-8834: Ok, I figured out the question to be asked: -

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-12-18 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16724025#comment-16724025 ] Anton Pryamostanov commented on GROOVY-8834: Hi [~emilles], [~paulk], I just faced some

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-26 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16699160#comment-16699160 ] Eric Milles commented on GROOVY-8834: - [~anton.pryamostanov] I did not mean to imply that AST

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-23 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16696625#comment-16696625 ] Anton Pryamostanov commented on GROOVY-8834: Hi [~emilles], thank you for the feedback. Do

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-22 Thread Eric Milles (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16695937#comment-16695937 ] Eric Milles commented on GROOVY-8834: - The general approach to AST mutation is to implement the

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-20 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16692933#comment-16692933 ] Anton Pryamostanov commented on GROOVY-8834: Hi [~paulk], Please find updated list: (I

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-13 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16685173#comment-16685173 ] Anton Pryamostanov commented on GROOVY-8834: [~paulk], many thanks for the feedback! I

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-13 Thread Paul King (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684930#comment-16684930 ] Paul King commented on GROOVY-8834: --- General comment, many of the classes you mention assume that

[jira] [Commented] (GROOVY-8834) Making "public" - BinaryExpression.leftExpression and similar fields

2018-11-13 Thread Anton Pryamostanov (JIRA)
[ https://issues.apache.org/jira/browse/GROOVY-8834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16684880#comment-16684880 ] Anton Pryamostanov commented on GROOVY-8834: This is still actual and I do believe AST