[jira] [Resolved] (GROOVY-7707) StreamingJsonBuilder produces IllegalStateException when using unescaped output

2015-12-11 Thread John Wagenleitner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GROOVY-7707?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Wagenleitner resolved GROOVY-7707.
---
   Resolution: Fixed
Fix Version/s: 2.5.0-beta-1
   2.4.6

PR https://github.com/apache/groovy/pull/210 merged, thanks!

> StreamingJsonBuilder produces IllegalStateException when using unescaped 
> output
> ---
>
> Key: GROOVY-7707
> URL: https://issues.apache.org/jira/browse/GROOVY-7707
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 2.4.5
>Reporter: Graeme Rocher
> Fix For: 2.4.6, 2.5.0-beta-1
>
>
> When writing unescaped JSON the state is not reset, resulting in an exception 
> if another entry is written.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GROOVY-7708) StreamingJsonBuilder doesn't define DelegatesTo on some methods, impacting @CompileStatic usage

2015-12-11 Thread John Wagenleitner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GROOVY-7708?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Wagenleitner resolved GROOVY-7708.
---
   Resolution: Fixed
Fix Version/s: 2.5.0-beta-1
   2.4.6

PR merged https://github.com/apache/groovy/pull/209, thanks!

> StreamingJsonBuilder doesn't define DelegatesTo on some methods, impacting 
> @CompileStatic usage
> ---
>
> Key: GROOVY-7708
> URL: https://issues.apache.org/jira/browse/GROOVY-7708
> Project: Groovy
>  Issue Type: Improvement
>Affects Versions: 2.4.5
>Reporter: Graeme Rocher
> Fix For: 2.4.6, 2.5.0-beta-1
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Resolved] (GROOVY-7706) StreamingJsonBuilder should supported nested closures

2015-12-11 Thread John Wagenleitner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GROOVY-7706?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Wagenleitner resolved GROOVY-7706.
---
   Resolution: Fixed
Fix Version/s: 2.5.0-beta-1
   2.4.6

PR https://github.com/apache/groovy/pull/208 merged, thanks!

> StreamingJsonBuilder should supported nested closures 
> --
>
> Key: GROOVY-7706
> URL: https://issues.apache.org/jira/browse/GROOVY-7706
> Project: Groovy
>  Issue Type: Improvement
>Affects Versions: 2.4.5
>Reporter: Graeme Rocher
> Fix For: 2.4.6, 2.5.0-beta-1
>
>
> Currently `StreamingJsonBuilder` doesn't handle nested closures properly and 
> instead these are delegated to `JsonOutput.toJso`n which is not streaming and 
> leads to an unexpected change of delegate in the nested closure. This pull 
> request fixes that erroneous behaviour.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] groovy pull request: Escaped -> so it does not appear as →

2015-12-11 Thread pieces029
GitHub user pieces029 opened a pull request:

https://github.com/apache/groovy/pull/212

Escaped -> so it does not appear as →



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/pieces029/groovy master

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/212.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #212


commit 3f1b31b73ed0dc955780f274b250abf103eb4778
Author: Andrew Reitz 
Date:   2015-12-12T03:56:43Z

Escaped -> so it does not appear as →




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request: StreamingJsonBuilder - improve @CompileStatic...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/209


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request: StreamingJsonBuilder should handle nested clo...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/208


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request: StreamingJsonBuilder - fix IllegalStateExcept...

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/210


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Updated] (GROOVY-7703) Add support for Iterable with Closure to JsonBuilder/StreamingJsonBuilder

2015-12-11 Thread John Wagenleitner (JIRA)

 [ 
https://issues.apache.org/jira/browse/GROOVY-7703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

John Wagenleitner updated GROOVY-7703:
--
Fix Version/s: 2.4.6

> Add support for Iterable with Closure to JsonBuilder/StreamingJsonBuilder
> -
>
> Key: GROOVY-7703
> URL: https://issues.apache.org/jira/browse/GROOVY-7703
> Project: Groovy
>  Issue Type: Improvement
>  Components: JSON
>Affects Versions: 2.4.5
>Reporter: John Wagenleitner
>Assignee: John Wagenleitner
>Priority: Minor
> Fix For: 2.4.6, 2.5.0-beta-1
>
>
> JsonBuilder and StreamingJsonBuilder currently support passing a 
> {{Collection}} and a {{Closure}}, the closure will be applied to each item in 
> the collection.  An improvement would be to support the more general 
> {{Iterable}} type.
> See https://github.com/apache/groovy/pull/203



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[GitHub] groovy pull request: Fix a few documentation typos

2015-12-11 Thread asfgit
Github user asfgit closed the pull request at:

https://github.com/apache/groovy/pull/211


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[GitHub] groovy pull request: Fix a few documentation typos

2015-12-11 Thread fpavageau
GitHub user fpavageau opened a pull request:

https://github.com/apache/groovy/pull/211

Fix a few documentation typos



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/fpavageau/groovy doc-fixes

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/groovy/pull/211.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #211


commit 6e6bac8f2d9a2b028dda0d09b295790992db729c
Author: Frank Pavageau 
Date:   2015-12-11T21:30:12Z

Fix a few documentation typos




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---


[jira] [Commented] (GROOVY-7709) NPE with ConvertedClosure

2015-12-11 Thread John Wagenleitner (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052935#comment-15052935
 ] 

John Wagenleitner commented on GROOVY-7709:
---

NPE occurs in master.  Testing each point release from 2.4.5 back, last release 
this worked as expected was 1.6.9.

> NPE with ConvertedClosure
> -
>
> Key: GROOVY-7709
> URL: https://issues.apache.org/jira/browse/GROOVY-7709
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 2.4.5
>Reporter: Jochen Theodorou
>
> {code}
> interface Y extends GroovyObject {}
> def cl = {println 1} as Y
> assert cl instanceof GroovyObject
> if (cl) println "!cl"
> {code}
> the code above will cause the execution of the method getMetaClass in the 
> boolean part of the "if". It looks like this code path now produces a NPE
> {code}
> java.lang.NullPointerException
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:919)
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:902)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:185)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:74){code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)



[jira] [Commented] (GROOVY-7709) NPE with ConvertedClosure

2015-12-11 Thread Jochen Theodorou (JIRA)

[ 
https://issues.apache.org/jira/browse/GROOVY-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15052678#comment-15052678
 ] 

Jochen Theodorou commented on GROOVY-7709:
--

not tested against master

> NPE with ConvertedClosure
> -
>
> Key: GROOVY-7709
> URL: https://issues.apache.org/jira/browse/GROOVY-7709
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 2.4.5
>Reporter: Jochen Theodorou
>
> {code}
> interface Y extends GroovyObject {}
> def cl = {println 1} as Y
> assert cl instanceof GroovyObject
> if (cl) println "!cl"
> {code}
> the code above will cause the execution of the method getMetaClass in the 
> boolean part of the "if". It looks like this code path now produces a NPE
> {code}
> java.lang.NullPointerException
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:919)
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:902)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:185)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:74){code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Updated] (GROOVY-7709) NPE with ConvertedClosure

2015-12-11 Thread Jochen Theodorou (JIRA)

 [ 
https://issues.apache.org/jira/browse/GROOVY-7709?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jochen Theodorou updated GROOVY-7709:
-
Affects Version/s: 2.4.5

> NPE with ConvertedClosure
> -
>
> Key: GROOVY-7709
> URL: https://issues.apache.org/jira/browse/GROOVY-7709
> Project: Groovy
>  Issue Type: Bug
>Affects Versions: 2.4.5
>Reporter: Jochen Theodorou
>
> {code}
> interface Y extends GroovyObject {}
> def cl = {println 1} as Y
> assert cl instanceof GroovyObject
> if (cl) println "!cl"
> {code}
> the code above will cause the execution of the method getMetaClass in the 
> boolean part of the "if". It looks like this code path now produces a NPE
> {code}
> java.lang.NullPointerException
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:919)
>   at 
> org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:902)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:185)
>   at 
> org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:74){code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Created] (GROOVY-7709) NPE with ConvertedClosure

2015-12-11 Thread Jochen Theodorou (JIRA)
Jochen Theodorou created GROOVY-7709:


 Summary: NPE with ConvertedClosure
 Key: GROOVY-7709
 URL: https://issues.apache.org/jira/browse/GROOVY-7709
 Project: Groovy
  Issue Type: Bug
Reporter: Jochen Theodorou


{code}
interface Y extends GroovyObject {}
def cl = {println 1} as Y
assert cl instanceof GroovyObject
if (cl) println "!cl"
{code}
the code above will cause the execution of the method getMetaClass in the 
boolean part of the "if". It looks like this code path now produces a NPE
{code}
java.lang.NullPointerException
at 
org.codehaus.groovy.runtime.InvokerHelper.invokePogoMethod(InvokerHelper.java:919)
at 
org.codehaus.groovy.runtime.InvokerHelper.invokeMethod(InvokerHelper.java:902)
at 
org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.castToBoolean(DefaultTypeTransformation.java:185)
at 
org.codehaus.groovy.runtime.typehandling.DefaultTypeTransformation.booleanUnbox(DefaultTypeTransformation.java:74){code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)