[jira] [Created] (GROOVY-9057) Groovydoc should set exit code on errors
Basil Peace created GROOVY-9057:
---
Summary: Groovydoc should set exit code on errors
Key: GROOVY-9057
URL: https://issues.apache.org/jira/browse/GROOVY-9057
Project: Groovy
Issue Type: Bug
Components: GroovyDoc
Affects Versions: 2.5.2, 3.0.0-alpha-3
Reporter: Basil Peace
Whenever the error occurs, GroovyDoc just reports it:
{code:java}
ERROR [org.codehaus.groovy.tools.groovydoc.GroovyRootDocBuilder] ignored due to
RecognitionException: a/Test.java [expecting EOF, found '}']{code}
and exits with success.
Whenever error occurs, GroovyDoc should set exit code so that whoever called
Groovydoc could handle the failure, e.g. stop the build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] [groovy] asfgit closed pull request #891: GROOVY-9022: Added option under View menu of whether or not to have v…
asfgit closed pull request #891: GROOVY-9022: Added option under View menu of whether or not to have v… URL: https://github.com/apache/groovy/pull/891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v…
paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v… URL: https://github.com/apache/groovy/pull/891#issuecomment-475946048 Merged, thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Resolved] (GROOVY-9022) In Groovy console, enable option for output to be on the right side. (horizontal split)
[ https://issues.apache.org/jira/browse/GROOVY-9022?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-9022. --- Resolution: Fixed Assignee: Paul King Fix Version/s: 2.5.7 3.0.0-beta-1 Proposed PR merged. Thanks! > In Groovy console, enable option for output to be on the right side. > (horizontal split) > --- > > Key: GROOVY-9022 > URL: https://issues.apache.org/jira/browse/GROOVY-9022 > Project: Groovy > Issue Type: Improvement > Components: Groovy Console >Affects Versions: 3.0.0-alpha-4 >Reporter: Adam L. Davis >Assignee: Paul King >Priority: Minor > Fix For: 3.0.0-beta-1, 2.5.7 > > Time Spent: 1h 40m > Remaining Estimate: 0h > > Enable option for output to be on the right side. (horizontal split) rather > than below. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] [groovy] danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…
danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename
method `visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268429007
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@ -50,8 +50,18 @@
private int lastColumnNumber = -1;
private Map metaDataMap = null;
+public void accept(GroovyCodeVisitor visitor) {
+throw new RuntimeException("No accept() method implemented for class:
" + getClass().getName());
+}
+
+/**
+ * An alias method for {@link
org.codehaus.groovy.ast.ASTNode#accept(GroovyCodeVisitor)}
+ * Note: the method will be removed in a future version, e.g. Groovy 4 or
Groovy 5
Review comment:
As @paulk-asert said, "Once we have Java 9 as our minimum, we can use the
`since` and `forRemoval` Deprecated attributes
and that will allow us to make such deprecations a little clearer. "
We won't remove it without any prior warnings, no worries ;-)
BTW, I believe the alias method `visit` will be reserved for a very long
time.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 opened a new pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…
danielsun1106 opened a new pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a… URL: https://github.com/apache/groovy/pull/902 …n alias method `visit` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [groovy] pzygielo commented on a change in pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…
pzygielo commented on a change in pull request #902: GROOVY-9056: Rename method
`visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268427112
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@ -50,8 +50,18 @@
private int lastColumnNumber = -1;
private Map metaDataMap = null;
+public void accept(GroovyCodeVisitor visitor) {
+throw new RuntimeException("No accept() method implemented for class:
" + getClass().getName());
+}
+
+/**
+ * An alias method for {@link
org.codehaus.groovy.ast.ASTNode#accept(GroovyCodeVisitor)}
+ * Note: the method will be removed in a future version, e.g. Groovy 4 or
Groovy 5
Review comment:
Why not @`Deprecate` it then?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename method `visit` of `ASTNode` to `accept` and add a…
danielsun1106 commented on a change in pull request #902: GROOVY-9056: Rename
method `visit` of `ASTNode` to `accept` and add a…
URL: https://github.com/apache/groovy/pull/902#discussion_r268428491
##
File path: src/main/java/org/codehaus/groovy/ast/ASTNode.java
##
@@ -50,8 +50,18 @@
private int lastColumnNumber = -1;
private Map metaDataMap = null;
+public void accept(GroovyCodeVisitor visitor) {
+throw new RuntimeException("No accept() method implemented for class:
" + getClass().getName());
+}
+
+/**
+ * An alias method for {@link
org.codehaus.groovy.ast.ASTNode#accept(GroovyCodeVisitor)}
+ * Note: the method will be removed in a future version, e.g. Groovy 4 or
Groovy 5
Review comment:
In order to not disturb groovy users, we even do not add `@Deprecated` to
the alias method `visit`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [groovy] paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v…
paulk-asert commented on issue #891: GROOVY-9022: Added option under View menu of whether or not to have v… URL: https://github.com/apache/groovy/pull/891#issuecomment-475945250 Looks like a call to `resetToPreferredSizes()` fixes those glitches above. I'll merge your request and add in the call. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[jira] [Created] (GROOVY-9056) Rename method `visit` of `ASTNode` to `accept` and add an alias method `visit`
Daniel Sun created GROOVY-9056: -- Summary: Rename method `visit` of `ASTNode` to `accept` and add an alias method `visit` Key: GROOVY-9056 URL: https://issues.apache.org/jira/browse/GROOVY-9056 Project: Groovy Issue Type: Improvement Reporter: Daniel Sun Assignee: Daniel Sun Fix For: 3.0.0-beta-1 According to the naming conventions of Visitor Pattern( [https://en.wikipedia.org/wiki/Visitor_pattern#Java_example] ), we should rename method `visit` of `ASTNode` to `accept`, but we have to add an alias method `visit` for back compatibility. SEE the discussion in the dev mailing list: http://groovy.329449.n5.nabble.com/Rename-method-visit-of-ASTNode-to-accept-tt5757320.html -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-9057) Groovydoc should set exit code on errors
[
https://issues.apache.org/jira/browse/GROOVY-9057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16800172#comment-16800172
]
Paul King commented on GROOVY-9057:
---
Agreed, that could certainly do with some improvement. Existing behavior is to
continue on and process other files even when an error is encountered. Ideally
a fix would report an error but allow (or optionally allow) all files to be
processed.
> Groovydoc should set exit code on errors
>
>
> Key: GROOVY-9057
> URL: https://issues.apache.org/jira/browse/GROOVY-9057
> Project: Groovy
> Issue Type: Bug
> Components: GroovyDoc
>Affects Versions: 3.0.0-alpha-3, 2.5.2
>Reporter: Basil Peace
>Priority: Major
>
> Whenever the error occurs, GroovyDoc just reports it:
> {code:java}
> ERROR [org.codehaus.groovy.tools.groovydoc.GroovyRootDocBuilder] ignored due
> to RecognitionException: a/Test.java [expecting EOF, found '}']{code}
> and exits with success.
> Whenever error occurs, GroovyDoc should set exit code so that whoever called
> Groovydoc could handle the failure, e.g. stop the build.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
