[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69048658 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -472,37 +484,61 @@ public boolean hasNext() { @Override public List step(int

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69048558 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -482,7 +484,11 @@ public List step(int step) { * @return the incremented value */

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69048269 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -493,9 +491,9 @@ private Comparable peek() { for (int i = 0; i < step; i++) {

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69048213 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -187,7 +187,7 @@ public IntRange(boolean inclusive, int from, int to) { private void

[GitHub] groovy pull request #361: Replaced JDK 6 Travis build with JDK 8

GitHub user paplorinc opened a pull request: https://github.com/apache/groovy/pull/361 Replaced JDK 6 Travis build with JDK 8 You can merge this pull request into a Git repository by running: $ git pull https://github.com/paplorinc/incubator-groovy Travis Alternatively you

[GitHub] groovy pull request #:

Github user paplorinc commented on the pull request: https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18069445 In gradle/wrapper/gradle-wrapper.properties: In gradle/wrapper/gradle-wrapper.properties on line 6: Replaced it with JDK

[GitHub] groovy pull request #360: Changed the `Range`'s `step` to `Number` instead o...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69032404 --- Diff: .travis.yml --- @@ -16,8 +16,8 @@ language: groovy jdk: - - openjdk6 --- End diff -- I hope this will fix the

[GitHub] groovy pull request #:

Github user paplorinc commented on the pull request: https://github.com/apache/groovy/commit/f646e6e12abc3d1a9db0dcff74ff22ecadd986ca#commitcomment-18069008 In gradle/wrapper/gradle-wrapper.properties: In gradle/wrapper/gradle-wrapper.properties on line 6: Travis builds for

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69012937 --- Diff: src/test/groovy/RangeTest.groovy --- @@ -262,7 +262,24 @@ class RangeTest extends GroovyTestCase { assert (0..

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69002400 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -368,149 +367,152 @@ public String inspect() { * Also see containsWithinBounds.

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69002229 --- Diff: src/main/groovy/lang/ObjectRange.java --- @@ -331,24 +331,23 @@ public List subList(int fromIndex, int toIndex) { //

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69002046 --- Diff: src/main/groovy/lang/IntRange.java --- @@ -355,40 +360,54 @@ public boolean containsAll(Collection other) { return

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

Github user paplorinc commented on a diff in the pull request: https://github.com/apache/groovy/pull/360#discussion_r69000601 --- Diff: src/main/groovy/lang/Range.java --- @@ -73,23 +73,32 @@ boolean containsWithinBounds(Object o); /** + * Replaced

[GitHub] groovy pull request #360: Changed the `Range`'s step to `Number` instead of ...

GitHub user paplorinc opened a pull request: https://github.com/apache/groovy/pull/360 Changed the `Range`'s step to `Number` instead of `int` A revival of https://github.com/apache/groovy/pull/120 You can merge this pull request into a Git repository by running: $ git pull

[jira] [Updated] (GROOVY-7722) StackOverflowError when use anonymous class with generics.

[ https://issues.apache.org/jira/browse/GROOVY-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-7722: -- Remaining Estimate: (was: 12h) Original Estimate: (was: 12h) > StackOverflowError when

[jira] [Issue Comment Deleted] (GROOVY-7722) StackOverflowError when use anonymous class with generics.

[ https://issues.apache.org/jira/browse/GROOVY-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-7722: -- Comment: was deleted (was: See another example in the duplicate issue GROOVY-7864) >

[GitHub] groovy pull request #359: GROOVY-7877: Range step method could work with Num...

GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/359 GROOVY-7877: Range step method could work with Number not just int (a… …lternative utility method implementation) You can merge this pull request into a Git repository by running: $

[jira] [Commented] (GROOVY-7722) StackOverflowError when use anonymous class with generics.

[ https://issues.apache.org/jira/browse/GROOVY-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354795#comment-15354795 ] Paul King commented on GROOVY-7722: --- See another example in the duplicate issue GROOVY-7864 >

[jira] [Commented] (GROOVY-7722) StackOverflowError when use anonymous class with generics.

[ https://issues.apache.org/jira/browse/GROOVY-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354796#comment-15354796 ] Paul King commented on GROOVY-7722: --- See another example in the duplicate issue GROOVY-7864 >

[jira] [Closed] (GROOVY-7864) Stack overflow correcting generics when using @CompileStatic

[ https://issues.apache.org/jira/browse/GROOVY-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King closed GROOVY-7864. - Resolution: Duplicate Closing this in favor of the duplicate. > Stack overflow correcting generics when

[jira] [Commented] (GROOVY-7722) StackOverflowError when use anonymous class with generics.

[ https://issues.apache.org/jira/browse/GROOVY-7722?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354644#comment-15354644 ] Graeme Rocher commented on GROOVY-7722: --- Duplicated by

[jira] [Updated] (GROOVY-7864) Stack overflow correcting generics when using @CompileStatic

[ https://issues.apache.org/jira/browse/GROOVY-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Graeme Rocher updated GROOVY-7864: -- Labels: duplicate (was: ) > Stack overflow correcting generics when using @CompileStatic >

[jira] [Commented] (GROOVY-7864) Stack overflow correcting generics when using @CompileStatic

[ https://issues.apache.org/jira/browse/GROOVY-7864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354642#comment-15354642 ] Graeme Rocher commented on GROOVY-7864: --- This is a duplicate of

[jira] [Commented] (GROOVY-2972) groovy.lang.ObjectRange.size() disobeys its contract for large ranges of Long values.

[ https://issues.apache.org/jira/browse/GROOVY-2972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15354615#comment-15354615 ] Thibault Kruse commented on GROOVY-2972: IntRange still has issues. The constructor still fails