[jira] [Commented] (GROOVY-8696) TypeWrapper leaks out of DecompiledClassNode
[ https://issues.apache.org/jira/browse/GROOVY-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555176#comment-16555176 ] ASF GitHub Bot commented on GROOVY-8696: Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/773 > TypeWrapper leaks out of DecompiledClassNode > > > Key: GROOVY-8696 > URL: https://issues.apache.org/jira/browse/GROOVY-8696 > Project: Groovy > Issue Type: Bug > Components: Compiler >Affects Versions: 2.5.1 >Reporter: Paul King >Assignee: Paul King >Priority: Major > > A TypeWrapper wrapped class can appear directly as the default value for a > Class annotation attribute. This doesn't seem to affect the generated > bytecode but isn't what is expected within for instance AST transforms which > would expect to get a ClassExpression constant. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #773: GROOVY-8696: TypeWrapper leaks out of DecompiledCl...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/773 ---
[jira] [Resolved] (GROOVY-8712) groovy ant task was still looking for jar(s) in embeddable directory
[ https://issues.apache.org/jira/browse/GROOVY-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-8712. --- Resolution: Fixed Assignee: Paul King Fix Version/s: 2.5.2 Fixed as part of: 49238eddd > groovy ant task was still looking for jar(s) in embeddable directory > > > Key: GROOVY-8712 > URL: https://issues.apache.org/jira/browse/GROOVY-8712 > Project: Groovy > Issue Type: Bug >Reporter: Paul King >Assignee: Paul King >Priority: Major > Fix For: 2.5.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GROOVY-8712) groovy ant task was still looking for jar(s) in embeddable directory
Paul King created GROOVY-8712: - Summary: groovy ant task was still looking for jar(s) in embeddable directory Key: GROOVY-8712 URL: https://issues.apache.org/jira/browse/GROOVY-8712 Project: Groovy Issue Type: Bug Reporter: Paul King -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GROOVY-8711) Some doco/comments were still referring to the groovy-all jar
[ https://issues.apache.org/jira/browse/GROOVY-8711?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King resolved GROOVY-8711. --- Resolution: Fixed Assignee: Paul King Fix Version/s: 2.5.2 fixed by commits: 49238eddd dd1f4d4bc88 > Some doco/comments were still referring to the groovy-all jar > - > > Key: GROOVY-8711 > URL: https://issues.apache.org/jira/browse/GROOVY-8711 > Project: Groovy > Issue Type: Bug >Reporter: Paul King >Assignee: Paul King >Priority: Minor > Fix For: 2.5.2 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GROOVY-8711) Some doco/comments were still referring to the groovy-all jar
Paul King created GROOVY-8711: - Summary: Some doco/comments were still referring to the groovy-all jar Key: GROOVY-8711 URL: https://issues.apache.org/jira/browse/GROOVY-8711 Project: Groovy Issue Type: Bug Reporter: Paul King -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555151#comment-16555151 ] Paul King commented on GROOVY-8695: --- [~lptr] If I grep the output using --debug and look for groovy-all I see 2.4.15 nearly everywhere but 2.4.1 in about 10 places. Any idea where that groovy version is being used? > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554860#comment-16554860 ] Paul King edited comment on GROOVY-8695 at 7/25/18 5:25 AM: [~blackdrag] Just so I am clear, when you say "partial" do you mean partially for or partially against? If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate but quite a few of the transforms and for traits too. If it impacts fields as well, then there would be more transforms impacted. We could lazily sort having a utils method to call for all transforms that needed it but since ClassNode isn't immutable, it might be difficult to detect when it changed unless you baked it into the class. was (Author: paulk): Just so I am clear, when you say "partial" do you mean partially for or partially against? If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate but quite a few of the transforms and for traits too. If it impacts fields as well, then there would be more transforms impacted. We could lazily sort having a utils method to call for all transforms that needed it but since ClassNode isn't immutable, it might be difficult to detect when it changed unless you baked it into the class. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8710) JAXB JDK9-11 compatibility for install/dist
[ https://issues.apache.org/jira/browse/GROOVY-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555115#comment-16555115 ] Paul King commented on GROOVY-8710: --- This adds an "extras-jaxb" directory under lib that is only added to classpath for JDK9+. This is typically for commands within an installed distribution but may wish to check if your IDE points to a Groovy home. > JAXB JDK9-11 compatibility for install/dist > --- > > Key: GROOVY-8710 > URL: https://issues.apache.org/jira/browse/GROOVY-8710 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > > We should make the JAXB jars available and add them to classpath for JDK9+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Resolved] (GROOVY-8282) Error while popping argument from operand stack tracker in class ...$Trait$Helper
[
https://issues.apache.org/jira/browse/GROOVY-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-8282.
---
Resolution: Fixed
Assignee: Paul King
Fix Version/s: 2.5.2
Should be fixed in the next release. Thanks for spotting the issue.
> Error while popping argument from operand stack tracker in class
> ...$Trait$Helper
> -
>
> Key: GROOVY-8282
> URL: https://issues.apache.org/jira/browse/GROOVY-8282
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.8, 2.4.15, 2.5.1
>Reporter: Lucas Cimon
>Assignee: Paul King
>Priority: Minor
> Fix For: 2.5.2
>
>
> Hello.
> I'm facing a compilation error with this simple {{trait}} definition, with a
> public method invoking a private one with an implicit {{Map}}:
> {code}
> trait BugReproduction {
> def foo() {
> bar(a: 1)
> }
> private bar(Map args) {
> }
> }
> {code}
> The error message:
> {code}
> Caught: BUG! exception in phase 'class generation' in source unit
> 'file:/.../BugReproduction.groovy' Error while popping argument from operand
> stack tracker in class BugReproduction$Trait$Helper method java.lang.Object
> foo(BugReproduction).
> BUG! exception in phase 'class generation' in source unit
> 'file:/.../BugReproduction.groovy' Error while popping argument from operand
> stack tracker in class BugReproduction$Trait$Helper method java.lang.Object
> foo(BugReproduction).
> {code}
> I use Groovy v2.4.8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (GROOVY-8639) @Sortable annotation is not able to use accessible parent properties
[
https://issues.apache.org/jira/browse/GROOVY-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555110#comment-16555110
]
Paul King edited comment on GROOVY-8639 at 7/25/18 4:08 AM:
@Sortable now has the following additional annotation attributes:
includeSuperProperties defaults to false
allNames defaults to false
allProperties defaults to true
Thanks for spotting the potential improvement!
was (Author: paulk):
@Sortable now has the following additional annotation attributes:
includeSuperProperties defaults to false
allNames defaults to false
allProperties defaults to true
> @Sortable annotation is not able to use accessible parent properties
>
>
> Key: GROOVY-8639
> URL: https://issues.apache.org/jira/browse/GROOVY-8639
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-runtime
>Affects Versions: 2.4.12
> Environment: Linux 4.16.7 x86_64
> Java(TM) SE Runtime Environment (build 1.8.0_172-b11)
>Reporter: Gus Power
>Assignee: Paul King
>Priority: Minor
> Fix For: 2.5.2
>
> Attachments: SortableSpec.groovy
>
>
> The @Sortable annotation does not appear to support sorting by parent
> properties, e.g.
> {noformat}
> Error:(22, 5) Groovyc: Error during @Sortable processing: tried to include
> unknown property 'name'
> {noformat}
> Example:
> {code}
> import groovy.transform.Sortable
> import groovy.transform.ToString
> class SortableSpec {
> static void main(String[] args) {
> new SortableSpec().run()
> }
> void run() {
> Random random = Random.newInstance()
> (0..9).collect {
> new Thing(name: "${random.nextDouble()}")
> }.sort().each { println it }
> }
> static class Base {
> String name
> }
> // @Sortable(includes = 'name') <- fails compilation
> @Sortable
> @ToString(includeSuperProperties = true)
> final static class Thing extends Base {}
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Resolved] (GROOVY-8639) @Sortable annotation is not able to use accessible parent properties
[
https://issues.apache.org/jira/browse/GROOVY-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul King resolved GROOVY-8639.
---
Resolution: Fixed
Assignee: Paul King
Fix Version/s: 2.5.2
@Sortable now has the following additional annotation attributes:
includeSuperProperties defaults to false
allNames defaults to false
allProperties defaults to true
> @Sortable annotation is not able to use accessible parent properties
>
>
> Key: GROOVY-8639
> URL: https://issues.apache.org/jira/browse/GROOVY-8639
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-runtime
>Affects Versions: 2.4.12
> Environment: Linux 4.16.7 x86_64
> Java(TM) SE Runtime Environment (build 1.8.0_172-b11)
>Reporter: Gus Power
>Assignee: Paul King
>Priority: Minor
> Fix For: 2.5.2
>
> Attachments: SortableSpec.groovy
>
>
> The @Sortable annotation does not appear to support sorting by parent
> properties, e.g.
> {noformat}
> Error:(22, 5) Groovyc: Error during @Sortable processing: tried to include
> unknown property 'name'
> {noformat}
> Example:
> {code}
> import groovy.transform.Sortable
> import groovy.transform.ToString
> class SortableSpec {
> static void main(String[] args) {
> new SortableSpec().run()
> }
> void run() {
> Random random = Random.newInstance()
> (0..9).collect {
> new Thing(name: "${random.nextDouble()}")
> }.sort().each { println it }
> }
> static class Base {
> String name
> }
> // @Sortable(includes = 'name') <- fails compilation
> @Sortable
> @ToString(includeSuperProperties = true)
> final static class Thing extends Base {}
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] groovy pull request #774: GROOVY-8282: Error while popping argument from ope...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/774 ---
[jira] [Commented] (GROOVY-8282) Error while popping argument from operand stack tracker in class ...$Trait$Helper
[
https://issues.apache.org/jira/browse/GROOVY-8282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555104#comment-16555104
]
ASF GitHub Bot commented on GROOVY-8282:
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/774
> Error while popping argument from operand stack tracker in class
> ...$Trait$Helper
> -
>
> Key: GROOVY-8282
> URL: https://issues.apache.org/jira/browse/GROOVY-8282
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.8, 2.4.15, 2.5.1
>Reporter: Lucas Cimon
>Priority: Minor
>
> Hello.
> I'm facing a compilation error with this simple {{trait}} definition, with a
> public method invoking a private one with an implicit {{Map}}:
> {code}
> trait BugReproduction {
> def foo() {
> bar(a: 1)
> }
> private bar(Map args) {
> }
> }
> {code}
> The error message:
> {code}
> Caught: BUG! exception in phase 'class generation' in source unit
> 'file:/.../BugReproduction.groovy' Error while popping argument from operand
> stack tracker in class BugReproduction$Trait$Helper method java.lang.Object
> foo(BugReproduction).
> BUG! exception in phase 'class generation' in source unit
> 'file:/.../BugReproduction.groovy' Error while popping argument from operand
> stack tracker in class BugReproduction$Trait$Helper method java.lang.Object
> foo(BugReproduction).
> {code}
> I use Groovy v2.4.8
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8639) @Sortable annotation is not able to use accessible parent properties
[
https://issues.apache.org/jira/browse/GROOVY-8639?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16555054#comment-16555054
]
ASF GitHub Bot commented on GROOVY-8639:
Github user asfgit closed the pull request at:
https://github.com/apache/groovy/pull/775
> @Sortable annotation is not able to use accessible parent properties
>
>
> Key: GROOVY-8639
> URL: https://issues.apache.org/jira/browse/GROOVY-8639
> Project: Groovy
> Issue Type: Improvement
> Components: groovy-runtime
>Affects Versions: 2.4.12
> Environment: Linux 4.16.7 x86_64
> Java(TM) SE Runtime Environment (build 1.8.0_172-b11)
>Reporter: Gus Power
>Priority: Minor
> Attachments: SortableSpec.groovy
>
>
> The @Sortable annotation does not appear to support sorting by parent
> properties, e.g.
> {noformat}
> Error:(22, 5) Groovyc: Error during @Sortable processing: tried to include
> unknown property 'name'
> {noformat}
> Example:
> {code}
> import groovy.transform.Sortable
> import groovy.transform.ToString
> class SortableSpec {
> static void main(String[] args) {
> new SortableSpec().run()
> }
> void run() {
> Random random = Random.newInstance()
> (0..9).collect {
> new Thing(name: "${random.nextDouble()}")
> }.sort().each { println it }
> }
> static class Base {
> String name
> }
> // @Sortable(includes = 'name') <- fails compilation
> @Sortable
> @ToString(includeSuperProperties = true)
> final static class Thing extends Base {}
> }
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[GitHub] groovy pull request #775: GROOVY-8639: @Sortable annotation is not able to u...
Github user asfgit closed the pull request at: https://github.com/apache/groovy/pull/775 ---
[jira] [Updated] (GROOVY-8710) JAXB JDK9-11 compatibility for install/dist
[ https://issues.apache.org/jira/browse/GROOVY-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8710: -- Summary: JAXB JDK9-11 compatibility for install/dist (was: JDK9-11 compatibility for install) > JAXB JDK9-11 compatibility for install/dist > --- > > Key: GROOVY-8710 > URL: https://issues.apache.org/jira/browse/GROOVY-8710 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > > We should make the JAXB jars available and add them to classpath for JDK9+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554860#comment-16554860 ] Paul King edited comment on GROOVY-8695 at 7/24/18 10:31 PM: - Just so I am clear, when you say "partial" do you mean partially for or partially against? If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate but quite a few of the transforms and for traits too. If it impacts fields as well, then there would be more transforms impacted. We could lazily sort having a utils method to call for all transforms that needed it but since ClassNode isn't immutable, it might be difficult to detect when it changed unless you baked it into the class. was (Author: paulk): Just so I am clear, when you say "partial" do you mean partially for or partially against? If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate but quite a few of the transforms and for traits too. If it impacts fields as well, then there would be more transforms affected. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554860#comment-16554860 ] Paul King commented on GROOVY-8695: --- Just so I am clear, when you say "partial" do you mean partially for or partially against? If it's just methods that are impacted, I think we'd need to do sorting not just for @Delegate but quite a few of the transforms and for traits too. If it impacts fields as well, then there would be more transforms affected. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8710) JDK9-11 compatibility for install
[ https://issues.apache.org/jira/browse/GROOVY-8710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554781#comment-16554781 ] ASF GitHub Bot commented on GROOVY-8710: GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/776 GROOVY-8710: JAXB JDK9-11 compatibility for install You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8710 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #776 commit 87293c613c107944e493c11a51f9e2b497702064 Author: Paul King Date: 2018-07-24T20:47:57Z GROOVY-8710: JDK9-11 compatibility for install > JDK9-11 compatibility for install > - > > Key: GROOVY-8710 > URL: https://issues.apache.org/jira/browse/GROOVY-8710 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > > We should make the JAXB jars available and add them to classpath for JDK9+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #776: GROOVY-8710: JAXB JDK9-11 compatibility for instal...
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/776 GROOVY-8710: JAXB JDK9-11 compatibility for install You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8710 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/776.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #776 commit 87293c613c107944e493c11a51f9e2b497702064 Author: Paul King Date: 2018-07-24T20:47:57Z GROOVY-8710: JDK9-11 compatibility for install ---
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554780#comment-16554780 ] Jochen Theodorou commented on GROOVY-8695: -- LinkedHashMap helps only if the insertion order is stable between runs... something you can accomplish only if you specify a sorting. If you get random elements from the ClassNode because of reflection, then just a LinkedHashMap will not help. At the same time I am partial on sorting the methods in ClassNode. It is additional overhead we do not need in most cases, so it will slow down the compiler > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GROOVY-8710) JDK9-11 compatibility for install
Paul King created GROOVY-8710: - Summary: JDK9-11 compatibility for install Key: GROOVY-8710 URL: https://issues.apache.org/jira/browse/GROOVY-8710 Project: Groovy Issue Type: Improvement Reporter: Paul King We should make the JAXB jars available and add them to classpath for JDK9+ -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554649#comment-16554649 ] Paul King commented on GROOVY-8695: --- Cedric's last changes were to make sure ClassNode used LinkedHashMap. We could certainly make @Delegate do extra sorting but it would be more interesting to track where the discrepancy was coming from and fix it at the source. Otherwise, it will just be some next transform that will become the problem and require sorting too. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554455#comment-16554455 ] Jochen Theodorou commented on GROOVY-8695: -- Without actually having had a look at the code I would guess, that we get the method order from a map, which is either in ClassNode or it is determined by reflection. This map may not have a fixed order. The solution then obviously would be to give it an order.. for example sorting by method signatures in the @Delgate implementation. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[
https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554416#comment-16554416
]
Lóránt Pintér commented on GROOVY-8695:
---
>From the {{javap}} output it looks like the order of (delegate?) methods is
>different between the different versions of the output.
> @Delegate does not compile deterministically
>
>
> Key: GROOVY-8695
> URL: https://issues.apache.org/jira/browse/GROOVY-8695
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.12
>Reporter: Luke Daley
>Priority: Major
> Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip,
> ConcurrentSpecification.class, ConcurrentSpecification.class
>
>
> Checkout gradle/gradle from Github, run:
> ```
> ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy
> --no-build-cache && md5
> subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class
> ```
> This class is super thin:
> [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23]
>
> Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554405#comment-16554405 ] Lóránt Pintér commented on GROOVY-8695: --- I've attached ConcurrentSpecification-with-groovy-2.4.15.zip with a couple different class file versions. > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (GROOVY-8695) @Delegate does not compile deterministically
[
https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16554402#comment-16554402
]
Lóránt Pintér commented on GROOVY-8695:
---
I tried to run this with a Gradle 4.10 nightly that uses Groovy 2.4.15:
{code}
./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy
--no-build-cache; md5
subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class
{code}
It still results in different MD5s being generated:
{code}
MD5
(subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class)
= cebcafb31a5fb7114e3f65ae72c5d12a
MD5
(subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class)
= 6a7fef52e516b317355c6cd0fddf7f94
MD5
(subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class)
= f2600a8b15ff00051a6b4beb827f413b
{code}
That means this issue is not yet resolved.
> @Delegate does not compile deterministically
>
>
> Key: GROOVY-8695
> URL: https://issues.apache.org/jira/browse/GROOVY-8695
> Project: Groovy
> Issue Type: Bug
>Affects Versions: 2.4.12
>Reporter: Luke Daley
>Priority: Major
> Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip,
> ConcurrentSpecification.class, ConcurrentSpecification.class
>
>
> Checkout gradle/gradle from Github, run:
> ```
> ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy
> --no-build-cache && md5
> subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class
> ```
> This class is super thin:
> [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23]
>
> Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Updated] (GROOVY-8695) @Delegate does not compile deterministically
[ https://issues.apache.org/jira/browse/GROOVY-8695?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lóránt Pintér updated GROOVY-8695: -- Attachment: ConcurrentSpecification-with-groovy-2.4.15.zip > @Delegate does not compile deterministically > > > Key: GROOVY-8695 > URL: https://issues.apache.org/jira/browse/GROOVY-8695 > Project: Groovy > Issue Type: Bug >Affects Versions: 2.4.12 >Reporter: Luke Daley >Priority: Major > Attachments: ConcurrentSpecification-with-groovy-2.4.15.zip, > ConcurrentSpecification.class, ConcurrentSpecification.class > > > Checkout gradle/gradle from Github, run: > ``` > ./gradlew core:cleanCompileTestFixturesGroovy core:compileTestFixturesGroovy > --no-build-cache && md5 > subprojects/core/build/classes/groovy/testFixtures/org/gradle/util/ConcurrentSpecification.class > ``` > This class is super thin: > [https://github.com/gradle/gradle/blob/a1b9612fa06f90f20b115cede557e22287501034/subprojects/core/src/testFixtures/groovy/org/gradle/util/ConcurrentSpecification.groovy#L23] > > Guess is that it is `@Delegate` or `@Delegate` in conjunction with Spock > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
