[jira] [Commented] (GROOVY-8748) CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata
[ https://issues.apache.org/jira/browse/GROOVY-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16577743#comment-16577743 ] ASF GitHub Bot commented on GROOVY-8748: GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/783 GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act a… …s a "global" node for metadata You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/783.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #783 commit 027466b2a8ff104504644c541223f4c0532d7645 Author: Paul King Date: 2018-08-12T23:24:24Z GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata > CompileUnit could implement NodeMetaDataHandler to act as a "global" node for > metadata > -- > > Key: GROOVY-8748 > URL: https://issues.apache.org/jira/browse/GROOVY-8748 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > > This works better than using static fields to store such metadata. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #783: GROOVY-8748: CompileUnit could implement NodeMetaD...
GitHub user paulk-asert opened a pull request: https://github.com/apache/groovy/pull/783 GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act a⦠â¦s a "global" node for metadata You can merge this pull request into a Git repository by running: $ git pull https://github.com/paulk-asert/groovy groovy8748 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/groovy/pull/783.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #783 commit 027466b2a8ff104504644c541223f4c0532d7645 Author: Paul King Date: 2018-08-12T23:24:24Z GROOVY-8748: CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata ---
[jira] [Created] (GROOVY-8748) CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata
Paul King created GROOVY-8748: - Summary: CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata Key: GROOVY-8748 URL: https://issues.apache.org/jira/browse/GROOVY-8748 Project: Groovy Issue Type: Github Integration Reporter: Paul King This works better than using static fields to store such metadata. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (GROOVY-8748) CompileUnit could implement NodeMetaDataHandler to act as a "global" node for metadata
[ https://issues.apache.org/jira/browse/GROOVY-8748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Paul King updated GROOVY-8748: -- Issue Type: Improvement (was: Github Integration) > CompileUnit could implement NodeMetaDataHandler to act as a "global" node for > metadata > -- > > Key: GROOVY-8748 > URL: https://issues.apache.org/jira/browse/GROOVY-8748 > Project: Groovy > Issue Type: Improvement >Reporter: Paul King >Priority: Major > > This works better than using static fields to store such metadata. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (GROOVY-8747) jar/zip file and input stream are not closed in grape
[ https://issues.apache.org/jira/browse/GROOVY-8747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Daniel Sun closed GROOVY-8747. -- Resolution: Fixed Fix Version/s: 2.5.3 3.0.0-alpha-4 Fixed by: [https://github.com/apache/groovy/commit/e781898e5b03aea2d401fcb3e57eb467ab9f69ac] [https://github.com/apache/groovy/commit/7ca01a6ad4e8cb325a30d0a8742dd04ff98720fb] > jar/zip file and input stream are not closed in grape > - > > Key: GROOVY-8747 > URL: https://issues.apache.org/jira/browse/GROOVY-8747 > Project: Groovy > Issue Type: Bug >Reporter: Daniel Sun >Assignee: Daniel Sun >Priority: Major > Fix For: 3.0.0-alpha-4, 2.5.3 > > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (GROOVY-8747) jar/zip file and input stream are not closed in grape
Daniel Sun created GROOVY-8747: -- Summary: jar/zip file and input stream are not closed in grape Key: GROOVY-8747 URL: https://issues.apache.org/jira/browse/GROOVY-8747 Project: Groovy Issue Type: Bug Reporter: Daniel Sun Assignee: Daniel Sun -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[GitHub] groovy pull request #:
Github user danielsun1106 commented on the pull request: https://github.com/apache/groovy/commit/ed3814a053eee8a4480c85c23485e161fd74c16a#commitcomment-30046088 Nice! The codebase is much cleaner than before :-) ---
